From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C415C43462 for ; Sat, 1 May 2021 17:50:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2DCB26162B for ; Sat, 1 May 2021 17:50:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231724AbhEARoz (ORCPT ); Sat, 1 May 2021 13:44:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34356 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230391AbhEARow (ORCPT ); Sat, 1 May 2021 13:44:52 -0400 Received: from mail-pf1-x430.google.com (mail-pf1-x430.google.com [IPv6:2607:f8b0:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 363D1C06174A for ; Sat, 1 May 2021 10:44:01 -0700 (PDT) Received: by mail-pf1-x430.google.com with SMTP id i190so1239606pfc.12 for ; Sat, 01 May 2021 10:44:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dilger-ca.20150623.gappssmtp.com; s=20150623; h=content-transfer-encoding:from:mime-version:subject:date:message-id :references:cc:in-reply-to:to; bh=bteLvbdWFmjpY8EDbu1U3LFocxkdcdaEmOWgbjbb3e4=; b=Xj78uBm4c4NnxCJZlxp4GtzrG1pmHY8B3wWUNaFXF2RmfVL9vrSMFfeSWynGMRb/zu 95e/M6La/Ry/riBEMcLqGBrR7HAukcwSj10QDUJc8wt0pgZg6ARJh2AffHUmAUKlcV/+ 22uQERRAnSlVX/2guVplhffT0OvmD4KXY75SgMGTbBvLziDCaf9RlDMD0h4xfHeaGFA1 vG6NVia+DlMUZ/VWv3VJGC9lHWp53KnqA0Uqw9AUEW47C2YiTo+pVevpkKDY4VIRlrSP KI0AjVtYlQk6jt+jaDstc0Q7ftcbWvR2nyUo7UKPLznlCM6O/d548oVlZbhqUxpB9xnh 0+jQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:content-transfer-encoding:from:mime-version :subject:date:message-id:references:cc:in-reply-to:to; bh=bteLvbdWFmjpY8EDbu1U3LFocxkdcdaEmOWgbjbb3e4=; b=RDMWml4yCF1W3xHaRI6LG3Lwa8wkd0PKG7Pi8UXfnSenPnRdOcCAxT5HIuUcd+mpkB WC2KsaU1NFC/cp12gxZwVsqz1Ybh5iaDV0o+95wKHrJlPkH3MIHTir6VAwekQa0cZaKL 7eG4ogfOLPJ9DFGiOrP2yX7GcN35WXamHaIt15qlMbEEs5oPhBn8nVgV2xPKkaY66/uL iP+1Mf25w5zAC/DEGuE3mIO9Jq6/SMYqjGFOiLVm7fUeurIgmx29D22Y/IfHoQGlMRSa YqSlRJ9P3ezJu9NnqaBf9C2f3WPsBGdH8RV2tePfhJCtXX6GSwUkugeQSog6G0/gkwGU /hmw== X-Gm-Message-State: AOAM530o8HQkspNaZUFa3eR/7aK6gmW9qAb4kLvU9OicAEenrVCRJv4G vXgETWwhf+SpOREWcAXX3V5o6mzlfzYWWMyw X-Google-Smtp-Source: ABdhPJy6kSZSmlyplzOfziRmXT1Ukpj8AQOK9NXRBGPJvhlAoqvNQJKLloqX7XnZ9vYgQOPkxVrHeg== X-Received: by 2002:a62:3706:0:b029:211:3d70:a55a with SMTP id e6-20020a6237060000b02902113d70a55amr10297092pfa.16.1619891041184; Sat, 01 May 2021 10:44:01 -0700 (PDT) Received: from [192.168.10.175] (S01061cabc081bf83.cg.shawcable.net. [70.77.221.9]) by smtp.gmail.com with ESMTPSA id s32sm4998479pfw.2.2021.05.01.10.43.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 01 May 2021 10:44:00 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable From: Andreas Dilger Mime-Version: 1.0 (1.0) Subject: Re: [PATCH] fs: ext4: mballoc: amend goto to cleanup groupinfo memory correctly Date: Sat, 1 May 2021 10:43:57 -0700 Message-Id: <6E6AEEB4-1FBA-40F1-8328-8E304E68A7C6@dilger.ca> References: Cc: linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org In-Reply-To: To: Phillip Potter , tytso@mit.edu X-Mailer: iPhone Mail (18D70) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On May 1, 2021, at 02:18, Phillip Potter wrote: >=20 > =EF=BB=BFHi All, >=20 > Sorry to be pushy (I know everyone is busy) but I've had no feedback on > this patch yet: > https://lore.kernel.org/linux-ext4/20210412073837.1686-1-phil@philpotter.c= o.uk/T/#u >=20 > Could I please ask for it to be reviewed? Many thanks. Hi Phil, I've looked at the patch and it looks good. You can add my: Reviewed-by: Andreas Dilger Note in the future that it is a bit easier to review (IMHO) if you include t= he original patch in your ping email, but not a big deal.=20 Cheers, Andreas=