From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752883AbbFKJ2L (ORCPT ); Thu, 11 Jun 2015 05:28:11 -0400 Received: from mail1.bemta5.messagelabs.com ([195.245.231.151]:29369 "EHLO mail1.bemta5.messagelabs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750790AbbFKJ17 (ORCPT ); Thu, 11 Jun 2015 05:27:59 -0400 X-Env-Sender: stwiss.opensource@diasemi.com X-Msg-Ref: server-13.tower-180.messagelabs.com!1434014866!37398465!1 X-Originating-IP: [94.185.165.51] X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked From: "Opensource [Steve Twiss]" To: Lee Jones CC: LINUXKERNEL , Samuel Ortiz , Alessandro Zummo , DEVICETREE , David Dajun Chen , Dmitry Torokhov , Ian Campbell , Kumar Gala , LINUXINPUT , LINUXWATCHDOG , Liam Girdwood , "Mark Brown" , Mark Rutland , Pawel Moll , RTCLINUX , Rob Herring , Support Opensource , Wim Van Sebroeck Subject: RE: [PATCH V3 1/4] mfd: da9062: DA9062 MFD core driver Thread-Topic: [PATCH V3 1/4] mfd: da9062: DA9062 MFD core driver Thread-Index: AQHQkje+BbbztfyjIkOz27ag7HsO6Z2OZ74AgALzVjCAFbuuAP///SqAgAAVEsA= Date: Thu, 11 Jun 2015 09:27:45 +0000 Message-ID: <6ED8E3B22081A4459DAC7699F3695FB7014B22F4DC@SW-EX-MBX02.diasemi.com> References: <20150526161024.GQ11677@x1> <6ED8E3B22081A4459DAC7699F3695FB7014B22F4C4@SW-EX-MBX02.diasemi.com> <20150611085653.GG2982@x1> In-Reply-To: <20150611085653.GG2982@x1> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.20.26.77] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id t5B9SFGM009707 On 11 June 2015 09:57 Lee Jones wrote: > To: Opensource [Steve Twiss] > Subject: Re: [PATCH V3 1/4] mfd: da9062: DA9062 MFD core driver > > > > > > diff --git a/include/linux/mfd/da9062/registers.h [...] > > > > > +#define DA9062AA_WRITE_MODE_SHIFT 6 > > > > > +#define DA9062AA_WRITE_MODE_MASK (0x01 << 6) > > > > > > > > For 1 << X, you should use BIT(X). > > > > > > > > > > For the two comments above "Registers" and "Bit fields" and the (1< > > definitions ... > > > > > > The whole of this file is automatically generated by our hardware designers > > > I would prefer it if the register definitions and bit fields are not altered using > > > the #define BIT(nr) (1UL<<(nr)) macro and the comments removed because > > > we have scripts that can be used to check this file automatically. > > > > > > Also if the register map is ever updated, then it will be easier for me to diff > > > the new delivered register and bit field definitions with the old one. > > > > > > My preference would be not to change this header file. > > > > > > [...] > > > > If these last two things are a problem can you please let me know. HI Lee, Thanks for replying so quickly. > I'm still not particularly happy with this. Can yo speak to your H/W > guys and get them to change their scripts to output sensible header > files? Ah. Ok. For our side, the generated headers might not just be used for Linux. I've just discussed this with my colleagues and they will need it to remain. So I guess internally we will keep the headers like this, but as it enters my submission process I can change it for the Linux community. > To be honest, it's probably not a blocker for acceptance, but if someone > writes a patch next week to change all of the (0x01 << X) lines to > start using the BIT() macro, I will accept it. Better to influenced > your guys so you are not overly inconvenienced. Yep: I will change this BIT() macro for the submissions in future. Depending on the next step, I will send a patch to this or update the submission if there are further comments on this patch set. > FWIW, when upstreaming code, the excuse "someone else wrote it", has > never been a good one to use on the lists. Believe me, I've > tried. ;) heh okay :) Regards, Steve {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail1.bemta5.messagelabs.com (mail1.bemta5.messagelabs.com. [195.245.231.151]) by gmr-mx.google.com with ESMTPS id gt9si26173wib.2.2015.06.11.02.27.56 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 11 Jun 2015 02:27:57 -0700 (PDT) From: "Opensource [Steve Twiss]" To: Lee Jones CC: LINUXKERNEL , Samuel Ortiz , Alessandro Zummo , DEVICETREE , David Dajun Chen , Dmitry Torokhov , Ian Campbell , Kumar Gala , LINUXINPUT , LINUXWATCHDOG , Liam Girdwood , "Mark Brown" , Mark Rutland , Pawel Moll , RTCLINUX , Rob Herring , Support Opensource , Wim Van Sebroeck Subject: [rtc-linux] RE: [PATCH V3 1/4] mfd: da9062: DA9062 MFD core driver Date: Thu, 11 Jun 2015 09:27:45 +0000 Message-ID: <6ED8E3B22081A4459DAC7699F3695FB7014B22F4DC@SW-EX-MBX02.diasemi.com> References: <20150526161024.GQ11677@x1> <6ED8E3B22081A4459DAC7699F3695FB7014B22F4C4@SW-EX-MBX02.diasemi.com> <20150611085653.GG2982@x1> In-Reply-To: <20150611085653.GG2982@x1> Content-Type: text/plain; charset=UTF-8 MIME-Version: 1.0 Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , On 11 June 2015 09:57 Lee Jones wrote: > To: Opensource [Steve Twiss] > Subject: Re: [PATCH V3 1/4] mfd: da9062: DA9062 MFD core driver > > > > > > diff --git a/include/linux/mfd/da9062/registers.h [...] > > > > > +#define DA9062AA_WRITE_MODE_SHIFT 6 > > > > > +#define DA9062AA_WRITE_MODE_MASK (0x01 << 6) > > > > > > > > For 1 << X, you should use BIT(X). > > > > > > > > > > For the two comments above "Registers" and "Bit fields" and the (1< > > definitions ... > > > > > > The whole of this file is automatically generated by our hardware designers > > > I would prefer it if the register definitions and bit fields are not altered using > > > the #define BIT(nr) (1UL<<(nr)) macro and the comments removed because > > > we have scripts that can be used to check this file automatically. > > > > > > Also if the register map is ever updated, then it will be easier for me to diff > > > the new delivered register and bit field definitions with the old one. > > > > > > My preference would be not to change this header file. > > > > > > [...] > > > > If these last two things are a problem can you please let me know. HI Lee, Thanks for replying so quickly. > I'm still not particularly happy with this. Can yo speak to your H/W > guys and get them to change their scripts to output sensible header > files? Ah. Ok. For our side, the generated headers might not just be used for Linux. I've just discussed this with my colleagues and they will need it to remain. So I guess internally we will keep the headers like this, but as it enters my submission process I can change it for the Linux community. > To be honest, it's probably not a blocker for acceptance, but if someone > writes a patch next week to change all of the (0x01 << X) lines to > start using the BIT() macro, I will accept it. Better to influenced > your guys so you are not overly inconvenienced. Yep: I will change this BIT() macro for the submissions in future. Depending on the next step, I will send a patch to this or update the submission if there are further comments on this patch set. > FWIW, when upstreaming code, the excuse "someone else wrote it", has > never been a good one to use on the lists. Believe me, I've > tried. ;) heh okay :) Regards, Steve -- -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout. From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Opensource [Steve Twiss]" Subject: RE: [PATCH V3 1/4] mfd: da9062: DA9062 MFD core driver Date: Thu, 11 Jun 2015 09:27:45 +0000 Message-ID: <6ED8E3B22081A4459DAC7699F3695FB7014B22F4DC@SW-EX-MBX02.diasemi.com> References: <20150526161024.GQ11677@x1> <6ED8E3B22081A4459DAC7699F3695FB7014B22F4C4@SW-EX-MBX02.diasemi.com> <20150611085653.GG2982@x1> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20150611085653.GG2982@x1> Content-Language: en-US Sender: linux-watchdog-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Lee Jones Cc: LINUXKERNEL , Samuel Ortiz , Alessandro Zummo , DEVICETREE , David Dajun Chen , Dmitry Torokhov , Ian Campbell , Kumar Gala , LINUXINPUT , LINUXWATCHDOG , Liam Girdwood , Mark Brown , Mark Rutland , Pawel Moll , RTCLINUX , Rob Herring , Support Opensource , Wim Van Sebroeck List-Id: devicetree@vger.kernel.org T24gMTEgSnVuZSAyMDE1IDA5OjU3IExlZSBKb25lcyB3cm90ZToNCg0KPiBUbzogT3BlbnNvdXJj ZSBbU3RldmUgVHdpc3NdDQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggVjMgMS80XSBtZmQ6IGRhOTA2 MjogREE5MDYyIE1GRCBjb3JlIGRyaXZlcg0KPiANCj4gPiA+ID4gPiBkaWZmIC0tZ2l0IGEvaW5j bHVkZS9saW51eC9tZmQvZGE5MDYyL3JlZ2lzdGVycy5oDQoNClsuLi5dDQoNCj4gPiA+ID4gPiAr I2RlZmluZSBEQTkwNjJBQV9XUklURV9NT0RFX1NISUZUCTYNCj4gPiA+ID4gPiArI2RlZmluZSBE QTkwNjJBQV9XUklURV9NT0RFX01BU0sJKDB4MDEgPDwgNikNCj4gPiA+ID4NCj4gPiA+ID4gRm9y IDEgPDwgWCwgeW91IHNob3VsZCB1c2UgQklUKFgpLg0KPiA+ID4gPg0KPiA+ID4NCj4gPiA+IEZv ciB0aGUgdHdvIGNvbW1lbnRzIGFib3ZlICJSZWdpc3RlcnMiIGFuZCAiQml0IGZpZWxkcyIgYW5k IHRoZSAoMTw8eCkNCj4gPiA+IGRlZmluaXRpb25zIC4uLg0KPiA+ID4NCj4gPiA+IFRoZSB3aG9s ZSBvZiB0aGlzIGZpbGUgaXMgYXV0b21hdGljYWxseSBnZW5lcmF0ZWQgYnkgb3VyIGhhcmR3YXJl IGRlc2lnbmVycw0KPiA+ID4gSSB3b3VsZCBwcmVmZXIgaXQgaWYgdGhlIHJlZ2lzdGVyIGRlZmlu aXRpb25zIGFuZCBiaXQgZmllbGRzIGFyZSBub3QgYWx0ZXJlZCB1c2luZw0KPiA+ID4gdGhlICNk ZWZpbmUgQklUKG5yKSAoMVVMPDwobnIpKSBtYWNybyBhbmQgdGhlIGNvbW1lbnRzIHJlbW92ZWQg YmVjYXVzZQ0KPiA+ID4gd2UgaGF2ZSBzY3JpcHRzIHRoYXQgY2FuIGJlIHVzZWQgdG8gY2hlY2sg dGhpcyBmaWxlIGF1dG9tYXRpY2FsbHkuDQo+ID4gPg0KPiA+ID4gQWxzbyBpZiB0aGUgcmVnaXN0 ZXIgbWFwIGlzIGV2ZXIgdXBkYXRlZCwgdGhlbiBpdCB3aWxsIGJlIGVhc2llciBmb3IgbWUgdG8g ZGlmZg0KPiA+ID4gdGhlIG5ldyBkZWxpdmVyZWQgcmVnaXN0ZXIgYW5kIGJpdCBmaWVsZCBkZWZp bml0aW9ucyB3aXRoIHRoZSBvbGQgb25lLg0KPiA+ID4NCj4gPiA+IE15IHByZWZlcmVuY2Ugd291 bGQgYmUgbm90IHRvIGNoYW5nZSB0aGlzIGhlYWRlciBmaWxlLg0KPiA+ID4NCj4gPiA+IFsuLi5d DQo+ID4NCj4gPiBJZiB0aGVzZSBsYXN0IHR3byB0aGluZ3MgYXJlIGEgcHJvYmxlbSBjYW4geW91 IHBsZWFzZSBsZXQgbWUga25vdy4NCg0KSEkgTGVlLA0KDQpUaGFua3MgZm9yIHJlcGx5aW5nIHNv IHF1aWNrbHkuDQoNCj4gSSdtIHN0aWxsIG5vdCBwYXJ0aWN1bGFybHkgaGFwcHkgd2l0aCB0aGlz LiAgQ2FuIHlvIHNwZWFrIHRvIHlvdXIgSC9XDQo+IGd1eXMgYW5kIGdldCB0aGVtIHRvIGNoYW5n ZSB0aGVpciBzY3JpcHRzIHRvIG91dHB1dCBzZW5zaWJsZSBoZWFkZXINCj4gZmlsZXM/DQoNCkFo LiBPay4gDQoNCkZvciBvdXIgc2lkZSwgdGhlIGdlbmVyYXRlZCBoZWFkZXJzIG1pZ2h0IG5vdCBq dXN0IGJlIHVzZWQgZm9yIExpbnV4LiBJJ3ZlDQpqdXN0IGRpc2N1c3NlZCB0aGlzIHdpdGggbXkg Y29sbGVhZ3VlcyBhbmQgdGhleSB3aWxsIG5lZWQgaXQgdG8gcmVtYWluLg0KU28gSSBndWVzcyBp bnRlcm5hbGx5IHdlIHdpbGwga2VlcCB0aGUgaGVhZGVycyBsaWtlIHRoaXMsIGJ1dCBhcyBpdCBl bnRlcnMNCm15IHN1Ym1pc3Npb24gcHJvY2VzcyBJIGNhbiBjaGFuZ2UgaXQgZm9yIHRoZSBMaW51 eCBjb21tdW5pdHkuDQogDQo+IFRvIGJlIGhvbmVzdCwgaXQncyBwcm9iYWJseSBub3QgYSBibG9j a2VyIGZvciBhY2NlcHRhbmNlLCBidXQgaWYgc29tZW9uZQ0KPiB3cml0ZXMgYSBwYXRjaCBuZXh0 IHdlZWsgdG8gY2hhbmdlIGFsbCBvZiB0aGUgKDB4MDEgPDwgWCkgbGluZXMgdG8NCj4gc3RhcnQg dXNpbmcgdGhlIEJJVCgpIG1hY3JvLCBJIHdpbGwgYWNjZXB0IGl0LiAgQmV0dGVyIHRvIGluZmx1 ZW5jZWQNCj4geW91ciBndXlzIHNvIHlvdSBhcmUgbm90IG92ZXJseSBpbmNvbnZlbmllbmNlZC4N Cg0KWWVwOiBJIHdpbGwgY2hhbmdlIHRoaXMgQklUKCkgbWFjcm8gZm9yIHRoZSBzdWJtaXNzaW9u cyBpbiBmdXR1cmUuDQpEZXBlbmRpbmcgb24gdGhlIG5leHQgc3RlcCwgSSB3aWxsIHNlbmQgYSBw YXRjaCB0byB0aGlzIG9yIHVwZGF0ZSB0aGUgc3VibWlzc2lvbg0KaWYgdGhlcmUgYXJlIGZ1cnRo ZXIgY29tbWVudHMgb24gdGhpcyBwYXRjaCBzZXQuDQoNCj4gRldJVywgd2hlbiB1cHN0cmVhbWlu ZyBjb2RlLCB0aGUgZXhjdXNlICJzb21lb25lIGVsc2Ugd3JvdGUgaXQiLCBoYXMNCj4gbmV2ZXIg YmVlbiBhIGdvb2Qgb25lIHRvIHVzZSBvbiB0aGUgbGlzdHMuICAgQmVsaWV2ZSBtZSwgSSd2ZQ0K PiB0cmllZC4gOykNCg0KaGVoIG9rYXkgOikNCg0KUmVnYXJkcywNClN0ZXZlDQoNCg== -- To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail1.bemta5.messagelabs.com ([195.245.231.151]:29369 "EHLO mail1.bemta5.messagelabs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750790AbbFKJ17 (ORCPT ); Thu, 11 Jun 2015 05:27:59 -0400 From: "Opensource [Steve Twiss]" To: Lee Jones CC: LINUXKERNEL , Samuel Ortiz , Alessandro Zummo , DEVICETREE , David Dajun Chen , Dmitry Torokhov , Ian Campbell , Kumar Gala , LINUXINPUT , LINUXWATCHDOG , Liam Girdwood , "Mark Brown" , Mark Rutland , Pawel Moll , RTCLINUX , Rob Herring , Support Opensource , Wim Van Sebroeck Subject: RE: [PATCH V3 1/4] mfd: da9062: DA9062 MFD core driver Date: Thu, 11 Jun 2015 09:27:45 +0000 Message-ID: <6ED8E3B22081A4459DAC7699F3695FB7014B22F4DC@SW-EX-MBX02.diasemi.com> References: <20150526161024.GQ11677@x1> <6ED8E3B22081A4459DAC7699F3695FB7014B22F4C4@SW-EX-MBX02.diasemi.com> <20150611085653.GG2982@x1> In-Reply-To: <20150611085653.GG2982@x1> Content-Language: en-US Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 Sender: linux-watchdog-owner@vger.kernel.org List-Id: linux-watchdog@vger.kernel.org T24gMTEgSnVuZSAyMDE1IDA5OjU3IExlZSBKb25lcyB3cm90ZToNCg0KPiBUbzogT3BlbnNvdXJj ZSBbU3RldmUgVHdpc3NdDQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggVjMgMS80XSBtZmQ6IGRhOTA2 MjogREE5MDYyIE1GRCBjb3JlIGRyaXZlcg0KPiANCj4gPiA+ID4gPiBkaWZmIC0tZ2l0IGEvaW5j bHVkZS9saW51eC9tZmQvZGE5MDYyL3JlZ2lzdGVycy5oDQoNClsuLi5dDQoNCj4gPiA+ID4gPiAr I2RlZmluZSBEQTkwNjJBQV9XUklURV9NT0RFX1NISUZUCTYNCj4gPiA+ID4gPiArI2RlZmluZSBE QTkwNjJBQV9XUklURV9NT0RFX01BU0sJKDB4MDEgPDwgNikNCj4gPiA+ID4NCj4gPiA+ID4gRm9y IDEgPDwgWCwgeW91IHNob3VsZCB1c2UgQklUKFgpLg0KPiA+ID4gPg0KPiA+ID4NCj4gPiA+IEZv ciB0aGUgdHdvIGNvbW1lbnRzIGFib3ZlICJSZWdpc3RlcnMiIGFuZCAiQml0IGZpZWxkcyIgYW5k IHRoZSAoMTw8eCkNCj4gPiA+IGRlZmluaXRpb25zIC4uLg0KPiA+ID4NCj4gPiA+IFRoZSB3aG9s ZSBvZiB0aGlzIGZpbGUgaXMgYXV0b21hdGljYWxseSBnZW5lcmF0ZWQgYnkgb3VyIGhhcmR3YXJl IGRlc2lnbmVycw0KPiA+ID4gSSB3b3VsZCBwcmVmZXIgaXQgaWYgdGhlIHJlZ2lzdGVyIGRlZmlu aXRpb25zIGFuZCBiaXQgZmllbGRzIGFyZSBub3QgYWx0ZXJlZCB1c2luZw0KPiA+ID4gdGhlICNk ZWZpbmUgQklUKG5yKSAoMVVMPDwobnIpKSBtYWNybyBhbmQgdGhlIGNvbW1lbnRzIHJlbW92ZWQg YmVjYXVzZQ0KPiA+ID4gd2UgaGF2ZSBzY3JpcHRzIHRoYXQgY2FuIGJlIHVzZWQgdG8gY2hlY2sg dGhpcyBmaWxlIGF1dG9tYXRpY2FsbHkuDQo+ID4gPg0KPiA+ID4gQWxzbyBpZiB0aGUgcmVnaXN0 ZXIgbWFwIGlzIGV2ZXIgdXBkYXRlZCwgdGhlbiBpdCB3aWxsIGJlIGVhc2llciBmb3IgbWUgdG8g ZGlmZg0KPiA+ID4gdGhlIG5ldyBkZWxpdmVyZWQgcmVnaXN0ZXIgYW5kIGJpdCBmaWVsZCBkZWZp bml0aW9ucyB3aXRoIHRoZSBvbGQgb25lLg0KPiA+ID4NCj4gPiA+IE15IHByZWZlcmVuY2Ugd291 bGQgYmUgbm90IHRvIGNoYW5nZSB0aGlzIGhlYWRlciBmaWxlLg0KPiA+ID4NCj4gPiA+IFsuLi5d DQo+ID4NCj4gPiBJZiB0aGVzZSBsYXN0IHR3byB0aGluZ3MgYXJlIGEgcHJvYmxlbSBjYW4geW91 IHBsZWFzZSBsZXQgbWUga25vdy4NCg0KSEkgTGVlLA0KDQpUaGFua3MgZm9yIHJlcGx5aW5nIHNv IHF1aWNrbHkuDQoNCj4gSSdtIHN0aWxsIG5vdCBwYXJ0aWN1bGFybHkgaGFwcHkgd2l0aCB0aGlz LiAgQ2FuIHlvIHNwZWFrIHRvIHlvdXIgSC9XDQo+IGd1eXMgYW5kIGdldCB0aGVtIHRvIGNoYW5n ZSB0aGVpciBzY3JpcHRzIHRvIG91dHB1dCBzZW5zaWJsZSBoZWFkZXINCj4gZmlsZXM/DQoNCkFo LiBPay4gDQoNCkZvciBvdXIgc2lkZSwgdGhlIGdlbmVyYXRlZCBoZWFkZXJzIG1pZ2h0IG5vdCBq dXN0IGJlIHVzZWQgZm9yIExpbnV4LiBJJ3ZlDQpqdXN0IGRpc2N1c3NlZCB0aGlzIHdpdGggbXkg Y29sbGVhZ3VlcyBhbmQgdGhleSB3aWxsIG5lZWQgaXQgdG8gcmVtYWluLg0KU28gSSBndWVzcyBp bnRlcm5hbGx5IHdlIHdpbGwga2VlcCB0aGUgaGVhZGVycyBsaWtlIHRoaXMsIGJ1dCBhcyBpdCBl bnRlcnMNCm15IHN1Ym1pc3Npb24gcHJvY2VzcyBJIGNhbiBjaGFuZ2UgaXQgZm9yIHRoZSBMaW51 eCBjb21tdW5pdHkuDQogDQo+IFRvIGJlIGhvbmVzdCwgaXQncyBwcm9iYWJseSBub3QgYSBibG9j a2VyIGZvciBhY2NlcHRhbmNlLCBidXQgaWYgc29tZW9uZQ0KPiB3cml0ZXMgYSBwYXRjaCBuZXh0 IHdlZWsgdG8gY2hhbmdlIGFsbCBvZiB0aGUgKDB4MDEgPDwgWCkgbGluZXMgdG8NCj4gc3RhcnQg dXNpbmcgdGhlIEJJVCgpIG1hY3JvLCBJIHdpbGwgYWNjZXB0IGl0LiAgQmV0dGVyIHRvIGluZmx1 ZW5jZWQNCj4geW91ciBndXlzIHNvIHlvdSBhcmUgbm90IG92ZXJseSBpbmNvbnZlbmllbmNlZC4N Cg0KWWVwOiBJIHdpbGwgY2hhbmdlIHRoaXMgQklUKCkgbWFjcm8gZm9yIHRoZSBzdWJtaXNzaW9u cyBpbiBmdXR1cmUuDQpEZXBlbmRpbmcgb24gdGhlIG5leHQgc3RlcCwgSSB3aWxsIHNlbmQgYSBw YXRjaCB0byB0aGlzIG9yIHVwZGF0ZSB0aGUgc3VibWlzc2lvbg0KaWYgdGhlcmUgYXJlIGZ1cnRo ZXIgY29tbWVudHMgb24gdGhpcyBwYXRjaCBzZXQuDQoNCj4gRldJVywgd2hlbiB1cHN0cmVhbWlu ZyBjb2RlLCB0aGUgZXhjdXNlICJzb21lb25lIGVsc2Ugd3JvdGUgaXQiLCBoYXMNCj4gbmV2ZXIg YmVlbiBhIGdvb2Qgb25lIHRvIHVzZSBvbiB0aGUgbGlzdHMuICAgQmVsaWV2ZSBtZSwgSSd2ZQ0K PiB0cmllZC4gOykNCg0KaGVoIG9rYXkgOikNCg0KUmVnYXJkcywNClN0ZXZlDQoNCg==