From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932380AbcJNNIu convert rfc822-to-8bit (ORCPT ); Fri, 14 Oct 2016 09:08:50 -0400 Received: from mail1.bemta5.messagelabs.com ([195.245.231.145]:24838 "EHLO mail1.bemta5.messagelabs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753478AbcJNNII (ORCPT ); Fri, 14 Oct 2016 09:08:08 -0400 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpjk+JIrShJLcpLzFFi42KJ27nUWHfDDYY Ig45XehYz5y9htZj68Ambxfwj51gtDi96wWgx/8o1Vov7X48yWny70sFkcfPTN1aLy7vmsFl8 7j3CaHFj3T52iycLzzBZLL1+kcmide8RIPdhH5vFrRkvWB0EPNbMW8PosXPWXXaPa5vFPBbve cnksWlVJ5vHnWt72Dx2fm9g9zh+YzuTx+dNcgGcUayZeUn5FQmsGQ19c5gKlnNX/D5/k6mBcQ lnFyMXh5DAMkaJ/u33mLsYOTnYBAwl5r15zwhiiwhkSjze3cYOUsQssItFYubkH+wgCWGBRIn V27cyQxQlSfza8RHI5gCynSRWNriAhFkEVCW6f68Cm8MrECBxvG06E4gtJNDHJHF+iSmIzSkQ KPGj9RHYGEYBWYkvjavBbGYBcYlbT+aD1UsICEgs2XOeGcIWlXj5+B8rhC0vsfbXE6i4vcTre +9YIGx9iUePHzFC2IYSq6YdYAE5TULAXKL1igPEeB2JBbs/sUHY2hLLFr5mhjhTUOLkzCcsEx jFZyG5YhaSlllIWmYhaVnAyLKKUaM4tagstUjXyEAvqSgzPaMkNzEzR9fQwFQvN7W4ODE9NSc xqVgvOT93EyMwfdQzMDDuYGyc7XeIUZKDSUmUt1aPIUKILyk/pTIjsTgjvqg0J7X4EKMMB4eS BG/TdaCcYFFqempFWmYOMJHBpCU4eJREeKuuAaV5iwsSc4sz0yFSpxgVpcR5w0H6BEASGaV5c G2w5HmJUVZKmJeRgYFBiKcgtSg3swRV/hWjOAejkjCvHcgUnsy8Erjpr4AWMwEt/tAGtrgkES El1cAoekLv4AXea8Zl93ZUxB4riM6qLVhWZy3SEFbcaBs0vfeKtelJ7fXLbJ/defY8+szqNUo KN47Fhe79cpP/XcXGyu8NdbsufJnXo1/49XjiRO7K6F2LjRvMnr45f/ZTx2ONC2Y2UQmXjnhY Vy18eMfq/dF2iRn3Ph/RCMv9smnR4YwAw6tPJ9Q0KrEUZyQaajEXFScCALmDXgaZAwAA X-Env-Sender: stwiss.opensource@diasemi.com X-Msg-Ref: server-4.tower-178.messagelabs.com!1476450480!64637744!1 X-Originating-IP: [94.185.165.51] X-StarScan-Received: X-StarScan-Version: 8.84; banners=-,-,- X-VirusChecked: Checked From: Steve Twiss To: Keerthy , Eduardo Valentin , "Zhang Rui" CC: DEVICETREE , Dmitry Torokhov , Guenter Roeck , LINUX-INPUT , LINUX-WATCHDOG , Lee Jones , "Liam Girdwood" , Mark Brown , Mark Rutland , Rob Herring , Support Opensource , Wim Van Sebroeck , LINUX-KERNEL , LINUX-PM Subject: RE: [PATCH V1 05/10] thermal: da9062/61: Thermal junction temperature monitoring driver Thread-Topic: [PATCH V1 05/10] thermal: da9062/61: Thermal junction temperature monitoring driver Thread-Index: AQHSH7B3m++mOrvh0ECD7ljm7p6YrKCcZ0SAgAC5ZLCACtUXYA== Date: Fri, 14 Oct 2016 13:07:59 +0000 Message-ID: <6ED8E3B22081A4459DAC7699F3695FB7018CCE3443@SW-EX-MBX02.diasemi.com> References: <3bc9fd76-2885-b07a-9df8-7802b7535da2@ti.com> <6ED8E3B22081A4459DAC7699F3695FB7018CCE2815@SW-EX-MBX02.diasemi.com> In-Reply-To: <6ED8E3B22081A4459DAC7699F3695FB7018CCE2815@SW-EX-MBX02.diasemi.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.20.26.77] x-kse-attachmentfiltering-interceptor-info: protection disabled x-kse-serverinfo: sw-ex-cashub02.diasemi.com, 9 x-kse-antivirus-interceptor-info: scan successful x-kse-antivirus-info: Clean, bases: 14/10/2016 11:26:00 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org An update. On: 07 October 2016 18:49, Steve Twiss wrote: > On 07 October 2016 06:29, Keerthy [mailto:a0393675@ti.com] wrote: > > On Thursday 06 October 2016 02:13 PM, Steve Twiss wrote: > > > From: Steve Twiss [...] > > > +static const struct da9062_thermal_config da9062_config = { > > > + .name = "da9062-thermal", > > > +}; > > > + > > > +static const struct da9062_thermal_config da9061_config = { > > > + .name = "da9061-thermal", > > > +}; > > > + > > > +static const struct of_device_id da9062_compatible_reg_id_table[] = { > > > + { .compatible = "dlg,da9062-thermal", .data = &da9062_config }, > > > + { .compatible = "dlg,da9061-thermal", .data = &da9061_config }, > > > > Two separate compatible values. Do you have anything different apart > > from the name? Why use 2 compatibles when there is absolutely no > > difference? > > Yes. > This was a comment for the watchdog device driver as well. My concern was having > multiple devices (61 and 62) in the same system -- and allowing the driver to report > the hardware difference. > > There is discussion going on about this in other threads. Not certain of the > final outcome yet, apart from my existing proposal should be changed. An answer to this came from comments by Dmitry Torokhov and Guenter Roeck, who suggested this: https://lkml.org/lkml/2016/10/7/641 I will take a look at this for V2. Regards, Steve From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail1.bemta5.messagelabs.com ([195.245.231.145]:24838 "EHLO mail1.bemta5.messagelabs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753478AbcJNNII (ORCPT ); Fri, 14 Oct 2016 09:08:08 -0400 From: Steve Twiss To: Keerthy , Eduardo Valentin , "Zhang Rui" CC: DEVICETREE , Dmitry Torokhov , Guenter Roeck , LINUX-INPUT , LINUX-WATCHDOG , Lee Jones , "Liam Girdwood" , Mark Brown , Mark Rutland , Rob Herring , Support Opensource , Wim Van Sebroeck , LINUX-KERNEL , LINUX-PM Subject: RE: [PATCH V1 05/10] thermal: da9062/61: Thermal junction temperature monitoring driver Date: Fri, 14 Oct 2016 13:07:59 +0000 Message-ID: <6ED8E3B22081A4459DAC7699F3695FB7018CCE3443@SW-EX-MBX02.diasemi.com> References: <3bc9fd76-2885-b07a-9df8-7802b7535da2@ti.com> <6ED8E3B22081A4459DAC7699F3695FB7018CCE2815@SW-EX-MBX02.diasemi.com> In-Reply-To: <6ED8E3B22081A4459DAC7699F3695FB7018CCE2815@SW-EX-MBX02.diasemi.com> Content-Language: en-US Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Sender: linux-watchdog-owner@vger.kernel.org List-Id: linux-watchdog@vger.kernel.org Content-Transfer-Encoding: quoted-printable An update. On: 07 October 2016 18:49, Steve Twiss wrote: > On 07 October 2016 06:29, Keerthy [mailto:a0393675@ti.com] wrote: > > On Thursday 06 October 2016 02:13 PM, Steve Twiss wrote: > > > From: Steve Twiss [...] > > > +static const struct da9062_thermal_config da9062_config =3D { > > > + .name =3D "da9062-thermal", > > > +}; > > > + > > > +static const struct da9062_thermal_config da9061_config =3D { > > > + .name =3D "da9061-thermal", > > > +}; > > > + > > > +static const struct of_device_id da9062_compatible_reg_id_table[] = =3D { > > > + { .compatible =3D "dlg,da9062-thermal", .data =3D &da9062_config = }, > > > + { .compatible =3D "dlg,da9061-thermal", .data =3D &da9061_config = }, > > > > Two separate compatible values. Do you have anything different apart > > from the name? Why use 2 compatibles when there is absolutely no > > difference? >=20 > Yes. > This was a comment for the watchdog device driver as well. My concern w= as having > multiple devices (61 and 62) in the same system -- and allowing the dri= ver to report > the hardware difference. >=20 > There is discussion going on about this in other threads. Not certain o= f the > final outcome yet, apart from my existing proposal should be changed. An answer to this came from comments by Dmitry Torokhov and Guenter Roeck= , who suggested this: https://lkml.org/lkml/2016/10/7/641 I will take a look at this for V2. Regards, Steve -- To unsubscribe from this list: send the line "unsubscribe linux-watchdog"= in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html