From: Steve Twiss <stwiss.opensource@diasemi.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: LINUX-KERNEL <linux-kernel@vger.kernel.org>,
DEVICETREE <devicetree@vger.kernel.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Eduardo Valentin <edubezval@gmail.com>,
Guenter Roeck <linux@roeck-us.net>,
LINUX-INPUT <linux-input@vger.kernel.org>,
LINUX-PM <linux-pm@vger.kernel.org>,
LINUX-WATCHDOG <linux-watchdog@vger.kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
Rob Herring <robh+dt@kernel.org>,
"Support Opensource" <Support.Opensource@diasemi.com>,
Wim Van Sebroeck <wim@iguana.be>, Zhang Rui <rui.zhang@intel.com>
Subject: RE: [PATCH V7 4/7] mfd: da9061: MFD core support
Date: Mon, 3 Apr 2017 14:20:09 +0000 [thread overview]
Message-ID: <6ED8E3B22081A4459DAC7699F3695FB7018CD6B183@SW-EX-MBX02.diasemi.com> (raw)
In-Reply-To: <20170403141214.q6ndii6c47pqfqx6@dell>
On 03 April 2017 15:12, Lee Jones wrote:
> > @@ -475,7 +855,25 @@ static int da9062_i2c_probe(struct i2c_client *i2c,
> > return -EINVAL;
> > }
> >
> > - chip->regmap = devm_regmap_init_i2c(i2c, &da9062_regmap_config);
> > + switch (chip->chip_type) {
> > + case(COMPAT_TYPE_DA9061):
>
> Brackets around the case value?
>
> That's a new one on me.
Hm. Do you want me to resend it without braces?
Regards,
Stephen
next prev parent reply other threads:[~2017-04-03 14:20 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-28 14:43 [PATCH V7 0/7] da9061: DA9061 driver submission Steve Twiss
2017-03-28 14:43 ` [PATCH V7 1/7] Documentation: devicetree: watchdog: da9062/61 watchdog timer binding Steve Twiss
2017-03-28 14:43 ` Steve Twiss
2017-03-28 14:43 ` [PATCH V7 2/7] Documentation: devicetree: thermal: da9062/61 TJUNC temperature binding Steve Twiss
2017-03-28 14:43 ` [PATCH V7 3/7] Documentation: devicetree: mfd: da9062/61 MFD binding Steve Twiss
2017-03-28 14:43 ` Steve Twiss
2017-04-03 13:39 ` Lee Jones
2017-04-03 13:39 ` Lee Jones
2017-03-28 14:43 ` [PATCH V7 4/7] mfd: da9061: MFD core support Steve Twiss
2017-03-28 14:43 ` Steve Twiss
2017-04-03 14:12 ` Lee Jones
2017-04-03 14:12 ` Lee Jones
2017-04-03 14:12 ` Lee Jones
2017-04-03 14:20 ` Steve Twiss [this message]
2017-04-03 14:30 ` Lee Jones
2017-04-03 14:30 ` Lee Jones
2017-04-03 15:56 ` Steve Twiss
2017-04-04 8:34 ` Lee Jones
2017-04-04 8:34 ` Lee Jones
2017-04-04 8:34 ` Lee Jones
2017-03-28 14:43 ` [PATCH V7 5/7] regulator: da9061: BUCK and LDO regulator driver Steve Twiss
2017-03-28 14:43 ` Steve Twiss
2017-03-28 14:43 ` [PATCH V7 6/7] thermal: da9062/61: Thermal junction temperature monitoring driver Steve Twiss
2017-04-01 19:59 ` Eduardo Valentin
2017-04-03 13:21 ` Steve Twiss
2017-04-03 13:21 ` Steve Twiss
2017-03-28 14:43 ` [PATCH V7 7/7] MAINTAINERS: da9062/61 updates to the Dialog Semiconductor search terms Steve Twiss
2017-03-28 14:43 ` Steve Twiss
2017-04-07 4:51 ` [PATCH V7 0/7] da9061: DA9061 driver submission Eduardo Valentin
[not found] <cover.1491230802.git.stwiss.opensource@diasemi.com>
2017-04-03 14:46 ` [PATCH V7 4/7] mfd: da9061: MFD core support Steve Twiss
2017-04-04 8:39 ` Lee Jones
2017-04-04 8:39 ` Lee Jones
2017-04-24 10:37 ` Steve Twiss
2017-04-24 10:37 ` Steve Twiss
2017-04-24 12:38 ` Lee Jones
2017-04-24 12:38 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ED8E3B22081A4459DAC7699F3695FB7018CD6B183@SW-EX-MBX02.diasemi.com \
--to=stwiss.opensource@diasemi.com \
--cc=Support.Opensource@diasemi.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=edubezval@gmail.com \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=rui.zhang@intel.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.