From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S968334AbdEWPBp (ORCPT ); Tue, 23 May 2017 11:01:45 -0400 Received: from mail1.bemta3.messagelabs.com ([195.245.230.168]:30651 "EHLO mail1.bemta3.messagelabs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934441AbdEWPBk (ORCPT ); Tue, 23 May 2017 11:01:40 -0400 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrOKsWRWlGSWpSXmKPExsUSt3Opse4JP5V Ig4aVIhbNi9ezWUzZ8IHJYtXUnSwWD+beZLK4vGsOm8WZxb3sFrcnTmZ0YPfYP3cNu0f/XwOP 9Vuusnh83iQXwBLFmpmXlF+RwJqx/cJT5oJ1nhUfd1xma2Dc4tHFyMUhJLCUUeLjoo3sXYycH GwChhLz3rxnBLFFBDwltjy4xwJSxCywl0li0b1nTCAJYYEUiZcT/7JDFKVKPLr5FaiIA8h2k9 h8RR4kzCKgKvFgeR9YOa9AgMTJrkmsEMteMUo8WnoMbAGngK3EzK1rmUFsRgFZiS+Nq8FsZgF xiVtP5oM1SwgISCzZc54ZwhaVePn4HyuELS+x9tcTqLi9xOt771ggbH2JR48fMULYhhKrph2A iptLvLn+mxnkTmYBTYn1u/QhVilKTOl+yA5xp6DEyZlPWCYwis9CcsUshI5ZSDpmIelYwMiyi lG9OLWoLLVI11QvqSgzPaMkNzEzR9fQwFgvN7W4ODE9NScxqVgvOT93EyMwYusZGBh3MF7+6n SIUZKDSUmUd0+CcqQQX1J+SmVGYnFGfFFpTmrxIUYNDg6BKwePzGaUYsnLz0tVkuBd66sSKSR YlJqeWpGWmQNMKTClEhw8SiK8HSBp3uKCxNzizHSI1ClGXY59f7++ZxICmyElztsDUiQAUpRR mgc3ApbeLjHKSgnzMjIwMAjxFKQW5WaWoMq/YhTnYFQS5p0OMoUnM68EbhMwaoF+EeF1vasMc kRJIkJKqoEx+vLcT+Zv1m858+81g6GDgN8kZ+l7d/PCgkqfnMlYM2XFux32NuflGp/La19g82 TO68xa+ELuz8dS1qtCU6VnyE7etUXiYmtqyWr/6aXMywuYyqaI2Yi+WnZgvdn23XsuH2rK0uL bX7v10VLtcOPA2lX201J13nVxneNbfMX7zkO/pxOjVTPeK7EUZyQaajEXFScCAL5tAfBqAwAA X-Env-Sender: stwiss.opensource@diasemi.com X-Msg-Ref: server-2.tower-38.messagelabs.com!1495551687!86660976!1 X-Originating-IP: [94.185.165.51] X-StarScan-Received: X-StarScan-Version: 9.4.12; banners=-,-,- X-VirusChecked: Checked From: Steve Twiss To: =?utf-8?B?VXdlIEtsZWluZS1Lw7ZuaWc=?= CC: Greg Kroah-Hartman , Jiri Slaby , LINUX-KERNEL , LINUX-SERIAL , Lucas Stach , "Support Opensource" , "kernel@pengutronix.de" Subject: RE: [PATCH V1] serial: imx: revert setup DCEDTE early and ensure DCD and RI irqs to be off Thread-Topic: [PATCH V1] serial: imx: revert setup DCEDTE early and ensure DCD and RI irqs to be off Thread-Index: AQHS08CMDyJLJsr9eUuGzzq+TlSyCKIB5CyAgAAUpnD///MNgIAAEjFg Date: Tue, 23 May 2017 15:01:26 +0000 Message-ID: <6ED8E3B22081A4459DAC7699F3695FB7018CD8D328@SW-EX-MBX02.diasemi.com> References: <20170523123145.E268B3FAD4@swsrvapps-01.diasemi.com> <20170523140941.l6cjvfdsvsg76cbx@pengutronix.de> <6ED8E3B22081A4459DAC7699F3695FB7018CD8D303@SW-EX-MBX02.diasemi.com> <20170523143715.yeg3gpkmvlu4l5kt@pengutronix.de> In-Reply-To: <20170523143715.yeg3gpkmvlu4l5kt@pengutronix.de> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.20.26.77] x-kse-attachmentfiltering-interceptor-info: protection disabled x-kse-serverinfo: sw-ex-cashub02.diasemi.com, 9 x-kse-antivirus-interceptor-info: scan successful x-kse-antivirus-info: Clean, bases: 23/05/2017 11:12:00 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id v4NF2ID3020501 Hi Uwe, On 23 May 2017 15:37, Uwe Kleine-König wrote: > Subject: Re: [PATCH V1] serial: imx: revert setup DCEDTE early and ensure DCD and RI irqs to be off > On Tue, May 23, 2017 at 02:28:11PM +0000, Steve Twiss wrote: > > On 23 May 2017 15:10, Uwe Kleine-König wrote: > > > On Tue, May 23, 2017 at 01:17:26PM +0100, Steve Twiss wrote: > > > > > > > > Revert the commit e61c38d85b7392e ("serial: imx: setup DCEDTE early and > > > > ensure DCD and RI irqs to be off") > > > > The patch submitted to setup DCEDTE early and ensure DCD and RI irqs to > > > > be off, causes a serial console display problem the i.MX6Q SABRESD board. > > > > The console becomes unreadable and unwritable. > > > > > > > > Tested-by: Steve Twiss > > > > Signed-off-by: Steve Twiss > > > > > > You're not the first to report this issue but you still have the chance > > > to be the first to test a suggested patch for it. > > > > I've just applied your patch against a clean linux-next/v4.12-rc2 > > I added your patch ... > > > > > http://marc.info/?l=linux-serial&m=149434029912947&w=2 > > [...] > > I've added that to my working directory, but I am still seeing the corrupted > > console output on the i.MX6 Q (quad) board. > > I don't have a failing board (I think). So here are a few questions > about yours: > > - how does the dts snippet for your failing device look like? I am using the standard DTS from the v4.12-rc2 kernel, no changes. I did an earlier test yesterday using the DTS from v4.11 to see if it was the new imx7 changes that have recently gone into the kernel but I still see the same effect. > - This is not the device the console runs on, right? I am connected through the USB to UART, U22 on the i.MX6Q board. Terminal set to 115200 baud, no parity, 8bit data. > - Can you initialize the device in the bootloader and check if it is working there? I can get U-boot ok for all cases. Once I TFTP the kernel across, I am okay until I get to "Starting kernel ...", then, the UART is "working" in the sense that I get the some characters in the style of the kernel starting up, but they are all garbled. I expect the kernel has started ok, but I am unable to read/write through the UART console because of corruptions. Console log: --- 8< --- U-Boot 2009.08-00001-gf65536a (Jan 12 2015 - 15:47:19) CPU: Freescale i.MX6 family TO1.2 at 792 MHz Thermal sensor with ratio = 200 Temperature: 46 C, calibration data 0x5f15527d mx6q pll1: 792MHz mx6q pll2: 528MHz mx6q pll3: 480MHz mx6q pll8: 50MHz ipg clock : 66000000Hz ipg per clock : 66000000Hz uart clock : 80000000Hz cspi clock : 60000000Hz ahb clock : 132000000Hz axi clock : 264000000Hz emi_slow clock: 132000000Hz ddr clock : 528000000Hz usdhc1 clock : 198000000Hz usdhc2 clock : 198000000Hz usdhc3 clock : 198000000Hz usdhc4 clock : 198000000Hz nfc clock : 24000000Hz Board: i.MX6Q-SABRESD: unknown-board Board: 0x63012 [WDOG ] Boot Device: SD I2C: ready DRAM: 1 GB MMC: FSL_USDHC: 0,FSL_USDHC: 1,FSL_USDHC: 2,FSL_USDHC: 3 In: serial Out: serial Err: serial Found PFUZE100! deviceid=10,revid=11 Net: got MAC address from IIM: 00:04:9f:02:e3:0a FEC0 [PRIME] Hit any key to stop autoboot: 0 PHY indentify @ 0x1 = 0x004dd074 FEC: Link is Up 796d Using FEC0 device TFTP from server 192.168.2.1; our IP address is 192.168.2.2 Filename 'uImage_dtb.imx6q.v4.12-rc2'. Load address: 0x12000000 Loading: ################################################################# ################################################################# ################################################################# ################################################################# ################################################################# ################################################################# ################################################################# ################################################################# ################################################################# ################################################################# ################################################################# ################################################################# ################################################################# ################################################################# ################################################################# ################################################################# ################################################################# ########################################################## done Bytes transferred = 5951108 (5ace84 hex) ## Booting kernel from Legacy Image at 12000000 ... Image Name: Image Type: ARM Linux Kernel Image (uncompressed) Data Size: 5951044 Bytes = 5.7 MB Load Address: 10800000 Entry Point: 10800000 Verifying Checksum ... OK Loading Kernel Image ... OK OK Starting kernel ... àüüpþàüþüààààüþüàüüþüàüàààüŽàüàüàààà€ààüþüààüüÿ ààüŽüþüàüàðààðàààþ~pàœà`þüàüŽàààüàþüþàüàŽààà ààüüÿààüŽüþüàüàð€ààààààðààðàüààüðààðàààþüÿüðüüŽàüŽàààüü þüÿààüüpðüÀüþüüàààüpÿüààðààðàüàðàüàŽ~8àŽààŽààü€ààðààüp ŽààüàààààðàüðààðàüàpþàüðàüðààþàðàüààààààðààðàüüàŽà€üàà Žüà~ÿüààààüüŽààüþàü~Žüàðààðààààþà€üààðü~ÿàüŽààüŽüþüàðààà Žüà~ÿüàŽààü€þüàðààü€àüðààüüà€àüà€üààŽàüààààãpŽààüü þüàüàüŽààüþüààààþàü€üüðààààãpŽà€àüàüŽààüþüààŽü --- 8< --- > - Does it make a difference in Linux if the bootloader used the device before? If you mean, if U-boot uses the UART console before loading the kernel, then no. Is that what you mean? It makes no difference until the kernel is loaded, then the serial output gets corrupted. > - Can you dump the register space of the uart with v4.12-rc2 and > v4.12-rc2 + revert of e61c38d85b7392e? Difficult to do that I think. The console is unusable in both directions. I can't get any response from the console (through typing) once the kernel has started. Regards, Steve