From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752336AbaCXIMK (ORCPT ); Mon, 24 Mar 2014 04:12:10 -0400 Received: from mail1.bemta5.messagelabs.com ([195.245.231.146]:12679 "EHLO mail1.bemta5.messagelabs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751022AbaCXIMG (ORCPT ); Mon, 24 Mar 2014 04:12:06 -0400 X-Env-Sender: stwiss.opensource@diasemi.com X-Msg-Ref: server-13.tower-179.messagelabs.com!1395648723!26694764!1 X-Originating-IP: [94.185.165.51] X-StarScan-Received: X-StarScan-Version: 6.11.1; banners=-,-,- X-VirusChecked: Checked From: "Opensource [Steve Twiss]" To: Lee Jones CC: Guenter Roeck , Jean Delvare , "David Dajun Chen" , LINUX-DOC , LINUX-KERNEL , LM-SENSORS , Mark Brown , Philipp Zabel , Rob Landley , Samuel Ortiz Subject: RE: [RFC V1 1/3] hwmon: da9063: HWMON driver Thread-Topic: [RFC V1 1/3] hwmon: da9063: HWMON driver Thread-Index: AQHPRttXGKX6/plr5kirxkYUlEAgKprv3kKAgAABUKA= Date: Mon, 24 Mar 2014 08:12:02 +0000 Message-ID: <6ED8E3B22081A4459DAC7699F3695FB7A2AFC31D@SW-EX-MBX01.diasemi.com> References: <420d4f5c8436a66b511693531cfeda131258ce69.1395607051.git.stwiss.opensource@diasemi.com> <20140324075221.GF8541@lee--X1> In-Reply-To: <20140324075221.GF8541@lee--X1> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.20.26.61] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id s2O8CJEo013618 Hi Lee, Thank you for the fast reply. On 24 March 2014 07:52 Lee Jones wrote, >> From: Opensource [Steve Twiss] >> >> Add the HWMON driver for DA9063 >> >> Signed-off-by: Opensource [Steve Twiss] >> --- >> >> drivers/hwmon/Kconfig | 10 + >> drivers/hwmon/Makefile | 1 + >> drivers/hwmon/da9063-hwmon.c | 456 >++++++++++++++++++++++++++++++++++ >> include/linux/mfd/da9063/registers.h | 34 +++ > >I'd prefer to see all values in hex, but this probably a preference >thing rather than something which would prevent acceptance. > >For the MFD header changes: > Acked-by: Lee Jones > Thanks for the Ack. > +#define DA9063_ADC_RES (1 << (DA9063_ADC_RES_L_BITS + DA9063_ADC_RES_M_BITS)) > +#define DA9063_ADC_MAX (DA9063_ADC_RES - 1) >> +#define DA9063_2V5 2500 >> +#define DA9063_5V0 5000 >> +#define DA9063_5V5 5500 >> +#define DA9063_TJUNC_M -420 >> +#define DA9063_TJUNC_C -812 >> +#define DA9063_VBBAT_M 2048 I am using these defines as part of the base-10 calculations in the conversion routines for voltage and temperature. I guess they do look weird .. and looking at it, I have mixed division by 1024 as a right shift 10 in the TJUNC calculation. I will re-format that part and put a comment in the defines to explain. Thanks. >> + case DA9063_CHAN_ADCIN1: >> + case DA9063_CHAN_ADCIN2: >> + case DA9063_CHAN_ADCIN3: >> + val = (DA9063_2V5 * val) / DA9063_ADC_MAX; >> + break; >> + case DA9063_CHAN_VSYS: >> + val = ((DA9063_5V5 - DA9063_2V5) * val) / DA9063_ADC_MAX + >> + DA9063_2V5; >> + break; >> + case DA9063_CHAN_TJUNC: >> + val -= hwmon->tjunc_offset; >> + val = (DA9063_TJUNC_M * (val + DA9063_TJUNC_C)) >> 10; >> + break; >> + case DA9063_CHAN_VBBAT: >> + val = (DA9063_5V0 * val) / DA9063_ADC_MAX; >> + break; > >-- >Lee Jones >Linaro STMicroelectronics Landing Team Lead >Linaro.org │ Open source software for ARM SoCs >Follow Linaro: Facebook | Twitter | Blog Regards, Steve {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Opensource [Steve Twiss]" Date: Mon, 24 Mar 2014 08:12:02 +0000 Subject: Re: [lm-sensors] [RFC V1 1/3] hwmon: da9063: HWMON driver Message-Id: <6ED8E3B22081A4459DAC7699F3695FB7A2AFC31D@SW-EX-MBX01.diasemi.com> List-Id: References: <420d4f5c8436a66b511693531cfeda131258ce69.1395607051.git.stwiss.opensource@diasemi.com> <20140324075221.GF8541@lee--X1> In-Reply-To: <20140324075221.GF8541@lee--X1> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Lee Jones Cc: Guenter Roeck , Jean Delvare , David Dajun Chen , LINUX-DOC , LINUX-KERNEL , LM-SENSORS , Mark Brown , Philipp Zabel , Rob Landley , Samuel Ortiz SGkgTGVlLA0KVGhhbmsgeW91IGZvciB0aGUgZmFzdCByZXBseS4NCg0KT24gMjQgTWFyY2ggMjAx NCAwNzo1MiBMZWUgSm9uZXMgd3JvdGUsDQo+PiBGcm9tOiBPcGVuc291cmNlIFtTdGV2ZSBUd2lz c10gPHN0d2lzcy5vcGVuc291cmNlQGRpYXNlbWkuY29tPg0KPj4NCj4+IEFkZCB0aGUgSFdNT04g ZHJpdmVyIGZvciBEQTkwNjMNCj4+DQo+PiBTaWduZWQtb2ZmLWJ5OiBPcGVuc291cmNlIFtTdGV2 ZSBUd2lzc10gPHN0d2lzcy5vcGVuc291cmNlQGRpYXNlbWkuY29tPg0KPj4gLS0tDQo+Pg0KPj4g IGRyaXZlcnMvaHdtb24vS2NvbmZpZyAgICAgICAgICAgICAgICB8ICAgMTAgKw0KPj4gIGRyaXZl cnMvaHdtb24vTWFrZWZpbGUgICAgICAgICAgICAgICB8ICAgIDEgKw0KPj4gIGRyaXZlcnMvaHdt b24vZGE5MDYzLWh3bW9uLmMgICAgICAgICB8ICA0NTYNCj4rKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrDQo+PiAgaW5jbHVkZS9saW51eC9tZmQvZGE5MDYzL3JlZ2lzdGVycy5oIHwg ICAzNCArKysNCj4NCj5JJ2QgcHJlZmVyIHRvIHNlZSBhbGwgdmFsdWVzIGluIGhleCwgYnV0IHRo aXMgcHJvYmFibHkgYSBwcmVmZXJlbmNlDQo+dGhpbmcgcmF0aGVyIHRoYW4gc29tZXRoaW5nIHdo aWNoIHdvdWxkIHByZXZlbnQgYWNjZXB0YW5jZS4NCj4NCj5Gb3IgdGhlIE1GRCBoZWFkZXIgY2hh bmdlczoNCj4gIEFja2VkLWJ5OiBMZWUgSm9uZXMgPGxlZS5qb25lc0BsaW5hcm8ub3JnPg0KPg0K VGhhbmtzIGZvciB0aGUgQWNrLg0KDQo8c25pcD4NCj4gKyNkZWZpbmUgREE5MDYzX0FEQ19SRVMJ KDEgPDwgKERBOTA2M19BRENfUkVTX0xfQklUUyArIERBOTA2M19BRENfUkVTX01fQklUUykpDQo+ ICsjZGVmaW5lIERBOTA2M19BRENfTUFYCShEQTkwNjNfQURDX1JFUyAtIDEpDQo+PiArI2RlZmlu ZSBEQTkwNjNfMlY1CTI1MDANCj4+ICsjZGVmaW5lIERBOTA2M181VjAJNTAwMA0KPj4gKyNkZWZp bmUgREE5MDYzXzVWNQk1NTAwDQo+PiArI2RlZmluZSBEQTkwNjNfVEpVTkNfTQktNDIwDQo+PiAr I2RlZmluZSBEQTkwNjNfVEpVTkNfQwktODEyDQo+PiArI2RlZmluZSBEQTkwNjNfVkJCQVRfTQky MDQ4DQoNCkkgYW0gdXNpbmcgdGhlc2UgZGVmaW5lcyBhcyBwYXJ0IG9mIHRoZSBiYXNlLTEwIGNh bGN1bGF0aW9ucyBpbiB0aGUgY29udmVyc2lvbg0Kcm91dGluZXMgZm9yIHZvbHRhZ2UgYW5kIHRl bXBlcmF0dXJlLg0KSSBndWVzcyB0aGV5IGRvIGxvb2sgd2VpcmQgLi4gYW5kIGxvb2tpbmcgYXQg aXQsIEkgaGF2ZSBtaXhlZCAgZGl2aXNpb24gYnkgMTAyNA0KYXMgYSByaWdodCBzaGlmdCAxMCBp biB0aGUgVEpVTkMgY2FsY3VsYXRpb24uDQoNCkkgd2lsbCByZS1mb3JtYXQgdGhhdCBwYXJ0IGFu ZCBwdXQgYSBjb21tZW50IGluIHRoZSBkZWZpbmVzIHRvIGV4cGxhaW4uDQpUaGFua3MuDQoNCjxz bmlwPg0KPj4gKwljYXNlIERBOTA2M19DSEFOX0FEQ0lOMToNCj4+ICsJY2FzZSBEQTkwNjNfQ0hB Tl9BRENJTjI6DQo+PiArCWNhc2UgREE5MDYzX0NIQU5fQURDSU4zOg0KPj4gKwkJdmFsID0gKERB OTA2M18yVjUgKiB2YWwpIC8gREE5MDYzX0FEQ19NQVg7DQo+PiArCQlicmVhazsNCj4+ICsJY2Fz ZSBEQTkwNjNfQ0hBTl9WU1lTOg0KPj4gKwkJdmFsID0gKChEQTkwNjNfNVY1IC0gREE5MDYzXzJW NSkgKiB2YWwpIC8gREE5MDYzX0FEQ19NQVggKw0KPj4gKwkJCURBOTA2M18yVjU7DQo+PiArCQli cmVhazsNCj4+ICsJY2FzZSBEQTkwNjNfQ0hBTl9USlVOQzoNCj4+ICsJCXZhbCAtPSBod21vbi0+ dGp1bmNfb2Zmc2V0Ow0KPj4gKwkJdmFsID0gKERBOTA2M19USlVOQ19NICogKHZhbCArIERBOTA2 M19USlVOQ19DKSkgPj4gMTA7DQo+PiArCQlicmVhazsNCj4+ICsJY2FzZSBEQTkwNjNfQ0hBTl9W QkJBVDoNCj4+ICsJCXZhbCA9IChEQTkwNjNfNVYwICogdmFsKSAvIERBOTA2M19BRENfTUFYOw0K Pj4gKwkJYnJlYWs7DQoNCjxzbmlwPg0KPg0KPi0tDQo+TGVlIEpvbmVzDQo+TGluYXJvIFNUTWlj cm9lbGVjdHJvbmljcyBMYW5kaW5nIFRlYW0gTGVhZA0KPkxpbmFyby5vcmcg4pSCIE9wZW4gc291 cmNlIHNvZnR3YXJlIGZvciBBUk0gU29Dcw0KPkZvbGxvdyBMaW5hcm86IEZhY2Vib29rIHwgVHdp dHRlciB8IEJsb2cNCg0KUmVnYXJkcywNClN0ZXZlDQpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpsbS1zZW5zb3JzIG1haWxpbmcgbGlzdApsbS1zZW5zb3Jz QGxtLXNlbnNvcnMub3JnCmh0dHA6Ly9saXN0cy5sbS1zZW5zb3JzLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2xtLXNlbnNvcnM