From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755263AbbATNXn (ORCPT ); Tue, 20 Jan 2015 08:23:43 -0500 Received: from mail1.bemta5.messagelabs.com ([195.245.231.150]:21077 "EHLO mail1.bemta5.messagelabs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754519AbbATNXl (ORCPT ); Tue, 20 Jan 2015 08:23:41 -0500 X-Env-Sender: stwiss.opensource@diasemi.com X-Msg-Ref: server-13.tower-180.messagelabs.com!1421760204!41928012!1 X-Originating-IP: [94.185.165.51] X-StarScan-Received: X-StarScan-Version: 6.12.5; banners=-,-,- X-VirusChecked: Checked From: "Opensource [Steve Twiss]" To: Lee Jones CC: Grant Likely , Mark Brown , Philipp Zabel , Rob Herring , Samuel Ortiz , DT , "David Dajun Chen" , Ian Campbell , Kumar Gala , LKML , Mark Rutland , "Pawel Moll" , Support Opensource Subject: RE: [PATCH V2 1/2] mfd: da9063: Add device tree support Thread-Topic: [PATCH V2 1/2] mfd: da9063: Add device tree support Thread-Index: AQHQNAY/P+aw9292NEy5C38h4IQM85zI1G8AgAAAJQA= Date: Tue, 20 Jan 2015 13:23:23 +0000 Message-ID: <6ED8E3B22081A4459DAC7699F3695FB7D0B52DA5@SW-EX-MBX02.diasemi.com> References: <20150120104544.GS5767@x1> In-Reply-To: <20150120104544.GS5767@x1> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.20.26.77] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id t0KDNmeH012216 On 20 January 2015 10:46 Lee Jones wrote: [...] > > static const struct regmap_range da9063_ad_readable_ranges[] = { > > { > > .range_min = DA9063_REG_PAGE_CON, > > @@ -203,6 +206,13 @@ static struct regmap_config da9063_regmap_config > = { > > .cache_type = REGCACHE_RBTREE, > > }; > > > > +static const struct of_device_id da9063_dt_ids[] = { > > + { .compatible = "dlg,da9063-ad", }, > > + { .compatible = "dlg,da9063-bb", }, > > + { .compatible = "dlg,da9063-ca", }, > > I'm still a bit bemused as to why these require their own compatible > strings? They are never matched (of_match_device()) on and it appears > they can be dynamically told apart by poking. > Yes: like you said. Why bother with a 2-letter variant code in the DT if the driver's behaviour is automatic? It was a design style decision on my side. I was being explicit in my definitions and I added the 2-letter code to handle (potential) differences in the way platform data can be handled in the driver. There is nothing right now, I was just considering the future and the ABI. However, I've talked myself round this argument several times -- I guess the explicit compatibility letters in the devices tree are jarring against the automatic detection inside the driver. I will remove the 2-letter extensions from the next submission. Regards, Steve {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Opensource [Steve Twiss]" Subject: RE: [PATCH V2 1/2] mfd: da9063: Add device tree support Date: Tue, 20 Jan 2015 13:23:23 +0000 Message-ID: <6ED8E3B22081A4459DAC7699F3695FB7D0B52DA5@SW-EX-MBX02.diasemi.com> References: <20150120104544.GS5767@x1> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20150120104544.GS5767@x1> Content-Language: en-US Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Lee Jones Cc: Grant Likely , Mark Brown , Philipp Zabel , Rob Herring , Samuel Ortiz , DT , David Dajun Chen , Ian Campbell , Kumar Gala , LKML , Mark Rutland , Pawel Moll , Support Opensource List-Id: devicetree@vger.kernel.org DQpPbiAyMCBKYW51YXJ5IDIwMTUgMTA6NDYgTGVlIEpvbmVzIHdyb3RlOg0KDQpbLi4uXQ0KDQo+ ID4gIHN0YXRpYyBjb25zdCBzdHJ1Y3QgcmVnbWFwX3JhbmdlIGRhOTA2M19hZF9yZWFkYWJsZV9y YW5nZXNbXSA9IHsNCj4gPiAgCXsNCj4gPiAgCQkucmFuZ2VfbWluID0gREE5MDYzX1JFR19QQUdF X0NPTiwNCj4gPiBAQCAtMjAzLDYgKzIwNiwxMyBAQCBzdGF0aWMgc3RydWN0IHJlZ21hcF9jb25m aWcgZGE5MDYzX3JlZ21hcF9jb25maWcNCj4gPSB7DQo+ID4gIAkuY2FjaGVfdHlwZSA9IFJFR0NB Q0hFX1JCVFJFRSwNCj4gPiAgfTsNCj4gPg0KPiA+ICtzdGF0aWMgY29uc3Qgc3RydWN0IG9mX2Rl dmljZV9pZCBkYTkwNjNfZHRfaWRzW10gPSB7DQo+ID4gKwl7IC5jb21wYXRpYmxlID0gImRsZyxk YTkwNjMtYWQiLCB9LA0KPiA+ICsJeyAuY29tcGF0aWJsZSA9ICJkbGcsZGE5MDYzLWJiIiwgfSwN Cj4gPiArCXsgLmNvbXBhdGlibGUgPSAiZGxnLGRhOTA2My1jYSIsIH0sDQo+IA0KPiBJJ20gc3Rp bGwgYSBiaXQgYmVtdXNlZCBhcyB0byB3aHkgdGhlc2UgcmVxdWlyZSB0aGVpciBvd24gY29tcGF0 aWJsZQ0KPiBzdHJpbmdzPyAgVGhleSBhcmUgbmV2ZXIgbWF0Y2hlZCAob2ZfbWF0Y2hfZGV2aWNl KCkpIG9uIGFuZCBpdCBhcHBlYXJzDQo+IHRoZXkgY2FuIGJlIGR5bmFtaWNhbGx5IHRvbGQgYXBh cnQgYnkgcG9raW5nLg0KPiANCg0KWWVzOiBsaWtlIHlvdSBzYWlkLiBXaHkgYm90aGVyIHdpdGgg YSAyLWxldHRlciB2YXJpYW50IGNvZGUgaW4gdGhlIERUIGlmIHRoZQ0KZHJpdmVyJ3MgYmVoYXZp b3VyIGlzIGF1dG9tYXRpYz8NCg0KSXQgd2FzIGEgZGVzaWduIHN0eWxlIGRlY2lzaW9uIG9uIG15 IHNpZGUuIEkgd2FzIGJlaW5nIGV4cGxpY2l0IGluIG15IGRlZmluaXRpb25zIA0KYW5kIEkgYWRk ZWQgdGhlIDItbGV0dGVyIGNvZGUgdG8gaGFuZGxlIChwb3RlbnRpYWwpIGRpZmZlcmVuY2VzIGlu IHRoZSB3YXkNCnBsYXRmb3JtIGRhdGEgY2FuIGJlIGhhbmRsZWQgaW4gdGhlIGRyaXZlci4gVGhl cmUgaXMgbm90aGluZyByaWdodCBub3csIEkgd2FzIGp1c3QNCmNvbnNpZGVyaW5nIHRoZSBmdXR1 cmUgYW5kIHRoZSBBQkkuDQoNCkhvd2V2ZXIsIEkndmUgdGFsa2VkIG15c2VsZiByb3VuZCB0aGlz IGFyZ3VtZW50IHNldmVyYWwgdGltZXMgLS0gSSBndWVzcyB0aGUNCmV4cGxpY2l0IGNvbXBhdGli aWxpdHkgbGV0dGVycyBpbiB0aGUgZGV2aWNlcyB0cmVlIGFyZSBqYXJyaW5nIGFnYWluc3QgdGhl IGF1dG9tYXRpYw0KZGV0ZWN0aW9uIGluc2lkZSB0aGUgZHJpdmVyLg0KDQpJIHdpbGwgcmVtb3Zl IHRoZSAyLWxldHRlciBleHRlbnNpb25zIGZyb20gdGhlIG5leHQgc3VibWlzc2lvbi4NCg0KUmVn YXJkcywNClN0ZXZlDQoNCg0K -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html