From mboxrd@z Thu Jan  1 00:00:00 1970
From: John David Anglin <dave.anglin@bell.net>
Subject: Re: [PATCH] parisc: Fix syscall restarts
Date: Sun, 20 Dec 2015 15:53:14 -0500
Message-ID: <6F2369FE-0BB1-4D0E-A3C6-BC7DF623FE4F@bell.net>
References: <20151218233034.GA24910@p100.box> <6E922C83-B2CF-4B18-94B4-E848EF7305F9@bell.net> <56770D46.3030909@gmx.de> <56770DE1.7050904@gmx.de>
Mime-Version: 1.0 (Apple Message framework v1085)
Content-Type: text/plain; charset=us-ascii
Cc: linux-parisc@vger.kernel.org,
	James Bottomley <James.Bottomley@HansenPartnership.com>,
	Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
To: Helge Deller <deller@gmx.de>
Return-path: <linux-parisc-owner@vger.kernel.org>
In-Reply-To: <56770DE1.7050904@gmx.de>
List-ID: <linux-parisc.vger.kernel.org>
List-Id: linux-parisc.vger.kernel.org

On 2015-12-20, at 3:21 PM, Helge Deller wrote:

> On 20.12.2015 21:19, Helge Deller wrote:
>> On 20.12.2015 21:14, John David Anglin wrote:
>>> On 2015-12-18, at 6:30 PM, Helge Deller wrote:
>>> 
>>>> +	/* Get assembler opcode of code in delay branch */
>>>> +	uaddr = (unsigned int *) (regs->gr[31] + 1);
>>> 
>>> Shouldn't increment be 4?
>> 
>> No.
>> The first address which is being executed in userspace is regs->gr[31]-3.
> 
> I could (should?) have used
> 	uaddr = (unsigned int *) ((regs->gr[31] & ~3) + 4);


Possibly that is better.  The former assumes user space is at level 3.

Dave
--
John David Anglin	dave.anglin@bell.net