From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [PATCH] clk/samsung: Clear OF_POPULATED flag from clkout node in init callback To: Marek Szyprowski , linux-clk@vger.kernel.org, linux-samsung-soc@vger.kernel.org References: <1477398861-2270-1-git-send-email-m.szyprowski@samsung.com> Cc: Stephen Boyd , Michael Turquette , Sylwester Nawrocki , Chanwoo Choi , Krzysztof Kozlowski , Bartlomiej Zolnierkiewicz From: Javier Martinez Canillas Message-ID: <6a1165ff-e169-09f7-6ee6-c5d368d042ae@osg.samsung.com> Date: Tue, 25 Oct 2016 11:16:20 -0300 MIME-Version: 1.0 In-Reply-To: <1477398861-2270-1-git-send-email-m.szyprowski@samsung.com> Content-Type: text/plain; charset=windows-1252 List-ID: Hello Marek, On 10/25/2016 09:34 AM, Marek Szyprowski wrote: > The Exynos PMU node is an interrupt, clock and PMU (Power Management Unit) > controller, and these functionalities are supported by different drivers > that matches the same compatible strings. > > Since commit 989eafd0b609 ("clk: core: Avoid double initialization of > clocks") the OF core flags clock controllers registered with the > CLK_OF_DECLARE() macro as OF_POPULATED, so platform devices with the same > compatible string as the interrupt controller will not be registered. > > This prevents the PMU platform device to be registered so the Exynos PMU > driver is never probed. This breaks (among other things) Suspend-to-RAM. > > Fix this by clearing the OF_POPULATED flag in the clkout driver init > callback, to allow the Exynos PMU platform driver to be probed. The patch > is based on similar patch from Javier Martinez Canillas: b030485220ca > "ARM: EXYNOS: Clear OF_POPULATED flag from PMU node in IRQ init callback". > > Fixes: 989eafd0b609 ("clk: core: Avoid double initialization of clocks") > Signed-off-by: Marek Szyprowski > --- The patch looks good to me: Reviewed-by: Javier Martinez Canillas I've also tested it on an Exynos5800 Peach Pi, the PMU driver is probed and S2R works correctly: Tested-by: Javier Martinez Canillas Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America