All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Min Hu (Connor)" <humin29@huawei.com>
To: Stephen Hemminger <stephen@networkplumber.org>,
	"Zhang, Ke1X" <ke1x.zhang@intel.com>
Cc: "chas3@att.com" <chas3@att.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [PATCH] net/bonding: fix rss key configuration when the key length is 52
Date: Wed, 13 Apr 2022 17:03:07 +0800	[thread overview]
Message-ID: <6a16b3b3-9edd-5866-690c-804e9bcb5718@huawei.com> (raw)
In-Reply-To: <20220412081930.293e4384@hermes.local>

Hi, Stephen,

在 2022/4/12 23:19, Stephen Hemminger 写道:
> On Mon, 11 Apr 2022 03:06:46 +0000
> "Zhang, Ke1X" <ke1x.zhang@intel.com> wrote:
> 
>> This is a coding waring as below:
>>   
>>   _coding style issues_
>>   
>> WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
>> #64:
>> when creating a bonding device, if the slave device's rss key length
>>
>> WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
>> #65:
>>   is 52, then bonding device will be same as slave, in function
>>
>> total: 0 errors, 2 warnings, 0 checks, 19 lines checked
>>
>> the 'slave' is correct, for exsample, testpmd cmd:
>> add bonding slave 0 2
> 
> Just a heads up, for 22.11 I plan to replace/deprecate use of master/slave
> terminology in bonding driver.  The terms master/slave are legacy and most
> commercial products have switched to the terms from the 802 standard.
What are the terms ? Could you show them for us?
> .
> 

  reply	other threads:[~2022-04-13  9:03 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-07  9:36 [PATCH] net/bonding: fix rss key configuration when the key length is 52 Ke Zhang
2022-04-08  2:32 ` Min Hu (Connor)
2022-04-11  3:06   ` Zhang, Ke1X
2022-04-12 15:19     ` Stephen Hemminger
2022-04-13  9:03       ` Min Hu (Connor) [this message]
2022-04-13 16:12         ` Stephen Hemminger
2022-04-11  3:02 ` [PATCH v2 1/1] " Ke Zhang
2022-04-11  3:41   ` Min Hu (Connor)
2022-04-11  5:40   ` [PATCH v3 " Ke Zhang
2022-04-13  9:01     ` Min Hu (Connor)
2022-05-04 16:32       ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6a16b3b3-9edd-5866-690c-804e9bcb5718@huawei.com \
    --to=humin29@huawei.com \
    --cc=chas3@att.com \
    --cc=dev@dpdk.org \
    --cc=ke1x.zhang@intel.com \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.