On 01/17/2018 09:30 AM, Alberto Garcia wrote: > On Tue 16 Jan 2018 11:06:21 PM CET, Eric Blake wrote: > >>> typedef struct Qcow2ReopenState { >>> Qcow2Cache *l2_table_cache; >>> Qcow2Cache *refcount_block_cache; >>> + int l2_slice_size; >> >> Worth a comment? >> /* Number of entries in a slice of the L2 table */ > > Yeah, why not? I'll add it. Or see my comments in later patches, that perhaps this is better named l2_slice_entries. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org