All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Sandeen <sandeen@sandeen.net>
To: Christoph Hellwig <hch@infradead.org>, Eric Sandeen <sandeen@redhat.com>
Cc: linux-xfs <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH] xfs_growfs: allow mounted device node as argument
Date: Tue, 29 Oct 2019 08:24:50 -0500	[thread overview]
Message-ID: <6a30d8d1-8786-f7cd-f897-d4d6d6f517f5@sandeen.net> (raw)
In-Reply-To: <20191029071536.GA31501@infradead.org>



On 10/29/19 2:15 AM, Christoph Hellwig wrote:
> On Mon, Oct 28, 2019 at 10:23:51PM -0500, Eric Sandeen wrote:
>> I can clone tests/xfs/289 to do tests of similar permutations for
>> device names.
> 
> Can we just add the device name based tests to xfs/289?

Could do, I was hesitant to make a once-passing test start failing on older
userspace. (maybe we should formalize a policy for this sort of thing)

> The patch itself looks fine:
> 
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> 

Thanks

  reply	other threads:[~2019-10-29 13:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-29  3:23 [PATCH] xfs_growfs: allow mounted device node as argument Eric Sandeen
2019-10-29  7:15 ` Christoph Hellwig
2019-10-29 13:24   ` Eric Sandeen [this message]
2019-10-29 13:26     ` Christoph Hellwig
2019-10-29 13:34       ` Eric Sandeen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6a30d8d1-8786-f7cd-f897-d4d6d6f517f5@sandeen.net \
    --to=sandeen@sandeen.net \
    --cc=hch@infradead.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=sandeen@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.