All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: "Yu, DapengX" <dapengx.yu@intel.com>,
	"Yang, Qiming" <qiming.yang@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"Guo, Junfeng" <junfeng.guo@intel.com>,
	"Yan, Zhirun" <zhirun.yan@intel.com>,
	"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 2/2] net/ice: fix VXLAN flow director creation error
Date: Fri, 9 Jul 2021 03:00:13 +0000	[thread overview]
Message-ID: <6a34ec995dd94f8195fcd43be680edbb@intel.com> (raw)
In-Reply-To: <20210616012053.201105-2-dapengx.yu@intel.com>



> -----Original Message-----
> From: Yu, DapengX <dapengx.yu@intel.com>
> Sent: Wednesday, June 16, 2021 9:21 AM
> To: Yang, Qiming <qiming.yang@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>
> Cc: dev@dpdk.org; Guo, Junfeng <junfeng.guo@intel.com>; Yan, Zhirun
> <zhirun.yan@intel.com>; Yu, DapengX <dapengx.yu@intel.com>;
> stable@dpdk.org
> Subject: [PATCH 2/2] net/ice: fix VXLAN flow director creation error
> 
> From: Dapeng Yu <dapengx.yu@intel.com>
> 
> In original implementation, error returned when creating VXLAN flow director
> with SCTP or TCP as layer 4 protocol of inner segment.
> 
> There are several root causes for the error:
> 1. ice_fdir_input_set_hdrs() set ICE_FLOW_SEG_HDR_UDP into protocol
> header flag of inner segment of VXLAN FDIR rule, even if it shall be
> ICE_FLOW_SEG_HDR_TCP or ICE_FLOW_SEG_HDR_SCTP 2.
> ice_fdir_input_set_hdrs() set ICE_FLOW_SEG_HDR_VXLAN into protocol
> header flag of segments of VXLAN FDIR rule, it not necessary, and can be set
> automatically by ice_flow_set_fld() later 3. flow type:
> ICE_FLTR_PTYPE_NONF_IPV4_UDP_VXLAN hides the flow type of inner
> segment of VXLAN FDIR rule, then further causes function:
> ice_fdir_get_gen_prgm_pkt() cannot write correct protocol id into inner
> segment of training packet.
> 
> This patch fixes those defects described above.
> 
> Fixes: 855d23a07b36 ("net/ice: support VXLAN VNI field in flow director")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Dapeng Yu <dapengx.yu@intel.com>

Acked-by: Qi Zhang <qi.z.zhang@intel.com>

Applied to dpdk-next-net-intel.

Thanks
Qi

  reply	other threads:[~2021-07-09  3:00 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-16  1:20 [dpdk-dev] [PATCH 1/2] net/ice/base: fix VXLAN flow director creation error dapengx.yu
2021-06-16  1:20 ` [dpdk-dev] [PATCH 2/2] net/ice: " dapengx.yu
2021-07-09  3:00   ` Zhang, Qi Z [this message]
2021-07-09  2:59 ` [dpdk-dev] [PATCH 1/2] net/ice/base: " Zhang, Qi Z

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6a34ec995dd94f8195fcd43be680edbb@intel.com \
    --to=qi.z.zhang@intel.com \
    --cc=dapengx.yu@intel.com \
    --cc=dev@dpdk.org \
    --cc=junfeng.guo@intel.com \
    --cc=qiming.yang@intel.com \
    --cc=stable@dpdk.org \
    --cc=zhirun.yan@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.