All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexey Kodanev <alexey.kodanev@oracle.com>
To: ltp@lists.linux.it
Subject: [LTP] [RFC PATCH 2/2] lib/test_net.sh: Check for ip command
Date: Thu, 7 Dec 2017 14:52:52 +0300	[thread overview]
Message-ID: <6a3ee066-2d3b-3901-797e-c5b2b5e14fb3@oracle.com> (raw)
In-Reply-To: <20171206144214.27317-2-pvorel@suse.cz>

On 12/06/2017 05:42 PM, Petr Vorel wrote:
> + remove this check from tests which uses test_net.sh.

Not all library functions require 'ip' so why do we need these
rules to apply globally or am I missing something?

>
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> ---
> I guess most of the time we need root in test_net.sh, but there might be
> someone setting netns with LTP_NETNS and then running tests without root.  Do
> we want to care or we just force tst_require_root in test_net.sh ?

I think we could add it in init_ltp_netspace or/and to tst_restore_ipaddr(),
i.e. checks forip command and root.

Thanks,
Alexey


  reply	other threads:[~2017-12-07 11:52 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-06 14:42 [LTP] [RFC PATCH 1/2] network/ipsec: Add trap to INT and require root Petr Vorel
2017-12-06 14:42 ` [LTP] [RFC PATCH 2/2] lib/test_net.sh: Check for ip command Petr Vorel
2017-12-07 11:52   ` Alexey Kodanev [this message]
2017-12-07 11:25 ` [LTP] [RFC PATCH 1/2] network/ipsec: Add trap to INT and require root Alexey Kodanev
2017-12-07 12:18   ` Petr Vorel
2017-12-11 12:23     ` Cyril Hrubis
2017-12-11 14:36       ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6a3ee066-2d3b-3901-797e-c5b2b5e14fb3@oracle.com \
    --to=alexey.kodanev@oracle.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.