From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DC45C432C0 for ; Wed, 27 Nov 2019 11:16:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7C2132053B for ; Wed, 27 Nov 2019 11:16:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726514AbfK0LQ6 (ORCPT ); Wed, 27 Nov 2019 06:16:58 -0500 Received: from szxga07-in.huawei.com ([45.249.212.35]:48838 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726219AbfK0LQ6 (ORCPT ); Wed, 27 Nov 2019 06:16:58 -0500 Received: from DGGEMS406-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 03EDC2BFAB609FA68735; Wed, 27 Nov 2019 19:16:55 +0800 (CST) Received: from [127.0.0.1] (10.142.68.147) by DGGEMS406-HUB.china.huawei.com (10.3.19.206) with Microsoft SMTP Server id 14.3.439.0; Wed, 27 Nov 2019 19:16:48 +0800 Subject: Re: [RESEND PATCH v21 3/6] ACPI: Add APEI GHES table generation support To: Igor Mammedov , "Michael S. Tsirkin" CC: , , , , , , , , Xiang Zheng , , , , , , , References: <20191111014048.21296-1-zhengxiang9@huawei.com> <20191111014048.21296-4-zhengxiang9@huawei.com> <20191115103801.547fc84d@redhat.com> <87758ec2-c242-71c3-51f8-a5d348f8e7fd@huawei.com> <20191118082036-mutt-send-email-mst@kernel.org> <20191125104859.70047602@redhat.com> From: gengdongjiu Message-ID: <6a4bcef4-41f2-af5d-3cce-75718da23719@huawei.com> Date: Wed, 27 Nov 2019 19:16:46 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20191125104859.70047602@redhat.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.142.68.147] X-CFilter-Loop: Reflected Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 2019/11/25 17:48, Igor Mammedov wrote: >>> ...... >>> bios_linker_loader_add_pointer(linker, ACPI_BUILD_TABLE_FILE, >>> ACPI_GHES_ERROR_STATUS_ADDRESS_OFFSET(hest_start, source_id), >>> sizeof(uint64_t), ACPI_GHES_ERRORS_FW_CFG_FILE, >>> source_id * sizeof(uint64_t)); >>> ....... >>> } >>> >>> My previous series patch support 2 error sources, but now only enable 'SEA' type Error Source >> I'd try to merge this, worry about extending things later. >> This is at v21 and the simpler you can keep things, >> the faster it'll go in. > I don't think the series is ready for merging yet. > It has a number of issues (not stylistic ones) that need to be fixed first. > > As for extending, I think I've suggested to simplify series > to account for single error source only in some places so it > would be easier on author and reviewers and worry about extending > it later. sure, thanks for the review, we are preparing another series which will fix the issues that you mentioned. > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B87A2C432C3 for ; Wed, 27 Nov 2019 11:18:25 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9008D2053B for ; Wed, 27 Nov 2019 11:18:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9008D2053B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:37092 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iZvKy-0006Pc-NI for qemu-devel@archiver.kernel.org; Wed, 27 Nov 2019 06:18:24 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:40873) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iZvJj-0005pB-Ov for qemu-devel@nongnu.org; Wed, 27 Nov 2019 06:17:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iZvJi-0004T5-OD for qemu-devel@nongnu.org; Wed, 27 Nov 2019 06:17:07 -0500 Received: from szxga07-in.huawei.com ([45.249.212.35]:35412 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iZvJg-0004PG-8b; Wed, 27 Nov 2019 06:17:04 -0500 Received: from DGGEMS406-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 03EDC2BFAB609FA68735; Wed, 27 Nov 2019 19:16:55 +0800 (CST) Received: from [127.0.0.1] (10.142.68.147) by DGGEMS406-HUB.china.huawei.com (10.3.19.206) with Microsoft SMTP Server id 14.3.439.0; Wed, 27 Nov 2019 19:16:48 +0800 Subject: Re: [RESEND PATCH v21 3/6] ACPI: Add APEI GHES table generation support To: Igor Mammedov , "Michael S. Tsirkin" References: <20191111014048.21296-1-zhengxiang9@huawei.com> <20191111014048.21296-4-zhengxiang9@huawei.com> <20191115103801.547fc84d@redhat.com> <87758ec2-c242-71c3-51f8-a5d348f8e7fd@huawei.com> <20191118082036-mutt-send-email-mst@kernel.org> <20191125104859.70047602@redhat.com> From: gengdongjiu Message-ID: <6a4bcef4-41f2-af5d-3cce-75718da23719@huawei.com> Date: Wed, 27 Nov 2019 19:16:46 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20191125104859.70047602@redhat.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.142.68.147] X-CFilter-Loop: Reflected X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 45.249.212.35 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, ehabkost@redhat.com, kvm@vger.kernel.org, pbonzini@redhat.com, mtosatti@redhat.com, qemu-devel@nongnu.org, linuxarm@huawei.com, shannon.zhaosl@gmail.com, Xiang Zheng , qemu-arm@nongnu.org, james.morse@arm.com, xuwei5@huawei.com, jonathan.cameron@huawei.com, wanghaibin.wang@huawei.com, lersek@redhat.com, rth@twiddle.net Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 2019/11/25 17:48, Igor Mammedov wrote: >>> ...... >>> bios_linker_loader_add_pointer(linker, ACPI_BUILD_TABLE_FILE, >>> ACPI_GHES_ERROR_STATUS_ADDRESS_OFFSET(hest_start, source_id), >>> sizeof(uint64_t), ACPI_GHES_ERRORS_FW_CFG_FILE, >>> source_id * sizeof(uint64_t)); >>> ....... >>> } >>> >>> My previous series patch support 2 error sources, but now only enable 'SEA' type Error Source >> I'd try to merge this, worry about extending things later. >> This is at v21 and the simpler you can keep things, >> the faster it'll go in. > I don't think the series is ready for merging yet. > It has a number of issues (not stylistic ones) that need to be fixed first. > > As for extending, I think I've suggested to simplify series > to account for single error source only in some places so it > would be easier on author and reviewers and worry about extending > it later. sure, thanks for the review, we are preparing another series which will fix the issues that you mentioned. >