From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sinan Kaya Subject: Re: [PATCH 3/4] iommu/arm-smmu-v3: Add support for PCI ATS Date: Thu, 21 Mar 2019 11:52:07 -0400 Message-ID: <6a4fb991-b8cd-d64d-25bd-dbbefcf69fa5@kernel.org> References: <20190320173634.21895-1-jean-philippe.brucker@arm.com> <20190320173634.21895-4-jean-philippe.brucker@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190320173634.21895-4-jean-philippe.brucker-5wv7dgnIgG8@public.gmane.org> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Jean-Philippe Brucker , will.deacon-5wv7dgnIgG8@public.gmane.org Cc: zhongmiao-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org, rjw-LthD3rsA81gm4RdzfppkhA@public.gmane.org, linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, sudeep.holla-5wv7dgnIgG8@public.gmane.org, robin.murphy-5wv7dgnIgG8@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, lenb-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org List-Id: linux-acpi@vger.kernel.org On 3/20/2019 1:36 PM, Jean-Philippe Brucker wrote: > pos = pci_find_ext_capability(pdev, PCI_EXT_CAP_ID_ATS); > + if (!pos) > + return -ENOSYS; > + You don't need this. pci_enable_ats() validates this via. if (!dev->ats_cap) return -EINVAL; From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AED0FC43381 for ; Thu, 21 Mar 2019 15:52:22 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7C65820828 for ; Thu, 21 Mar 2019 15:52:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="bFNrC9te"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eBQBRmjC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7C65820828 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:References: To:Subject:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ZwM9KXxlNFz2CzEFungs9Df2fafcYd2znGVXu0xprOQ=; b=bFNrC9teuMLGuaw8Eg//Dv2VU aWz4MoKSrr5ypwta5PQJpgsM5fu/qEq5vxIp1h6n3nsoe7u8Z2xO6o/4DIB7qBYyEZneIZ87nGGXg /6Mi9teyBXJVXzl5jxKg3WnHa+VDr53+xRIvuD9dss/KBSRDP+th9rnYN/ikq8F5mcHDmA7kd/SgD 6sTsxwqeRLR6fFd9bI6GR/CPvYQgV61lYqBt9IjHzxbWUEjUoAABRB3AqgoafHVUqd0YsmtHo6TWz RErBluIg4p5a4wZD6pu8MGZyc0zBl4pve9G/pZ9+bUYas1AMHYM4PEAvQ+v9yezRijx3zwLef9mSQ CPHOd1sgg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h6zzL-0003zy-Oo; Thu, 21 Mar 2019 15:52:15 +0000 Received: from mail-qt1-x842.google.com ([2607:f8b0:4864:20::842]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h6zzH-0003zQ-Kw for linux-arm-kernel@lists.infradead.org; Thu, 21 Mar 2019 15:52:12 +0000 Received: by mail-qt1-x842.google.com with SMTP id w30so7131839qta.8 for ; Thu, 21 Mar 2019 08:52:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:subject:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=5tQLfSoxapHaq4RpQWPoA/AXbOq2B4/a+DSgdIKDUcQ=; b=eBQBRmjCA2cZv+eJQQhc51W6jR/r15BlReokkuVdvpe5RArq42B5XGLs5Kt9AaImu5 MZxf41l0XwU1KCAfOr8fyCpPiwcW9PnhLHxvZSpak2jjR+elMu4tlu1/zQM0JIVe+kPW PehEjoLRtOXYp5H/X4LwSPdk5D2Cln0IqgRqLKmDIMCGCLg6uzedvpNAl8qMhMqAg5vR jPjRq7rhTDtHeHLipaiMqK6TwQJVogbDJd+HYaUJRHOTrZgMKl/WxJK3v1WEh2jib0FS u+FbogNC/+vITTb3McgUAuI4Y7cHLXTFTJdtG/OHmwobdYE02bWY4LvABx9Zc4zAtbYW 2IJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:subject:to:cc:references:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=5tQLfSoxapHaq4RpQWPoA/AXbOq2B4/a+DSgdIKDUcQ=; b=ZvOqMKgtZQ+kR27UMX+a7rvQCiitw0d+VoYp5v+quXs/BxsJTDesIdaZ9JEsgL+A2I adLhNmvd9ugNkuoFPo+/0h2KfYv4wZK9h3LZjTaClvGWBK3gDxUkrFS2JLSkNiiMT8Dx 0kca6arKAQ4aH2n5PgDdGHhHjlrGBuUa98XkU+CnvXwcF9slF2O5r/uNwV4Pf8B+XaWI gCnMHJuLXId9yM8avOjILr32rHhujGVAGPdD0RT4THhlIoIdR0PRhaCSVATngvyKBybW 3BbWXOq2WnUcIaeDVBLvAUrDweoFmoWKxlXbzYmCOAJvW/Lb9SrMNG+s/CtCOUCafuLw Yzng== X-Gm-Message-State: APjAAAX7iYxG0LO0l23GKu90F+7QGRKiiKBElvvQ2SdV1sMzEXvsz2lm Ki5b0kC9ur7CH/qi5uKdFYU= X-Google-Smtp-Source: APXvYqzHMJnA9KFvBcMVXPsxAYjVgJgSzaBaSfVA/JUQIUVUoLv/1gZJM5d24o3cAclVMAh45bT9vw== X-Received: by 2002:ac8:1481:: with SMTP id l1mr3681247qtj.226.1553183529021; Thu, 21 Mar 2019 08:52:09 -0700 (PDT) Received: from [10.84.150.6] ([167.220.148.6]) by smtp.gmail.com with ESMTPSA id o41sm3461762qtc.6.2019.03.21.08.52.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 21 Mar 2019 08:52:08 -0700 (PDT) From: Sinan Kaya X-Google-Original-From: Sinan Kaya Subject: Re: [PATCH 3/4] iommu/arm-smmu-v3: Add support for PCI ATS To: Jean-Philippe Brucker , will.deacon@arm.com References: <20190320173634.21895-1-jean-philippe.brucker@arm.com> <20190320173634.21895-4-jean-philippe.brucker@arm.com> Message-ID: <6a4fb991-b8cd-d64d-25bd-dbbefcf69fa5@kernel.org> Date: Thu, 21 Mar 2019 11:52:07 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.3 MIME-Version: 1.0 In-Reply-To: <20190320173634.21895-4-jean-philippe.brucker@arm.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190321_085211_713660_B03004A1 X-CRM114-Status: GOOD ( 10.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: lorenzo.pieralisi@arm.com, zhongmiao@hisilicon.com, joro@8bytes.org, rjw@rjwysocki.net, linux-acpi@vger.kernel.org, iommu@lists.linux-foundation.org, hanjun.guo@linaro.org, sudeep.holla@arm.com, robin.murphy@arm.com, linux-arm-kernel@lists.infradead.org, lenb@kernel.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 3/20/2019 1:36 PM, Jean-Philippe Brucker wrote: > pos = pci_find_ext_capability(pdev, PCI_EXT_CAP_ID_ATS); > + if (!pos) > + return -ENOSYS; > + You don't need this. pci_enable_ats() validates this via. if (!dev->ats_cap) return -EINVAL; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel