From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C596C4708F for ; Thu, 3 Jun 2021 02:37:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E553C613EB for ; Thu, 3 Jun 2021 02:37:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229623AbhFCCjC (ORCPT ); Wed, 2 Jun 2021 22:39:02 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:42857 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229541AbhFCCjB (ORCPT ); Wed, 2 Jun 2021 22:39:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1622687837; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uxm0/+m5dcFG2sDWbRYCYBLYAMI7JPbdvwfiFb7Glz8=; b=jPUVQjCqHaVQqDqa33ItVh8ZmLjwc97mhnlftCiGf26RFpvXYkndxB+x1YPP2w3RiAAnLy Yi0HcLNfAlmc7So5YI22dqbSgA0Aim8+bqqkZL7OiTJXow2F3bjH2I+fllvIWtjwjbz8S2 Hj6o9FBazMCA0+4UXT8yHRB4Vnc/hsU= Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-417-HQtqnpoAOJCjKo3eLaEnNg-1; Wed, 02 Jun 2021 22:37:16 -0400 X-MC-Unique: HQtqnpoAOJCjKo3eLaEnNg-1 Received: by mail-pj1-f72.google.com with SMTP id j1-20020a17090a7381b02901605417540bso2401897pjg.3 for ; Wed, 02 Jun 2021 19:37:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=uxm0/+m5dcFG2sDWbRYCYBLYAMI7JPbdvwfiFb7Glz8=; b=h7+2HNdAk/GxQ2RD6cx2Qr/MFgsutVQraLuNkbLZxy++OeDtoUywSeg5+efkngbKlF 254BxbHvKauzumWymRLbe3DR59484+LZVRb3FGVf/p+DhOvE7Yhn1KkqrhgNrkbAU2BM Uy0dCSaQdCSJuABhMr6xQ637uT2g5JmYtOWtdpgrCsDkQwkiHodWyQk3o0TCudXeP/Gx r6Jb8n6LG3mkG66YT5GeFQxLkTdwHxrQkl2iYjpMsHcra0f4wWMdSczrOgRCjPa37Nk3 eAH/xlbkdOac0TqXz6vY4GPetuipf0fGnqVFEkVs8lteTMIj3mabK7Ny2j27uMjKpVaW PY0A== X-Gm-Message-State: AOAM530c1OiuSNfefT9670y7j74Gh1NDz4bL12FTV0/I5etbqbBT4tnl 5HJAWK7+WZAWyTIooSqj9FHHnXib+CAxmvMXJgCN95hnfzWrr7ay/CXkho3QJ7evCZaobUhSWyg QueJohtJhxAmIn1qZhDM3zJz2zDhY1BIuQ+oLuXR3vpnCWiaER5iOEI7WWCI5pRQv4RQEr0zu4O Ak X-Received: by 2002:a63:7a01:: with SMTP id v1mr3478951pgc.307.1622687834853; Wed, 02 Jun 2021 19:37:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJztGLN1yD3vajwb+JLkpQMmH6Ptgg5CL3UiebwVquPa3KIGm5002XUJvK1+Nc1pzYyR5Kivcw== X-Received: by 2002:a63:7a01:: with SMTP id v1mr3478922pgc.307.1622687834579; Wed, 02 Jun 2021 19:37:14 -0700 (PDT) Received: from wangxiaodeMacBook-Air.local ([209.132.188.80]) by smtp.gmail.com with ESMTPSA id x6sm767172pfd.173.2021.06.02.19.37.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Jun 2021 19:37:14 -0700 (PDT) Subject: Re: [PATCH v1 2/8] virtio: Add boundary checks to virtio ring To: Andi Kleen , mst@redhat.com Cc: virtualization@lists.linux-foundation.org, hch@lst.de, m.szyprowski@samsung.com, robin.murphy@arm.com, iommu@lists.linux-foundation.org, x86@kernel.org, sathyanarayanan.kuppuswamy@linux.intel.com, jpoimboe@redhat.com, linux-kernel@vger.kernel.org References: <20210603004133.4079390-1-ak@linux.intel.com> <20210603004133.4079390-3-ak@linux.intel.com> <4be00b3a-a15f-7fee-317b-ddabed3c1347@redhat.com> From: Jason Wang Message-ID: <6a5cae8f-0a29-8401-34b9-d9c977d11513@redhat.com> Date: Thu, 3 Jun 2021 10:36:47 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.10.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=gbk; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ÔÚ 2021/6/3 ÉÏÎç10:18, Andi Kleen дµÀ: > >> It looks to me all the evils came from the fact that we depends on >> the descriptor ring. >> >> So the checks in this patch could is unnecessary if we don't even >> read from the descriptor ring which could be manipulated by the device. >> >> This is what my series tries to achieve: >> >> https://www.spinics.net/lists/kvm/msg241825.html > > I would argue that you should boundary check in any case. It was > always a bug to not have boundary checks in such a data structure with > multiple users, trust or not. > > But yes your patch series is interesting and definitely makes sense > for TDX too. > > Best would be to have both I guess, and always check the boundaries > everywhere. I agree but some of the checks are unnecessary in we do this series on top of my series. > > So what's the merge status of your series? If I understand correctly from Michael, I will send a formal series and he will try to merge it for the 5.14. Thanks > > -Andi > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E8FDC47083 for ; Thu, 3 Jun 2021 02:37:23 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2D438613F0 for ; Thu, 3 Jun 2021 02:37:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2D438613F0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id EFBD54056E; Thu, 3 Jun 2021 02:37:22 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id a4mzUG7iylA2; Thu, 3 Jun 2021 02:37:22 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp4.osuosl.org (Postfix) with ESMTP id 7168A4056C; Thu, 3 Jun 2021 02:37:21 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 33ED1C000E; Thu, 3 Jun 2021 02:37:21 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137]) by lists.linuxfoundation.org (Postfix) with ESMTP id 98B15C0001 for ; Thu, 3 Jun 2021 02:37:19 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 8C00F4056E for ; Thu, 3 Jun 2021 02:37:19 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id LFc-cRn3gPrp for ; Thu, 3 Jun 2021 02:37:18 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by smtp4.osuosl.org (Postfix) with ESMTPS id 55F024056C for ; Thu, 3 Jun 2021 02:37:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1622687837; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uxm0/+m5dcFG2sDWbRYCYBLYAMI7JPbdvwfiFb7Glz8=; b=jPUVQjCqHaVQqDqa33ItVh8ZmLjwc97mhnlftCiGf26RFpvXYkndxB+x1YPP2w3RiAAnLy Yi0HcLNfAlmc7So5YI22dqbSgA0Aim8+bqqkZL7OiTJXow2F3bjH2I+fllvIWtjwjbz8S2 Hj6o9FBazMCA0+4UXT8yHRB4Vnc/hsU= Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-580-RwfG4noUO4aFHCwIsoobjw-1; Wed, 02 Jun 2021 22:37:15 -0400 X-MC-Unique: RwfG4noUO4aFHCwIsoobjw-1 Received: by mail-pg1-f197.google.com with SMTP id 15-20020a630c4f0000b029021a6da9af28so3017192pgm.22 for ; Wed, 02 Jun 2021 19:37:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=uxm0/+m5dcFG2sDWbRYCYBLYAMI7JPbdvwfiFb7Glz8=; b=ekMPYnILXVrf379zkN9iKtVXEk7hjSLDf0uVfO6cLBVGqHDadnwZhgmFZn6FfB7BdT oevgih9xldL0U9hFweK4jOc6inuGEsmo7WPmu9EkUA30nZ86RupPNacd7IkykGK3XXd/ sNdhC7COO/FhuDlCkXM8/+D07ojsAL9I9wuWP+78NTkH4qsG6TmCGHSUiQmBw23hC9mK tJERiktM+xGzbg03RXrnWgKbZRqAdKtNVHF1jWGUIGpUsmfuMdJIYFUfFBkqiw2VBidF u1OI4sRME3BXMV0pq0ql4GlSdiDEqsBijk8YxAt01Pea9kLghXly6uX/76VSa42q5gTu k8KQ== X-Gm-Message-State: AOAM533etBNvPuNrrnC8AlYLHmKSlip4xfIEBETPdL28EeimQA+OMfii iHQt1ZWsBlvJ7FfXWJ4hblSib5+w55mMg7T1XrR4usWr95o+X7BBtqltvte//1fGprZcMAkhm5v SwedDkVA1L/v0mMN0sCy9E6m3zwf/Jw== X-Received: by 2002:a63:7a01:: with SMTP id v1mr3478939pgc.307.1622687834778; Wed, 02 Jun 2021 19:37:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJztGLN1yD3vajwb+JLkpQMmH6Ptgg5CL3UiebwVquPa3KIGm5002XUJvK1+Nc1pzYyR5Kivcw== X-Received: by 2002:a63:7a01:: with SMTP id v1mr3478922pgc.307.1622687834579; Wed, 02 Jun 2021 19:37:14 -0700 (PDT) Received: from wangxiaodeMacBook-Air.local ([209.132.188.80]) by smtp.gmail.com with ESMTPSA id x6sm767172pfd.173.2021.06.02.19.37.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Jun 2021 19:37:14 -0700 (PDT) Subject: Re: [PATCH v1 2/8] virtio: Add boundary checks to virtio ring To: Andi Kleen , mst@redhat.com References: <20210603004133.4079390-1-ak@linux.intel.com> <20210603004133.4079390-3-ak@linux.intel.com> <4be00b3a-a15f-7fee-317b-ddabed3c1347@redhat.com> From: Jason Wang Message-ID: <6a5cae8f-0a29-8401-34b9-d9c977d11513@redhat.com> Date: Thu, 3 Jun 2021 10:36:47 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.10.2 MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jasowang@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Cc: x86@kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, iommu@lists.linux-foundation.org, jpoimboe@redhat.com, robin.murphy@arm.com, hch@lst.de X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="gbk"; Format="flowed" Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" CtTaIDIwMjEvNi8zIMnPzucxMDoxOCwgQW5kaSBLbGVlbiDQtLXAOgo+Cj4+IEl0IGxvb2tzIHRv IG1lIGFsbCB0aGUgZXZpbHMgY2FtZSBmcm9tIHRoZSBmYWN0IHRoYXQgd2UgZGVwZW5kcyBvbiAK Pj4gdGhlIGRlc2NyaXB0b3IgcmluZy4KPj4KPj4gU28gdGhlIGNoZWNrcyBpbiB0aGlzIHBhdGNo IGNvdWxkIGlzIHVubmVjZXNzYXJ5IGlmIHdlIGRvbid0IGV2ZW4gCj4+IHJlYWQgZnJvbSB0aGUg ZGVzY3JpcHRvciByaW5nIHdoaWNoIGNvdWxkIGJlIG1hbmlwdWxhdGVkIGJ5IHRoZSBkZXZpY2Uu Cj4+Cj4+IFRoaXMgaXMgd2hhdCBteSBzZXJpZXMgdHJpZXMgdG8gYWNoaWV2ZToKPj4KPj4gaHR0 cHM6Ly93d3cuc3Bpbmljcy5uZXQvbGlzdHMva3ZtL21zZzI0MTgyNS5odG1sCj4KPiBJIHdvdWxk IGFyZ3VlIHRoYXQgeW91IHNob3VsZCBib3VuZGFyeSBjaGVjayBpbiBhbnkgY2FzZS4gSXQgd2Fz IAo+IGFsd2F5cyBhIGJ1ZyB0byBub3QgaGF2ZSBib3VuZGFyeSBjaGVja3MgaW4gc3VjaCBhIGRh dGEgc3RydWN0dXJlIHdpdGggCj4gbXVsdGlwbGUgdXNlcnMsIHRydXN0IG9yIG5vdC4KPgo+IEJ1 dCB5ZXMgeW91ciBwYXRjaCBzZXJpZXMgaXMgaW50ZXJlc3RpbmcgYW5kIGRlZmluaXRlbHkgbWFr ZXMgc2Vuc2UgCj4gZm9yIFREWCB0b28uCj4KPiBCZXN0IHdvdWxkIGJlIHRvIGhhdmUgYm90aCBJ IGd1ZXNzLCBhbmQgYWx3YXlzIGNoZWNrIHRoZSBib3VuZGFyaWVzIAo+IGV2ZXJ5d2hlcmUuCgoK SSBhZ3JlZSBidXQgc29tZSBvZiB0aGUgY2hlY2tzIGFyZSB1bm5lY2Vzc2FyeSBpbiB3ZSBkbyB0 aGlzIHNlcmllcyBvbiAKdG9wIG9mIG15IHNlcmllcy4KCgo+Cj4gU28gd2hhdCdzIHRoZSBtZXJn ZSBzdGF0dXMgb2YgeW91ciBzZXJpZXM/CgoKSWYgSSB1bmRlcnN0YW5kIGNvcnJlY3RseSBmcm9t IE1pY2hhZWwsIEkgd2lsbCBzZW5kIGEgZm9ybWFsIHNlcmllcyBhbmQgCmhlIHdpbGwgdHJ5IHRv IG1lcmdlIGl0IGZvciB0aGUgNS4xNC4KClRoYW5rcwoKCj4KPiAtQW5kaQo+Cj4KCl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmlvbW11IG1haWxpbmcgbGlz dAppb21tdUBsaXN0cy5saW51eC1mb3VuZGF0aW9uLm9yZwpodHRwczovL2xpc3RzLmxpbnV4Zm91 bmRhdGlvbi5vcmcvbWFpbG1hbi9saXN0aW5mby9pb21tdQ== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95664C4708F for ; Thu, 3 Jun 2021 02:37:25 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 534F961027 for ; Thu, 3 Jun 2021 02:37:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 534F961027 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=virtualization-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 2C52440578; Thu, 3 Jun 2021 02:37:25 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id iQRi14OOdfSN; Thu, 3 Jun 2021 02:37:24 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp4.osuosl.org (Postfix) with ESMTP id 928064056C; Thu, 3 Jun 2021 02:37:23 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 7B98FC000E; Thu, 3 Jun 2021 02:37:23 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists.linuxfoundation.org (Postfix) with ESMTP id DF609C0024 for ; Thu, 3 Jun 2021 02:37:21 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id C058960B0E for ; Thu, 3 Jun 2021 02:37:21 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp3.osuosl.org (amavisd-new); dkim=pass (1024-bit key) header.d=redhat.com Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 41NXp-boD4fJ for ; Thu, 3 Jun 2021 02:37:20 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by smtp3.osuosl.org (Postfix) with ESMTPS id C3162608C4 for ; Thu, 3 Jun 2021 02:37:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1622687839; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uxm0/+m5dcFG2sDWbRYCYBLYAMI7JPbdvwfiFb7Glz8=; b=Ryi7BfcrFKT02o0iV/KGcY5R8UfxfhFaif7uP258QzS5GaCTtUBfIlKO3HULavcpYlY3jB M3yunDxAwrzCftahrGp/7amwGZpTLOtuwh+bFFKc23C8hgDyWOZ1gdZaqe/2HzgsDWM+ef ctFStkiZD/wmzutbfd7h2g4D0onYuGg= Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-453-6-EkLii9PuKMz0kgmuDUkQ-1; Wed, 02 Jun 2021 22:37:15 -0400 X-MC-Unique: 6-EkLii9PuKMz0kgmuDUkQ-1 Received: by mail-pl1-f198.google.com with SMTP id 2-20020a1709020202b02900eecb50c2deso1987470plc.0 for ; Wed, 02 Jun 2021 19:37:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=uxm0/+m5dcFG2sDWbRYCYBLYAMI7JPbdvwfiFb7Glz8=; b=l/+uc1OXpNkHLrf4d697eIub3oKEZAPcsBygU3mbKIKvUPfwc2gScJiym3tU7n3mnl 8F9dDBxCOoFq+Hc9YCsHanrBeV7HBpdEyEoKWFyDL8HffzjQbdF5nJ+z5cLy1Zj4f98f Ntpe/qGUA6WayNJ1ylm9vu6iWFdgIRJLKNF3T2jLDxbVZiA83/6hsvYEataTAaUa5X7E BQZXeO/L9AqwhI9SllfxbS4gSKvlTlfhiH9R4SyvOy7Tll7BHNceW3VIhOOqi7VyQDP1 67ZS862r1R/XimP0UnHVLH8OYDIKpWFTgQUKOFeUKrmXPcXuiRVdLfYe5OdCCTUYzshN 9VTA== X-Gm-Message-State: AOAM532J91wY8l9lR0r6L/CsadsXYS1DcsMl3BAX103unsON8PzkuqSk m4d3K7SrSR8ikinvoCNfZqIIKn6tFL1nb2rTwjxLTGJPH53JPpokESebPg1BCWISWahzjetiK9N n3r6T6F/2Ic2+L144kZNRDWm6O5uli0kRt3m/QwNjXg== X-Received: by 2002:a63:7a01:: with SMTP id v1mr3478938pgc.307.1622687834778; Wed, 02 Jun 2021 19:37:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJztGLN1yD3vajwb+JLkpQMmH6Ptgg5CL3UiebwVquPa3KIGm5002XUJvK1+Nc1pzYyR5Kivcw== X-Received: by 2002:a63:7a01:: with SMTP id v1mr3478922pgc.307.1622687834579; Wed, 02 Jun 2021 19:37:14 -0700 (PDT) Received: from wangxiaodeMacBook-Air.local ([209.132.188.80]) by smtp.gmail.com with ESMTPSA id x6sm767172pfd.173.2021.06.02.19.37.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Jun 2021 19:37:14 -0700 (PDT) Subject: Re: [PATCH v1 2/8] virtio: Add boundary checks to virtio ring To: Andi Kleen , mst@redhat.com References: <20210603004133.4079390-1-ak@linux.intel.com> <20210603004133.4079390-3-ak@linux.intel.com> <4be00b3a-a15f-7fee-317b-ddabed3c1347@redhat.com> From: Jason Wang Message-ID: <6a5cae8f-0a29-8401-34b9-d9c977d11513@redhat.com> Date: Thu, 3 Jun 2021 10:36:47 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.10.2 MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jasowang@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Cc: sathyanarayanan.kuppuswamy@linux.intel.com, x86@kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, iommu@lists.linux-foundation.org, jpoimboe@redhat.com, robin.murphy@arm.com, hch@lst.de, m.szyprowski@samsung.com X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="gbk"; Format="flowed" Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" CtTaIDIwMjEvNi8zIMnPzucxMDoxOCwgQW5kaSBLbGVlbiDQtLXAOgo+Cj4+IEl0IGxvb2tzIHRv IG1lIGFsbCB0aGUgZXZpbHMgY2FtZSBmcm9tIHRoZSBmYWN0IHRoYXQgd2UgZGVwZW5kcyBvbiAK Pj4gdGhlIGRlc2NyaXB0b3IgcmluZy4KPj4KPj4gU28gdGhlIGNoZWNrcyBpbiB0aGlzIHBhdGNo IGNvdWxkIGlzIHVubmVjZXNzYXJ5IGlmIHdlIGRvbid0IGV2ZW4gCj4+IHJlYWQgZnJvbSB0aGUg ZGVzY3JpcHRvciByaW5nIHdoaWNoIGNvdWxkIGJlIG1hbmlwdWxhdGVkIGJ5IHRoZSBkZXZpY2Uu Cj4+Cj4+IFRoaXMgaXMgd2hhdCBteSBzZXJpZXMgdHJpZXMgdG8gYWNoaWV2ZToKPj4KPj4gaHR0 cHM6Ly93d3cuc3Bpbmljcy5uZXQvbGlzdHMva3ZtL21zZzI0MTgyNS5odG1sCj4KPiBJIHdvdWxk IGFyZ3VlIHRoYXQgeW91IHNob3VsZCBib3VuZGFyeSBjaGVjayBpbiBhbnkgY2FzZS4gSXQgd2Fz IAo+IGFsd2F5cyBhIGJ1ZyB0byBub3QgaGF2ZSBib3VuZGFyeSBjaGVja3MgaW4gc3VjaCBhIGRh dGEgc3RydWN0dXJlIHdpdGggCj4gbXVsdGlwbGUgdXNlcnMsIHRydXN0IG9yIG5vdC4KPgo+IEJ1 dCB5ZXMgeW91ciBwYXRjaCBzZXJpZXMgaXMgaW50ZXJlc3RpbmcgYW5kIGRlZmluaXRlbHkgbWFr ZXMgc2Vuc2UgCj4gZm9yIFREWCB0b28uCj4KPiBCZXN0IHdvdWxkIGJlIHRvIGhhdmUgYm90aCBJ IGd1ZXNzLCBhbmQgYWx3YXlzIGNoZWNrIHRoZSBib3VuZGFyaWVzIAo+IGV2ZXJ5d2hlcmUuCgoK SSBhZ3JlZSBidXQgc29tZSBvZiB0aGUgY2hlY2tzIGFyZSB1bm5lY2Vzc2FyeSBpbiB3ZSBkbyB0 aGlzIHNlcmllcyBvbiAKdG9wIG9mIG15IHNlcmllcy4KCgo+Cj4gU28gd2hhdCdzIHRoZSBtZXJn ZSBzdGF0dXMgb2YgeW91ciBzZXJpZXM/CgoKSWYgSSB1bmRlcnN0YW5kIGNvcnJlY3RseSBmcm9t IE1pY2hhZWwsIEkgd2lsbCBzZW5kIGEgZm9ybWFsIHNlcmllcyBhbmQgCmhlIHdpbGwgdHJ5IHRv IG1lcmdlIGl0IGZvciB0aGUgNS4xNC4KClRoYW5rcwoKCj4KPiAtQW5kaQo+Cj4KCl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fClZpcnR1YWxpemF0aW9uIG1h aWxpbmcgbGlzdApWaXJ0dWFsaXphdGlvbkBsaXN0cy5saW51eC1mb3VuZGF0aW9uLm9yZwpodHRw czovL2xpc3RzLmxpbnV4Zm91bmRhdGlvbi5vcmcvbWFpbG1hbi9saXN0aW5mby92aXJ0dWFsaXph dGlvbg==