From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C27CAC07E9B for ; Wed, 21 Jul 2021 09:40:07 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1C5B261181 for ; Wed, 21 Jul 2021 09:40:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1C5B261181 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id D9E558203D; Wed, 21 Jul 2021 11:40:04 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1626860405; bh=Yr4Rqa2Fycqj7FahEuTEiLYqiWfO+zwWLBl5RRaG8+M=; h=Subject:To:Cc:References:From:Date:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=MlQR8QtW2UVx6P4S/TMM9MNBI4o1aP93Ye4OlXJIDR06hnZ1kdnRK3BKP74+tnPLM nU9DoRJwasncbMlzDKXNc1VNQfu7DMR2YLtMgJr/lX/xse5F4qFR1vB9Cx0cZf+xkN cZtIbygklioyxPFyZ8ipsY6kWcuJpT6u+sT9Mvy6+9KxueGdkn4l+3Ddw50yLVXdjc t2jyshvwCr6tZ+QEA48j9mONAsIbTO/YqHxLGeL5T9Jzyen50A55CpFygA/uJdaF5k XSOOlHjOvvww2MSH9L1qZntgalGq7y7Fx+UbOHZnZ4qEEg3/C8522yvZuRRleht3SM H3FpVI8Bi4d4g== Received: by phobos.denx.de (Postfix, from userid 109) id B9CEE82916; Wed, 21 Jul 2021 11:40:03 +0200 (CEST) Received: from mout-u-205.mailbox.org (mout-u-205.mailbox.org [91.198.250.254]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 97C5980FB4 for ; Wed, 21 Jul 2021 11:40:00 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=sr@denx.de Received: from smtp2.mailbox.org (smtp2.mailbox.org [80.241.60.241]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-u-205.mailbox.org (Postfix) with ESMTPS id 4GV9Xw3sbHzQkFt; Wed, 21 Jul 2021 11:40:00 +0200 (CEST) Received: from smtp2.mailbox.org ([80.241.60.241]) by spamfilter01.heinlein-hosting.de (spamfilter01.heinlein-hosting.de [80.241.56.115]) (amavisd-new, port 10030) with ESMTP id fz8EhH68jvwg; Wed, 21 Jul 2021 11:39:54 +0200 (CEST) Subject: Re: [PATCH u-boot-mvebu v2 22/41] tools: dumpimage: Show error message when trying to extract data from kwbimage To: =?UTF-8?Q?Marek_Beh=c3=ban?= , u-boot@lists.denx.de, Chris Packham , Baruch Siach , Dirk Eibach , Chris Packham Cc: Dennis Gilmore , Mario Six , Jon Nettleton , =?UTF-8?Q?Pali_Roh=c3=a1r?= References: <20210719122104.29698-1-marek.behun@nic.cz> <20210719122104.29698-23-marek.behun@nic.cz> From: Stefan Roese Message-ID: <6a65daed-1f65-7185-c246-6a404a1483fd@denx.de> Date: Wed, 21 Jul 2021 11:39:51 +0200 MIME-Version: 1.0 In-Reply-To: <20210719122104.29698-23-marek.behun@nic.cz> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: de-DE Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 7F0CD1845 X-Rspamd-UID: 985fa2 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 19.07.21 14:20, Marek Behún wrote: > From: Pali Rohár > > There is no code for extracting data from kwbimage, so show an error > message when user tries this via e.g. dumpimage call: > ./tools/dumpimage -T kwbimage -o /tmp/out u-boot-spl.kwb > > Signed-off-by: Pali Rohár > Reviewed-by: Marek Behún Reviewed-by: Stefan Roese Thanks, Stefan > --- > tools/kwbimage.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/tools/kwbimage.c b/tools/kwbimage.c > index 5410df63f5..9ecda861e4 100644 > --- a/tools/kwbimage.c > +++ b/tools/kwbimage.c > @@ -1867,6 +1867,11 @@ static int kwbimage_generate(struct image_tool_params *params, > */ > static int kwbimage_check_params(struct image_tool_params *params) > { > + if (params->iflag) { > + fprintf(stderr, "%s: kwbimage does not support extract operation\n", params->cmdname); > + return CFG_INVALID; > + } > + > if (!params->imagename || !strlen(params->imagename)) { > char *msg = "Configuration file for kwbimage creation omitted"; > > Viele Grüße, Stefan -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de