From: Qu Wenruo <quwenruo.btrfs@gmx.com>
To: dsterba@suse.cz, Neal Gompa <ngompa13@gmail.com>,
Qu Wenruo <wqu@suse.com>,
Btrfs BTRFS <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH v3 00/10] btrfs: defrag: rework to support sector perfect defrag
Date: Thu, 10 Jun 2021 07:33:39 +0800 [thread overview]
Message-ID: <6a6dcf9d-96ce-65cf-5615-4ffd05d2e1cc@gmx.com> (raw)
In-Reply-To: <20210609230216.GF27283@twin.jikos.cz>
On 2021/6/10 上午7:02, David Sterba wrote:
> On Wed, Jun 09, 2021 at 06:48:31PM -0400, Neal Gompa wrote:
>> On Wed, Jun 9, 2021 at 12:23 PM David Sterba <dsterba@suse.cz> wrote:
>>> On Tue, Jun 08, 2021 at 10:59:17AM +0800, Qu Wenruo wrote:
>>>> [BEHAVIOR CHANGE]
>>>> In the refactor, there is one behavior change:
>>>>
>>>> - Defraged sector counter is based on the initial target list
>>>> This is mostly to avoid the paremters to be passed too deep into
>>>> defrag_one_locked_target().
>>>> Considering the accounting is not that important, we can afford some
>>>> difference.
>>>
>>> As you're going to resend, please fix all occurences of 'defraged' to
>>> 'defragged'.
>>>
>>> I'll give the patchset some testing bug am not sure if it isn't too
>>> risky to put it to the 5.14 queue as it's about time to do only safe
>>> changes.
>>
>> This patch set makes it possible to do compression and balance in
>> subpage cases, right? At least, that's what I understood of it (defrag
>> code is used for balance and compression...).
>
> No it's just to do defragmentation in subpage case. Defrag and balance
> code are indpendent, and only defrag can do compression, balance just
> moves chunks of data but does not do changes to the data itself (it
> could write them in a different way eg. the stripes or copies).
>
Furthermore, defrag code doesn't do compression by itself.
The compression is done during writeback, defrag just tells writeback
code to do compression.
But for subpage enablement right now, compression is disabled
completely, thus no matter what setting you use, compression will not be
enabled.
Thanks,
Qu
next prev parent reply other threads:[~2021-06-09 23:33 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-08 2:59 [PATCH v3 00/10] btrfs: defrag: rework to support sector perfect defrag Qu Wenruo
2021-06-08 2:59 ` [PATCH v3 01/10] btrfs: defrag: pass file_ra_state instead of file for btrfs_defrag_file() Qu Wenruo
2021-06-08 2:59 ` [PATCH v3 02/10] btrfs: defrag: extract the page preparation code into one helper Qu Wenruo
2021-06-08 2:59 ` [PATCH v3 03/10] btrfs: defrag: replace hard coded PAGE_SIZE to sectorsize for defrag_lookup_extent() Qu Wenruo
2021-06-08 2:59 ` [PATCH v3 04/10] btrfs: defrag: introduce a new helper to collect target file extents Qu Wenruo
2021-06-08 2:59 ` [PATCH v3 05/10] btrfs: defrag: introduce a helper to defrag a continuous prepared range Qu Wenruo
2021-06-08 2:59 ` [PATCH v3 06/10] btrfs: defrag: introduce a helper to defrag a range Qu Wenruo
2021-06-09 5:38 ` Qu Wenruo
2021-06-08 2:59 ` [PATCH v3 07/10] btrfs: defrag: introduce a new helper to defrag one cluster Qu Wenruo
2021-06-08 2:59 ` [PATCH v3 08/10] btrfs: defrag: use defrag_one_cluster() to implement btrfs_defrag_file() Qu Wenruo
2021-06-08 2:59 ` [PATCH v3 09/10] btrfs: defrag: remove the old infrastructure Qu Wenruo
2021-06-08 2:59 ` [PATCH v3 10/10] btrfs: defrag: enable defrag for subpage case Qu Wenruo
2021-06-09 15:26 ` [PATCH v3 00/10] btrfs: defrag: rework to support sector perfect defrag David Sterba
2021-06-09 22:48 ` Neal Gompa
2021-06-09 23:02 ` David Sterba
2021-06-09 23:33 ` Qu Wenruo [this message]
2021-06-09 23:31 ` Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a6dcf9d-96ce-65cf-5615-4ffd05d2e1cc@gmx.com \
--to=quwenruo.btrfs@gmx.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=ngompa13@gmail.com \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.