All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Kris Karas (Bug Reporting)" <bugs-a21@moonlit-rail.com>
To: Greg KH <gregkh@linuxfoundation.org>,
	Thorsten Leemhuis <regressions@leemhuis.info>
Cc: "stable@vger.kernel.org" <stable@vger.kernel.org>,
	Linux kernel regressions list <regressions@lists.linux.dev>,
	linux-bluetooth@vger.kernel.org,
	Basavaraj Natikar <Basavaraj.Natikar@amd.com>
Subject: Re: Regression: Inoperative bluetooth, Intel chipset, mainline kernel 6.6.2+
Date: Sat, 2 Dec 2023 01:43:16 -0500	[thread overview]
Message-ID: <6a710423-e76c-437e-ba59-b9cefbda3194@moonlit-rail.com> (raw)
In-Reply-To: <2023120119-bonus-judgingly-bf57@gregkh>

Greg KH wrote:
> On Fri, Dec 01, 2023 at 07:33:03AM +0100, Thorsten Leemhuis wrote:
>> CCing a few lists and people. Greg is among them, who might know if this
>> is a known issue that 6.6.4-rc1 et. al. might already fix.
> 
> Not known to me, bisection is needed so we can track down the problem
> please.

And the winner is...

> commit 14a51fa544225deb9ac2f1f9f3c10dedb29f5d2f
> Author: Basavaraj Natikar <Basavaraj.Natikar@amd.com>
> Date:   Thu Oct 19 13:29:19 2023 +0300
> 
>     xhci: Loosen RPM as default policy to cover for AMD xHC 1.1
>     
>     [ Upstream commit 4baf1218150985ee3ab0a27220456a1f027ea0ac ]
>     
>     The AMD USB host controller (1022:43f7) isn't going into PCI D3 by default
>     without anything connected. This is because the policy that was introduced
>     by commit a611bf473d1f ("xhci-pci: Set runtime PM as default policy on all
>     xHC 1.2 or later devices") only covered 1.2 or later.
>     
> [ snip ]
> diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
> index b9ae5c2a2527..bde43cef8846 100644
> --- a/drivers/usb/host/xhci-pci.c
> +++ b/drivers/usb/host/xhci-pci.c
> @@ -535,6 +535,8 @@ static void xhci_pci_quirks(struct device *dev, struct xhci_hcd *xhci)
>         /* xHC spec requires PCI devices to support D3hot and D3cold */
>         if (xhci->hci_version >= 0x120)
>                 xhci->quirks |= XHCI_DEFAULT_PM_RUNTIME_ALLOW;
> +       else if (pdev->vendor == PCI_VENDOR_ID_AMD && xhci->hci_version >= 0x110)
> +               xhci->quirks |= XHCI_DEFAULT_PM_RUNTIME_ALLOW;
>  
>         if (xhci->quirks & XHCI_RESET_ON_RESUME)
>                 xhci_dbg_trace(xhci, trace_xhci_dbg_quirks,


Huh, OK, I was expecting this to be a patch made to the bluetooth code, 
as it caused bluetoothd to bomb with "opcode 0x0c03 failed".  But I just 
verified I did the bisect correctly by backing this two-liner out of 
vanilla 6.6.3, and bluetooth returned to normal operation.  Huzzah!

Just a brief recap:

This bug appears to be rather hardware-specific, as only a few folks 
have reported it.  In my case, the hardware is an ASrock "X470 Taichi" 
motherboard, and its on-board bluetooth hardware, reporting itself as:
lspci: 0f:00.3 USB controller: Advanced Micro Devices, Inc. [AMD] 
Zeppelin USB 3.0 xHCI Compliant Host Controller
lsusb: ID 8087:0aa7 Intel Corp. Wireless-AC 3168 Bluetooth

When Basavaraj's patch is applied (in mainline 6.6.2+), bluetooth stops 
functioning on my motherboard.

Originally from bugzilla #218142

-- 
Kris

  reply	other threads:[~2023-12-02  6:43 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-01  1:54 Regression: Inoperative bluetooth, Intel chipset, mainline kernel 6.6.2+ Kris Karas (Bug Reporting)
2023-12-01  6:27 ` Bagas Sanjaya
2023-12-01  8:19   ` Kris Karas (Bug Reporting)
2023-12-01  8:27     ` Paul Menzel
2023-12-03 12:17     ` Oleksandr Natalenko
2023-12-03 18:46       ` Kris Karas (Bug Reporting)
2023-12-01  6:33 ` Thorsten Leemhuis
2023-12-01  8:15   ` Greg KH
2023-12-02  6:43     ` Kris Karas (Bug Reporting) [this message]
2023-12-02  7:23       ` Paul Menzel
2023-12-02  7:50         ` Greg KH
2023-12-02  7:58           ` Kris Karas (Bug Reporting)
2023-12-02  8:15             ` Greg KH
2023-12-03  8:32               ` Kris Karas (Bug Reporting)
2023-12-03  8:38                 ` Greg KH
2023-12-03 16:16                   ` Basavaraj Natikar
2023-12-03 16:24                     ` Basavaraj Natikar
2023-12-03 19:52                       ` Oleksandr Natalenko
2023-12-04  9:12                   ` Mathias Nyman
2023-12-04 10:08                     ` [PATCH 1/2] Revert "xhci: Enable RPM on controllers that support low-power states" Mathias Nyman
2023-12-04 10:08                       ` [PATCH 2/2] Revert "xhci: Loosen RPM as default policy to cover for AMD xHC 1.1" Mathias Nyman
2023-12-04 10:14                       ` [1/2] Revert "xhci: Enable RPM on controllers that support low-power states" bluez.test.bot
2023-12-04 10:49                       ` [PATCH 1/2] " Basavaraj Natikar
2023-12-04 14:22                         ` Mathias Nyman
2023-12-04 14:49                           ` Basavaraj Natikar
2023-12-04 15:06                             ` Mathias Nyman
2023-12-04 15:29                               ` Basavaraj Natikar
2023-12-04 23:55                                 ` Greg KH
2023-12-05  9:05                                   ` [PATCH v2] Revert "xhci: Loosen RPM as default policy to cover for AMD xHC 1.1" Mathias Nyman
2023-12-05  9:13                                     ` [v2] " bluez.test.bot
2023-12-05 18:36                                     ` [PATCH v2] " Mario Limonciello
2023-12-15 16:53                                     ` patchwork-bot+bluetooth
2023-12-15 16:53                       ` [PATCH 1/2] Revert "xhci: Enable RPM on controllers that support low-power states" patchwork-bot+bluetooth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6a710423-e76c-437e-ba59-b9cefbda3194@moonlit-rail.com \
    --to=bugs-a21@moonlit-rail.com \
    --cc=Basavaraj.Natikar@amd.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=regressions@leemhuis.info \
    --cc=regressions@lists.linux.dev \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.