[PATCH] scsi: target: core: Make logs less verbose

[PATCH] scsi: target: core: Make logs less verbose

[Konstantin Shelekhin]

Change the log level of the following message to debug:

	Unsupported SCSI Opcode 0xXX, sending CHECK_CONDITION.

This message is mostly helpful during debugging sessions in order to
understand errors on the initiator side. But most of the time it's just
useless and makes reading logs much harder.

It gets particularly annoying if there are many initiators that come and
go or if an initiator runs a program that does not care whether the
command is supported and just keeps sending it.

Signed-off-by: Konstantin Shelekhin <k.shelekhin@yadro.com>
Reviewed-by: Roman Bolshakov <r.bolshakov@yadro.com>
---
 drivers/target/target_core_transport.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/target/target_core_transport.c b/drivers/target/target_core_transport.c
index 14c6f2bb1b01..4a0055ab9151 100644
--- a/drivers/target/target_core_transport.c
+++ b/drivers/target/target_core_transport.c
@@ -1511,10 +1511,10 @@ target_cmd_parse_cdb(struct se_cmd *cmd)
 
 	ret = dev->transport->parse_cdb(cmd);
 	if (ret == TCM_UNSUPPORTED_SCSI_OPCODE)
-		pr_warn_ratelimited("%s/%s: Unsupported SCSI Opcode 0x%02x, sending CHECK_CONDITION.\n",
-				    cmd->se_tfo->fabric_name,
-				    cmd->se_sess->se_node_acl->initiatorname,
-				    cmd->t_task_cdb[0]);
+		pr_debug_ratelimited("%s/%s: Unsupported SCSI Opcode 0x%02x, sending CHECK_CONDITION.\n",
+				     cmd->se_tfo->fabric_name,
+				     cmd->se_sess->se_node_acl->initiatorname,
+				     cmd->t_task_cdb[0]);
 	if (ret)
 		return ret;
 
-- 
2.33.0

Re: [PATCH] scsi: target: core: Make logs less verbose

[Lee Duncan]

On 9/29/21 4:50 AM, Konstantin Shelekhin wrote:
> Change the log level of the following message to debug:
> 
> 	Unsupported SCSI Opcode 0xXX, sending CHECK_CONDITION.
> 
> This message is mostly helpful during debugging sessions in order to
> understand errors on the initiator side. But most of the time it's just
> useless and makes reading logs much harder.
> 
> It gets particularly annoying if there are many initiators that come and
> go or if an initiator runs a program that does not care whether the
> command is supported and just keeps sending it.
> 
> Signed-off-by: Konstantin Shelekhin <k.shelekhin@yadro.com>
> Reviewed-by: Roman Bolshakov <r.bolshakov@yadro.com>
> ---
>  drivers/target/target_core_transport.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/target/target_core_transport.c b/drivers/target/target_core_transport.c
> index 14c6f2bb1b01..4a0055ab9151 100644
> --- a/drivers/target/target_core_transport.c
> +++ b/drivers/target/target_core_transport.c
> @@ -1511,10 +1511,10 @@ target_cmd_parse_cdb(struct se_cmd *cmd)
>  
>  	ret = dev->transport->parse_cdb(cmd);
>  	if (ret == TCM_UNSUPPORTED_SCSI_OPCODE)
> -		pr_warn_ratelimited("%s/%s: Unsupported SCSI Opcode 0x%02x, sending CHECK_CONDITION.\n",
> -				    cmd->se_tfo->fabric_name,
> -				    cmd->se_sess->se_node_acl->initiatorname,
> -				    cmd->t_task_cdb[0]);
> +		pr_debug_ratelimited("%s/%s: Unsupported SCSI Opcode 0x%02x, sending CHECK_CONDITION.\n",
> +				     cmd->se_tfo->fabric_name,
> +				     cmd->se_sess->se_node_acl->initiatorname,
> +				     cmd->t_task_cdb[0]);
>  	if (ret)
>  		return ret;
>  
> 

Reviewed-by: Lee Duncan <lduncan@suse.com>

Re: [PATCH] scsi: target: core: Make logs less verbose

[Martin K. Petersen]

Konstantin,

> Change the log level of the following message to debug:
>
> 	Unsupported SCSI Opcode 0xXX, sending CHECK_CONDITION.

Applied to 5.16/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering

Re: [PATCH] scsi: target: core: Make logs less verbose

[Martin K. Petersen]

On Wed, 29 Sep 2021 14:50:00 +0300, Konstantin Shelekhin wrote:

> Change the log level of the following message to debug:
> 
> 	Unsupported SCSI Opcode 0xXX, sending CHECK_CONDITION.
> 
> This message is mostly helpful during debugging sessions in order to
> understand errors on the initiator side. But most of the time it's just
> useless and makes reading logs much harder.
> 
> [...]

Applied to 5.16/scsi-queue, thanks!

[1/1] scsi: target: core: Make logs less verbose
      https://git.kernel.org/mkp/scsi/c/05787e3456ff

-- 
Martin K. Petersen	Oracle Linux Engineering