All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yonghong Song <yhs@fb.com>
To: Juhee Kang <claudiajkang@gmail.com>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Alexei Starovoitov <ast@kernel.org>,
	Andrii Nakryiko <andrii@kernel.org>
Cc: <netdev@vger.kernel.org>, <bpf@vger.kernel.org>
Subject: Re: [bpf-next 1/2] samples: bpf: Fix tracex7 error raised on the missing argument
Date: Sun, 25 Jul 2021 19:34:03 -0700	[thread overview]
Message-ID: <6a73ed66-feb8-d85c-dfbe-4ae7005608db@fb.com> (raw)
In-Reply-To: <20210724152124.9762-1-claudiajkang@gmail.com>



On 7/24/21 8:21 AM, Juhee Kang wrote:
> The current behavior of 'tracex7' doesn't consist with other bpf samples
> tracex{1..6}. Other samples do not require any argument to run with, but
> tracex7 should be run with btrfs device argument. (it should be executed
> with test_override_return.sh)
> 
> Currently, tracex7 doesn't have any description about how to run this
> program and raises an unexpected error. And this result might be
> confusing since users might not have a hunch about how to run this
> program.
> 
>      // Current behavior
>      # ./tracex7
>      sh: 1: Syntax error: word unexpected (expecting ")")
>      // Fixed behavior
>      # ./tracex7
>      ERROR: Run with the btrfs device argument!
> 
> In order to fix this error, this commit adds logic to report a message
> and exit when running this program with a missing argument.
> 
> Additionally in test_override_return.sh, there is a problem with
> multiple directory(tmpmnt) creation. So in this commit adds a line with
> removing the directory with every execution.
> 
> Signed-off-by: Juhee Kang <claudiajkang@gmail.com>

Acked-by: Yonghong Song <yhs@fb.com>

  parent reply	other threads:[~2021-07-26  2:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-24 15:21 [bpf-next 1/2] samples: bpf: Fix tracex7 error raised on the missing argument Juhee Kang
2021-07-24 15:21 ` [bpf-next 2/2] samples: bpf: Add the omitted xdp samples to .gitignore Juhee Kang
2021-07-26  2:34   ` Yonghong Song
2021-07-26  2:34 ` Yonghong Song [this message]
2021-07-26 20:08 ` [bpf-next 1/2] samples: bpf: Fix tracex7 error raised on the missing argument Andrii Nakryiko
2021-07-27  3:32   ` Juhee Kang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6a73ed66-feb8-d85c-dfbe-4ae7005608db@fb.com \
    --to=yhs@fb.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=claudiajkang@gmail.com \
    --cc=daniel@iogearbox.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.