From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7640C2B9F8 for ; Tue, 25 May 2021 09:03:34 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 447936100B for ; Tue, 25 May 2021 09:03:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 447936100B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=amsat.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:49012 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1llSyL-0007Sg-BH for qemu-devel@archiver.kernel.org; Tue, 25 May 2021 05:03:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58432) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1llSxB-0005oq-Vz for qemu-devel@nongnu.org; Tue, 25 May 2021 05:02:22 -0400 Received: from mail-wr1-x430.google.com ([2a00:1450:4864:20::430]:33645) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1llSx8-0004xe-Mt for qemu-devel@nongnu.org; Tue, 25 May 2021 05:02:20 -0400 Received: by mail-wr1-x430.google.com with SMTP id n2so31419626wrm.0 for ; Tue, 25 May 2021 02:02:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=dNHd4KkCX1F0nw9SxM5u+xtwkO2MbMGgjufuCoHAZtg=; b=qBeMUDUmT7snQlRpBne0s17a81djRTbDRwGQMmtQEL4qaoNdJ0t78QI7dQL93hB/RE dxXj0+0nlss/2RwAhjryLDv1muqs83jLVuOww+J+ZBWOJxQF/ObkHhr584w20MBWg4LG uXFKyt/75+d831jJ9xN+Ik/b8kL6gcrRTc46QplRtEq7KvY/RUnoQ/EqLJ7EtAfpcx8s 5ZJeAssGwroa+9sYcucc6EUqxwdU2UjKWJdN4FVhEqabM8p5hhqQK49VJ0aLlrwe8ce5 Ch+CziLaI7JQeK0quYUI4X9d2KnyKkZ8mOtVf1z/U60NP5oQ8xguLQQTjEnw+mmTAKiS 591A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=dNHd4KkCX1F0nw9SxM5u+xtwkO2MbMGgjufuCoHAZtg=; b=WfjDKvWnEjg2aAjEiPJ/IrGo2gHYs2yQe6bN/VGF4vuVUId9eGNGQAnq47B92lGHIC MRZiRTjIP075d4hFBxn9C3puZYO4y+0n/rAixkjFSWda9X7fl92vVhFijO3P57iaiddz RFfb7qUpSVcLQZfTTwLblbxWJ9RNhpoh7Ibb1xCjBYy4xE1T9QKZBvdyoDB0eXrONKlq TLkyC1ZDiioyrooO7UbMMeDKpJymC11KFLYW9HmBXM9WwivS4oldSxCl4x3syrTDaX6C g9V+y59f8QDiYt/bbhQB2pBrMs1RkF7D/Fen9fsRU94l2G28s/MVh9l6rbShd/ngxp5N duNw== X-Gm-Message-State: AOAM532xMM4A1RLaDKA9OBRwwtEZZ+HnP1G130VV04xYDBrsW9r8MHKb qpPOxZdRjeFDdIB93+9KjBo= X-Google-Smtp-Source: ABdhPJzW/49aPjN+UbajBn1dK4ygeKsjD7TT9uN3jk6FTbelMcTf5cs9vsbF7eeMvqZicz3Z3Vj+5A== X-Received: by 2002:a05:6000:12cc:: with SMTP id l12mr25863188wrx.91.1621933337141; Tue, 25 May 2021 02:02:17 -0700 (PDT) Received: from [192.168.1.36] (31.red-83-51-215.dynamicip.rima-tde.net. [83.51.215.31]) by smtp.gmail.com with ESMTPSA id l3sm10283608wmh.2.2021.05.25.02.02.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 May 2021 02:02:16 -0700 (PDT) Subject: Re: [PATCH 9/9] gitlab-ci: Use absolute path and simplify firmware jobs To: =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= References: <20210525082556.4011380-1-f4bug@amsat.org> <20210525082556.4011380-10-f4bug@amsat.org> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: <6a748bb4-d883-eb09-2280-7a4e65bc2691@amsat.org> Date: Tue, 25 May 2021 11:02:15 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::430; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-x430.google.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , =?UTF-8?Q?Alex_Benn=c3=a9e?= , qemu-devel@nongnu.org, Wainer dos Santos Moschetta , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Willian Rampazzo , Bin Meng , Laszlo Ersek Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 5/25/21 10:56 AM, Daniel P. Berrangé wrote: > On Tue, May 25, 2021 at 10:25:56AM +0200, Philippe Mathieu-Daudé wrote: >> The GitLab 'add job on file changed' feature doesn't work well >> with relative paths: use absolute paths instead. >> >> Change the 'rules:' section by an 'only:' one which is easier >> to read. > > GitLab docs say "rules replaces only/except", so I'm not convinced > we should be going back to the old syntax, especially as that means > some jobs will use 'rules' and some jobs will use 'only'. Consistency > across jobs wins for me and "rules" is much more expressive. OK. I wanted to tag this patch RFC anyway, but forgot. Please disregard it (the rest of the series doesn't rely on it).