From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FF7AC04FF3 for ; Mon, 24 May 2021 06:37:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 24512611AC for ; Mon, 24 May 2021 06:37:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232291AbhEXGjH (ORCPT ); Mon, 24 May 2021 02:39:07 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:3638 "EHLO szxga05-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232320AbhEXGjC (ORCPT ); Mon, 24 May 2021 02:39:02 -0400 Received: from dggems705-chm.china.huawei.com (unknown [172.30.72.59]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4FpS900Rf7zQsCC; Mon, 24 May 2021 14:33:56 +0800 (CST) Received: from dggemi762-chm.china.huawei.com (10.1.198.148) by dggems705-chm.china.huawei.com (10.3.19.182) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2176.2; Mon, 24 May 2021 14:37:31 +0800 Received: from [10.174.178.208] (10.174.178.208) by dggemi762-chm.china.huawei.com (10.1.198.148) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Mon, 24 May 2021 14:37:30 +0800 Subject: Re: [PATCH -next] drm: Fix PM reference leak To: , , , , , , , , , , References: <1621602186-74786-1-git-send-email-zou_wei@huawei.com> From: Samuel Zou Message-ID: <6a7716c5-212c-58e6-0d84-7656e18fddc6@huawei.com> Date: Mon, 24 May 2021 14:37:30 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.178.208] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggemi762-chm.china.huawei.com (10.1.198.148) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Daniel, Thanks for your review, I will split the patch and resend. On 2021/5/21 23:32, Daniel Vetter wrote: > On Fri, May 21, 2021 at 09:03:06PM +0800, Zou Wei wrote: >> pm_runtime_get_sync will increment pm usage counter even it failed. >> Forgetting to putting operation will result in reference leak here. >> Fix it by replacing it with pm_runtime_resume_and_get to keep usage >> counter balanced. >> >> Reported-by: Hulk Robot >> Signed-off-by: Zou Wei > > Looks good, but can you pls split this up into a patch per driver (vc and > bridge/cdns-dsi here)? > > Thanks, Daniel > >> --- >> drivers/gpu/drm/bridge/cdns-dsi.c | 2 +- >> drivers/gpu/drm/vc4/vc4_hdmi.c | 2 +- >> 2 files changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/gpu/drm/bridge/cdns-dsi.c b/drivers/gpu/drm/bridge/cdns-dsi.c >> index 76373e3..b31281f 100644 >> --- a/drivers/gpu/drm/bridge/cdns-dsi.c >> +++ b/drivers/gpu/drm/bridge/cdns-dsi.c >> @@ -1028,7 +1028,7 @@ static ssize_t cdns_dsi_transfer(struct mipi_dsi_host *host, >> struct mipi_dsi_packet packet; >> int ret, i, tx_len, rx_len; >> >> - ret = pm_runtime_get_sync(host->dev); >> + ret = pm_runtime_resume_and_get(host->dev); >> if (ret < 0) >> return ret; >> >> diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c >> index c27b287..f20a65b 100644 >> --- a/drivers/gpu/drm/vc4/vc4_hdmi.c >> +++ b/drivers/gpu/drm/vc4/vc4_hdmi.c >> @@ -798,7 +798,7 @@ static void vc4_hdmi_encoder_pre_crtc_configure(struct drm_encoder *encoder, >> unsigned long pixel_rate, hsm_rate; >> int ret; >> >> - ret = pm_runtime_get_sync(&vc4_hdmi->pdev->dev); >> + ret = pm_runtime_resume_and_get(&vc4_hdmi->pdev->dev); >> if (ret < 0) { >> DRM_ERROR("Failed to retain power domain: %d\n", ret); >> return; >> -- >> 2.6.2 >> >