All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hans Verkuil <hverkuil-cisco@xs4all.nl>
To: Jacopo Mondi <jacopo@jmondi.org>,
	"open list:MEDIA INPUT INFRASTRUCTURE (V4L/DVB)" 
	<linux-media@vger.kernel.org>,
	libcamera-devel@lists.libcamera.org,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Sakari Ailus <sakari.ailus@linux.intel.com>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Rob Herring <robh@kernel.org>
Cc: tfiga@google.com, pavel@ucw.cz, devicetree@vger.kernel.org
Subject: Re: [PATCH v11 13/13] dt-bindings: Add media properties
Date: Mon, 11 May 2020 09:27:57 +0200	[thread overview]
Message-ID: <6a8add4e-c1f6-bd08-8928-3c8884eeda2c@xs4all.nl> (raw)
In-Reply-To: <20200509090456.3496481-14-jacopo@jmondi.org>

On 09/05/2020 11:04, Jacopo Mondi wrote:
> Add a DT header file to contain definitions for standard media properties.
> 
> The file is named after:
> Documentation/devicetree/bindings/media/video-interfaces.txt
> which contains the standard media properties definitions.
> 
> Initially add three macros to define the supported 'orientation'
> property values.
> 
> Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
> ---
> 
> I currently don't have users in mainline for this, I understand this implies
> this is probably not going to be accepted. At the same time we don't have a
> common place for media-related definitions, which support properties defined in
> video-interfaces.txt
> 
> I leave it here at the end of the series for discussions, but I'm fine dropping
> it from the series.
> 
> Thanks
>   j
> 
> ---
>  include/dt-bindings/media/video-interfaces.h | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
>  create mode 100644 include/dt-bindings/media/video-interfaces.h
> 
> diff --git a/include/dt-bindings/media/video-interfaces.h b/include/dt-bindings/media/video-interfaces.h
> new file mode 100644
> index 0000000000000..404c697d6bd6e
> --- /dev/null
> +++ b/include/dt-bindings/media/video-interfaces.h
> @@ -0,0 +1,15 @@
> +/* SPDX-License-Identifier: GPL-2.0-only */
> +/*
> + * include/dt-bindings/media/video-interfaces.h
> + *
> + * Copyright (C) 2020 Jacopo Mondi <jacopo@jmondi.org>
> + */
> +
> +#ifndef __DT_BINDINGS_MEDIA_VIDEO_INTERFACES_H__
> +#define __DT_BINDINGS_MEDIA_VIDEO_INTERFACES_H__
> +
> +#define FRONT_CAMERA		<0>
> +#define BACK_CAMERA		<1>
> +#define EXTERNAL_CAMERA		<2>

Uh, shouldn't that be 0, 1 and 2 instead of <0>, <1> and <2> ?

I'm skipping this patch for the PR.

Regards,

	Hans

> +
> +#endif /* __DT_BINDINGS_MEDIA_VIDEO_INTERFACES_H__ */
> --
> 2.26.1
> 


  reply	other threads:[~2020-05-11  7:28 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-09  9:04 [PATCH v11 00/13] media: report camera properties Jacopo Mondi
2020-05-09  9:04 ` [PATCH v11 01/13] dt-bindings: video-interfaces: Document 'orientation' property Jacopo Mondi
2020-05-25 11:13   ` Pavel Machek
2020-05-09  9:04 ` [PATCH v11 02/13] dt-bindings: video-interface: Replace 'rotation' description Jacopo Mondi
2020-05-25 11:16   ` Pavel Machek
2020-05-25 12:46     ` Jacopo Mondi
2020-05-09  9:04 ` [PATCH v11 03/13] media: v4l2-ctrl: Document V4L2_CID_CAMERA_ORIENTATION Jacopo Mondi
2020-05-09  9:04 ` [PATCH v11 04/13] media: v4l2-ctrl: Document V4L2_CID_CAMERA_SENSOR_ROTATION Jacopo Mondi
2020-05-09  9:04 ` [PATCH v11 05/13] media: v4l2-ctrls: Add camera orientation and rotation Jacopo Mondi
2020-05-09  9:04 ` [PATCH v11 06/13] media: v4l2-fwnode: Add helper to parse device properties Jacopo Mondi
2020-05-09  9:04 ` [PATCH v11 07/13] include: v4l2-ctrl: Sort forward declarations Jacopo Mondi
2020-05-09  9:04 ` [PATCH v11 08/13] media: v4l2-ctrls: Sort includes alphabetically Jacopo Mondi
2020-05-09  9:04 ` [PATCH v11 09/13] media: v4l2-ctrls: Add helper to register properties Jacopo Mondi
2020-05-09  9:04 ` [PATCH v11 10/13] media: i2c: ov5670: Parse and " Jacopo Mondi
2020-05-09  9:04 ` [PATCH v11 11/13] media: i2c: ov13858: " Jacopo Mondi
2020-05-09  9:04 ` [PATCH v11 12/13] media: i2c: imx219: " Jacopo Mondi
2020-05-09  9:04 ` [PATCH v11 13/13] dt-bindings: Add media properties Jacopo Mondi
2020-05-11  7:27   ` Hans Verkuil [this message]
2020-05-20  7:52     ` Jacopo Mondi
2020-06-24 13:46       ` Hans Verkuil
2020-05-18 18:21   ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6a8add4e-c1f6-bd08-8928-3c8884eeda2c@xs4all.nl \
    --to=hverkuil-cisco@xs4all.nl \
    --cc=devicetree@vger.kernel.org \
    --cc=jacopo@jmondi.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=libcamera-devel@lists.libcamera.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=pavel@ucw.cz \
    --cc=robh@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    --cc=tfiga@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.