From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Julien Grall <julien@xen.org>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: "sstabellini@kernel.org" <sstabellini@kernel.org>,
Bertrand Marquis <bertrand.marquis@arm.com>,
Rahul Singh <rahul.singh@arm.com>,
Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH] xen/arm: fix SBDF calculation for vPCI MMIO handlers
Date: Thu, 28 Oct 2021 18:00:22 +0000 [thread overview]
Message-ID: <6aa95015-c2c1-e55a-5303-c82842c94438@epam.com> (raw)
In-Reply-To: <a74b52fb-6514-4187-17fe-b63236efa0ce@xen.org>
On 28.10.21 18:35, Julien Grall wrote:
> Hi,
>
> On 28/10/2021 16:27, Oleksandr Andrushchenko wrote:
>> bridge as private and using info->gpa - GUEST_VPCI_ECAM_BASE...
>> So, I would stay with simpler
>>
>> if ( bridge )
>> {
>> sbdf.sbdf = VPCI_ECAM_BDF(info->gpa - bridge->cfg->phys_addr);
>> sbdf.seg = bridge->segment;
>> }
>> else
>> sbdf.sbdf = VPCI_ECAM_BDF(info->gpa - GUEST_VPCI_ECAM_BASE);
>
> I am fine with that so long this is part of an helper (maybe vpci_sbdf_from_addr()) rather than duplicated.
>
Ok, I will implement a helper then:
pci_sbdf_t vpci_sbdf_from_gpa(const struct pci_host_bridge *bridge, paddr_t gpa);
> Cheers,
>
Thank you,
Oleksandr
next prev parent reply other threads:[~2021-10-28 18:00 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-27 8:25 [PATCH] xen/arm: fix SBDF calculation for vPCI MMIO handlers Oleksandr Andrushchenko
2021-10-27 8:59 ` Roger Pau Monné
2021-10-27 9:04 ` Oleksandr Andrushchenko
2021-10-27 9:23 ` Roger Pau Monné
2021-10-27 9:46 ` Oleksandr Andrushchenko
2021-10-27 17:07 ` Ian Jackson
2021-11-01 10:25 ` [PATCH] xen/arm: fix SBDF calculation for vPCI MMIO handlers [and 2 more messages] Ian Jackson
2021-11-01 21:06 ` Stefano Stabellini
2021-11-02 7:16 ` Oleksandr Andrushchenko
2021-11-02 9:32 ` Julien Grall
2021-11-02 11:21 ` Oleksandr Andrushchenko
2021-11-02 15:55 ` Ian Jackson
2021-10-27 17:35 ` [PATCH] xen/arm: fix SBDF calculation for vPCI MMIO handlers Julien Grall
2021-10-28 12:09 ` Oleksandr Andrushchenko
2021-10-28 13:22 ` Julien Grall
2021-10-28 14:16 ` Oleksandr Andrushchenko
2021-10-28 14:28 ` Julien Grall
2021-10-28 15:27 ` Oleksandr Andrushchenko
2021-10-28 15:35 ` Julien Grall
2021-10-28 15:54 ` Ian Jackson
2021-10-29 9:15 ` Julien Grall
2021-10-28 18:00 ` Oleksandr Andrushchenko [this message]
2021-10-28 13:36 ` Roger Pau Monné
2021-10-28 14:23 ` Oleksandr Andrushchenko
2021-10-28 16:03 ` Roger Pau Monné
2021-10-28 17:55 ` Oleksandr Andrushchenko
2021-10-29 7:33 ` Roger Pau Monné
2021-11-01 6:14 ` Oleksandr Andrushchenko
2021-11-02 7:37 ` Wei Chen
2021-11-02 7:46 ` Oleksandr Andrushchenko
2021-11-02 8:12 ` Wei Chen
2021-11-02 8:48 ` Roger Pau Monné
2021-11-02 9:07 ` Oleksandr Andrushchenko
2021-11-02 9:32 ` Roger Pau Monné
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6aa95015-c2c1-e55a-5303-c82842c94438@epam.com \
--to=oleksandr_andrushchenko@epam.com \
--cc=bertrand.marquis@arm.com \
--cc=julien@xen.org \
--cc=rahul.singh@arm.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.