From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30F52C43464 for ; Thu, 17 Sep 2020 21:20:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CEA8720678 for ; Thu, 17 Sep 2020 21:20:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=intel.onmicrosoft.com header.i=@intel.onmicrosoft.com header.b="UIlsamDW" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726126AbgIQVUo (ORCPT ); Thu, 17 Sep 2020 17:20:44 -0400 Received: from mga09.intel.com ([134.134.136.24]:33449 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725858AbgIQVUo (ORCPT ); Thu, 17 Sep 2020 17:20:44 -0400 IronPort-SDR: Bymb7KLoooVMgEYlgiAOwRq1jwhfZ8Dakh11+hemlmOkvkIZo64CTMPjwFmjfvvLhV/Md+soC0 qV7dy+rzi9hA== X-IronPort-AV: E=McAfee;i="6000,8403,9747"; a="160722258" X-IronPort-AV: E=Sophos;i="5.77,272,1596524400"; d="scan'208";a="160722258" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Sep 2020 14:11:36 -0700 IronPort-SDR: SRGNh5m1nt6x3wcLWF/PABYT0Gp0QsyLVOjUxjrG8ZZZwmM8JC7RvVoMh+Ru2rXAgjGrgF+gBQ c43KbuFsWu8g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,272,1596524400"; d="scan'208";a="339566438" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by fmsmga002.fm.intel.com with ESMTP; 17 Sep 2020 14:11:36 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 17 Sep 2020 14:11:35 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Thu, 17 Sep 2020 14:11:35 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.168) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Thu, 17 Sep 2020 14:11:34 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jKLhcUDbIt5egsQJzzMwoB3IDS7wQY4dUSAOqwbgJNx8E7W9yIGh9cNo2Z3QiIosR0Z++L04hQpI1Mf51BscDIKHn4WoIb3TgGg7f59VUZrycE2bRY9IvRnSudClsie+5BNcZ/swV1H+vfs2XE65QV0mX9+x8f+27/WGVK03TjumRzkUHiaNt2uM7jY9K8x7V/2A1Y7Wp5XSwOuETGdP2zjwBEQjSLqsuuRLgh6PKxCn+CFKCfTGCKiFkqrKhfm9n7uE9tWPEWMcRmHMYnY8dHGNeY/0Waiw2+nmZCLgyt0MGbS9cEYSJRBAw0TeG5YpRZE+T37KtQph9AA/kHU/Xg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZJArvnx3QfOt6lNWeckv4FsW19JAMcUnMUHaRCFR/sU=; b=CstlZtYnKaER/QQsGtnhZnJKZvdJf9seL/1hiAnZSjL7lGuwiu0BvUfyjUUZyWVG8Brv2k/akDFP9Je9FaD48DDE/8QxNG582dqyLbM5Vh1wIz0ArsEXykvRCmNNiEM62mEPcpszIAOLwDOtyneQf0rjuaGYIK7BGAgwVhJx85J+S8VnPOAIMnB1w1o6kdzEBWjs2bJ5YO65Us9vXgRWXlYOlT4EEpAEW+f3XlNRlTLDd+NVUHE12qOBQPmcEUyOKD7aF6fU+4WoTbcrVJRcb+zf/suY6MaDXY478JwKIRa9KDFw6GG+Tu1CEG7f6OrDa2zOwpNymq1bY6mc5mBmlQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZJArvnx3QfOt6lNWeckv4FsW19JAMcUnMUHaRCFR/sU=; b=UIlsamDWdLq64xPHRO9uFrTYklfMH86HkGkR9edG/qL688keSJtyknMzW/kL47x5xr5QAx1F+OUf54GViVDVqSi41LGLToFpQ05mnb4dTUIuuypbBkMngLzv430y0cmTyY7XKMzr7YYq/sKFVNC0VRMq0S1TppqmWeCLeUsPqn4= Received: from SN6PR11MB3229.namprd11.prod.outlook.com (2603:10b6:805:ba::28) by SN6PR11MB2976.namprd11.prod.outlook.com (2603:10b6:805:d5::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3370.16; Thu, 17 Sep 2020 21:11:32 +0000 Received: from SN6PR11MB3229.namprd11.prod.outlook.com ([fe80::7147:6b91:afe3:1579]) by SN6PR11MB3229.namprd11.prod.outlook.com ([fe80::7147:6b91:afe3:1579%3]) with mapi id 15.20.3370.019; Thu, 17 Sep 2020 21:11:32 +0000 From: "Nguyen, Anthony L" To: "alex.dewar90@gmail.com" CC: "netdev@vger.kernel.org" , "davem@davemloft.net" , "Kirsher, Jeffrey T" , "intel-wired-lan@lists.osuosl.org" , "kuba@kernel.org" , "linux-kernel@vger.kernel.org" , "Topel, Bjorn" Subject: Re: [PATCH] i40e: Fix use of uninitialized variable Thread-Topic: [PATCH] i40e: Fix use of uninitialized variable Thread-Index: AQHWjGsRLgMwwhuISEmenowm+AvAhaltVWSA Date: Thu, 17 Sep 2020 21:11:32 +0000 Message-ID: <6aaa242f49ccd3824fe4cbb38bada7ccf9add979.camel@intel.com> References: <20200916204943.41017-1-alex.dewar90@gmail.com> In-Reply-To: <20200916204943.41017-1-alex.dewar90@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Evolution 3.28.5 (3.28.5-3.fc28) authentication-results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [134.134.136.204] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 301e08fe-03b4-4698-3ffa-08d85b4e40b9 x-ms-traffictypediagnostic: SN6PR11MB2976: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: cqP7M3hIafKFk19jHsgUsbWrBgbDrUHNMJxPJRK89m3kHPgdlqfzJhJnFQSn7EHX5qbHdK4sy+tz4Wh5u2r2vl8m/Ub7OFK28N5qDgXL+JMi2RSz5MVfmtK4wm67SKl9g7/Elw4Q9KDvQk4uTgOVw3vj+lOuDEJBRn46e4H3QDLtgTJS6/YZufgdiW6+qR7Qdnzl/zR2OfqHgYKXFblWlp/RKBRPJ5+gAR29u9qyRcIgHr0wh9aB5vBPmpXC2YVBhJLShRkEXDPQds4qgtWb8zihFsZeVOj+f+PBHD+0Zn9fa8a+pIjHcB1dsnWjgmIcO+CHpBn7q6741TlGcRCsoUD6YcQbsty/oO95LN8zk8fUObncmTxiFgZvWOg8NxPVnyt835wZfQUoMyJE0x3hbG2Y+Ir1e3BahJaey1+aLxaNca/KcR0saWEXITpBoNBUyzntFJ/VgmgkqMd/OiyCCA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR11MB3229.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(376002)(396003)(136003)(39860400002)(366004)(91956017)(26005)(478600001)(2616005)(2906002)(316002)(186003)(6512007)(8936002)(36756003)(6916009)(71200400001)(6486002)(54906003)(86362001)(4744005)(6506007)(107886003)(83380400001)(8676002)(4326008)(5660300002)(66446008)(66476007)(76116006)(66946007)(966005)(66556008)(64756008)(99106002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: Doe8D66bNP1kVv7gPRA0+xSLSGD7nHMjsZIhVVjCMQv63XMq9Q4xZePhov+WpQuBuAubHVl2X4K5YXGKLEB+TTXLlUClOUyVAacMTFbHJD1O2WxdLvnvJz8AWb/BOz0EuNVt2a1EVewQcmXb8U99ILJ0z+mVV5qTxbWDPFHchYNf+ZXYFaBzokqgRQShG1HTxDVXSJbW0Z7IquRVwU+oib/qzCyU50lywH5WjPcf3XL5KSgsHPRg36Iakhmr8zvXFs9KsUUlm7giIARkkBcVYHovTqdXq3AOv+nt29zAOJ5/tRMW2dx9kFKbAJ1eWMVa6x9IajS5viM6/GhAAKIU6vdfCoKOeWijnmj6KtJfmk8gApepwDyBDRYwREgDX/6b5YnWBxG36yV3h+Pe49iH8WK2MH5MnCZZTvh4dzTW9ZkUapoPQUFgcnOgwfEdS2HeMPBUV/4P5mYGWuMH6JfPixhwWq05C3PO0xoSB80TW4Y1ZY5+lg8bYte0VeUuaatKBIitNZzGUbniqJLSmAUr4LRkNSPrTS2yGR8yEZhjxGz6MU/Mow6v4MYhynbdI/20fWve5z1CrTIiTzaEjBw4Bs6Cq625dV0QPxsY1q5nruMSG1sL8DwxxYh1Trp51lxtczZCfXp1SL/D0qojK7SAXQ== Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3229.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 301e08fe-03b4-4698-3ffa-08d85b4e40b9 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Sep 2020 21:11:32.3464 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ++Iqyu7I71bJzYniv1KiraVOlHKSFtcfjF4AZX8h6pegGdc+SWu5BGVex45fw49fqnJc1zwhd/oyK6flpYhLdUU0SHL2tty5rO9c/VN8k58= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB2976 X-OriginatorOrg: intel.com Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org T24gV2VkLCAyMDIwLTA5LTE2IGF0IDIxOjQ5ICswMTAwLCBBbGV4IERld2FyIHdyb3RlOg0KPiBJ biBpNDBlX2NsZWFuX3J4X2lycV96YygpLCB0aGUgdmFyaWFibGUgZmFpbHVyZSBpcyBvbmx5IHNl dCB3aGVuIGENCj4gY29uZGl0aW9uIGlzIG1ldCwgYnV0IHRoZW4gaXRzIHZhbHVlIGlzIHVzZWQg dW5jb25kaXRpb25hbGx5LiBGaXgNCj4gdGhpcy4NCj4gDQo+IEFkZHJlc3Nlcy1Db3Zlcml0eTog MTQ5Njk4NiAoIlVuaW5pdGlhbGl6ZWQgdmFsdWUiKQ0KPiBGaXhlczogOGNiZjc0MTQ5OTAzICgi aTQwZSwgeHNrOiBtb3ZlIGJ1ZmZlciBhbGxvY2F0aW9uIG91dCBvZiB0aGUgUngNCj4gcHJvY2Vz c2luZyBsb29wIikNCj4gU2lnbmVkLW9mZi1ieTogQWxleCBEZXdhciA8YWxleC5kZXdhcjkwQGdt YWlsLmNvbT4NCg0KVGhhbmtzIGZvciB0aGUgcGF0Y2ggQWxleCwgaG93ZXZlciwgRGFuIENhcnBl bnRlciBoYXMgYWxyZWFkeSBzdWJtaXR0ZWQNCmEgcGF0Y2ggZm9yIHRoZSBzYW1lIHJlcG9ydGVk IGlzc3VlOiANCmh0dHBzOi8vcGF0Y2h3b3JrLm96bGFicy5vcmcvcHJvamVjdC9pbnRlbC13aXJl ZC1sYW4vcGF0Y2gvMjAyMDA5MTYxNDMyMjguR0E3NjQzNzBAbXdhbmRhLw0KDQpUaGFua3MsDQpU b255DQo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nguyen, Anthony L Date: Thu, 17 Sep 2020 21:11:32 +0000 Subject: [Intel-wired-lan] [PATCH] i40e: Fix use of uninitialized variable In-Reply-To: <20200916204943.41017-1-alex.dewar90@gmail.com> References: <20200916204943.41017-1-alex.dewar90@gmail.com> Message-ID: <6aaa242f49ccd3824fe4cbb38bada7ccf9add979.camel@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: intel-wired-lan@osuosl.org List-ID: On Wed, 2020-09-16 at 21:49 +0100, Alex Dewar wrote: > In i40e_clean_rx_irq_zc(), the variable failure is only set when a > condition is met, but then its value is used unconditionally. Fix > this. > > Addresses-Coverity: 1496986 ("Uninitialized value") > Fixes: 8cbf74149903 ("i40e, xsk: move buffer allocation out of the Rx > processing loop") > Signed-off-by: Alex Dewar Thanks for the patch Alex, however, Dan Carpenter has already submitted a patch for the same reported issue: https://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200916143228.GA764370 at mwanda/ Thanks, Tony