From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 489D9C12002 for ; Wed, 14 Jul 2021 22:40:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 28EF5613C9 for ; Wed, 14 Jul 2021 22:40:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235626AbhGNWnm (ORCPT ); Wed, 14 Jul 2021 18:43:42 -0400 Received: from so254-9.mailgun.net ([198.61.254.9]:12997 "EHLO so254-9.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231394AbhGNWnl (ORCPT ); Wed, 14 Jul 2021 18:43:41 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1626302449; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=dN9FeDkip9Ae1ehWv6t+0cl0YVXUST9OaSt8TvUu8iE=; b=R4FVBNcWKqnhgznUJf0WvIJz4Kwe09Pm+tfnVryzHkOMOuZOAhf1qyU+eT7T+sUje076mLGh el0UOuTrqPh099JDEccEJgXQPIMt8RBXDcN6eCDENt9dqcqduRd2KwNlOj7rTud2cHfocVWN 1kqQKbY8TkqGnZQyq2t6oB4GtqY= X-Mailgun-Sending-Ip: 198.61.254.9 X-Mailgun-Sid: WyI1MzIzYiIsICJsaW51eC1hcm0tbXNtQHZnZXIua2VybmVsLm9yZyIsICJiZTllNGEiXQ== Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n01.prod.us-east-1.postgun.com with SMTP id 60ef67da38fa9bfe9c914189 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Wed, 14 Jul 2021 22:40:26 GMT Sender: abhinavk=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 00A38C43145; Wed, 14 Jul 2021 22:40:25 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: abhinavk) by smtp.codeaurora.org (Postfix) with ESMTPSA id BA39FC433F1; Wed, 14 Jul 2021 22:40:24 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 14 Jul 2021 15:40:24 -0700 From: abhinavk@codeaurora.org To: Sean Paul Cc: freedreno@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Rob Clark , Sean Paul , linux-arm-msm@vger.kernel.org Subject: Re: [Freedreno] [PATCH] drm/msm/dp: Initialize dp->aux->drm_dev before registration In-Reply-To: <20210714152910.55093-1-sean@poorly.run> References: <20210714152910.55093-1-sean@poorly.run> Message-ID: <6aaaf808dbde4d71170c06437800ed1b@codeaurora.org> X-Sender: abhinavk@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 2021-07-14 08:28, Sean Paul wrote: > From: Sean Paul > > Avoids the following WARN: > [ 3.009556] ------------[ cut here ]------------ > [ 3.014306] WARNING: CPU: 7 PID: 109 at > drivers/gpu/drm/drm_dp_helper.c:1796 drm_dp_aux_register+0xa4/0xac > [ 3.024209] Modules linked in: > [ 3.027351] CPU: 7 PID: 109 Comm: kworker/7:8 Not tainted 5.10.47 > #69 > [ 3.033958] Hardware name: Google Lazor (rev1 - 2) (DT) > [ 3.039323] Workqueue: events deferred_probe_work_func > [ 3.044596] pstate: 60c00009 (nZCv daif +PAN +UAO -TCO BTYPE=--) > [ 3.050761] pc : drm_dp_aux_register+0xa4/0xac > [ 3.055329] lr : dp_aux_register+0x40/0x88 > [ 3.059538] sp : ffffffc010ad3920 > [ 3.062948] x29: ffffffc010ad3920 x28: ffffffa64196ac70 > [ 3.067239] mmc1: Command Queue Engine enabled > [ 3.068406] x27: ffffffa64196ac68 x26: 0000000000000001 > [ 3.068407] x25: 0000000000000002 x24: 0000000000000060 > [ 3.068409] x23: ffffffa642ab3400 x22: ffffffe126c10e5b > [ 3.068410] x21: ffffffa641dc3188 x20: ffffffa641963c10 > [ 3.068412] x19: ffffffa642aba910 x18: 00000000ffff0a00 > [ 3.068414] x17: 000000476f8e002a x16: 00000000000000b8 > [ 3.073008] mmc1: new HS400 Enhanced strobe MMC card at address 0001 > [ 3.078448] x15: ffffffffffffffff x14: ffffffffffffffff > [ 3.078450] x13: 0000000000000030 x12: 0000000000000030 > [ 3.078452] x11: 0101010101010101 x10: ffffffe12647a914 > [ 3.078453] x9 : ffffffe12647a8cc x8 : 0000000000000000 > [ 3.084452] mmcblk1: mmc1:0001 DA4032 29.1 GiB > [ 3.089372] > [ 3.089372] x7 : 6c6064717372fefe x6 : ffffffa642b11494 > [ 3.089374] x5 : 0000000000000000 x4 : 6d006c657869ffff > [ 3.089375] x3 : 000000006c657869 x2 : 000000000000000c > [ 3.089376] x1 : ffffffe126c3ae3c x0 : ffffffa642aba910 > [ 3.089381] Call trace: > [ 3.094931] mmcblk1boot0: mmc1:0001 DA4032 partition 1 4.00 MiB > [ 3.100291] drm_dp_aux_register+0xa4/0xac > [ 3.100292] dp_aux_register+0x40/0x88 > [ 3.100294] dp_display_bind+0x64/0xcc > [ 3.100295] component_bind_all+0xdc/0x210 > [ 3.100298] msm_drm_bind+0x1e8/0x5d4 > [ 3.100301] try_to_bring_up_master+0x168/0x1b0 > [ 3.105861] mmcblk1boot1: mmc1:0001 DA4032 partition 2 4.00 MiB > [ 3.112282] __component_add+0xa0/0x158 > [ 3.112283] component_add+0x1c/0x28 > [ 3.112284] dp_display_probe+0x33c/0x380 > [ 3.112286] platform_drv_probe+0x9c/0xbc > [ 3.112287] really_probe+0x140/0x35c > [ 3.112289] driver_probe_device+0x84/0xc0 > [ 3.112292] __device_attach_driver+0x94/0xb0 > [ 3.117967] mmcblk1rpmb: mmc1:0001 DA4032 partition 3 16.0 MiB, > chardev (239:0) > [ 3.123201] bus_for_each_drv+0x8c/0xd8 > [ 3.123202] __device_attach+0xc4/0x150 > [ 3.123204] device_initial_probe+0x1c/0x28 > [ 3.123205] bus_probe_device+0x3c/0x9c > [ 3.123206] deferred_probe_work_func+0x90/0xcc > [ 3.123211] process_one_work+0x218/0x3ec > [ 3.131976] mmcblk1: p1 p2 p3 p4 p5 p6 p7 p8 p9 p10 p11 p12 > [ 3.134123] worker_thread+0x288/0x3e8 > [ 3.134124] kthread+0x148/0x1b0 > [ 3.134127] ret_from_fork+0x10/0x30 > [ 3.134128] ---[ end trace cfb9fce3f70f824d ]--- > > Signed-off-by: Sean Paul It looks like https://github.com/torvalds/linux/commit/6cba3fe433415b2549c909ce72601902c8254a83 is not yet present in the lazor codebase, once it gets backported we will hit the same issue, Hence Reviewed-by: Abhinav Kumar > --- > drivers/gpu/drm/msm/dp/dp_display.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/msm/dp/dp_display.c > b/drivers/gpu/drm/msm/dp/dp_display.c > index 051c1be1de7e..987f9e330138 100644 > --- a/drivers/gpu/drm/msm/dp/dp_display.c > +++ b/drivers/gpu/drm/msm/dp/dp_display.c > @@ -219,6 +219,7 @@ static int dp_display_bind(struct device *dev, > struct device *master, > goto end; > } > > + dp->aux->drm_dev = drm; > rc = dp_aux_register(dp->aux); > if (rc) { > DRM_ERROR("DRM DP AUX register failed\n"); From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 200C0C12002 for ; Wed, 14 Jul 2021 22:40:37 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DF35A61396 for ; Wed, 14 Jul 2021 22:40:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DF35A61396 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 60FB96E50C; Wed, 14 Jul 2021 22:40:36 +0000 (UTC) Received: from m43-7.mailgun.net (m43-7.mailgun.net [69.72.43.7]) by gabe.freedesktop.org (Postfix) with ESMTPS id 07E736E46B for ; Wed, 14 Jul 2021 22:40:32 +0000 (UTC) DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1626302434; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=dN9FeDkip9Ae1ehWv6t+0cl0YVXUST9OaSt8TvUu8iE=; b=n9vNadXzzvZD3zn578b/h7yVtDYyfMwRocvsB3fM24/+2GHfx79+pZ+z0BMumJd5gzfYndAx 6mbKIjPLr8zMkYtMZC+sNaDYIVMZw7rFGwCogFUS0ua2Yq0v2R/puPJU9KbInFwnH5ziOl4b FN/Elk24Uc+hsIP6tI/KGgEeH4g= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyJkOTU5ZSIsICJkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n01.prod.us-west-2.postgun.com with SMTP id 60ef67da25e56632782a76eb (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Wed, 14 Jul 2021 22:40:26 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id F066AC43217; Wed, 14 Jul 2021 22:40:25 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: abhinavk) by smtp.codeaurora.org (Postfix) with ESMTPSA id BA39FC433F1; Wed, 14 Jul 2021 22:40:24 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 14 Jul 2021 15:40:24 -0700 From: abhinavk@codeaurora.org To: Sean Paul Subject: Re: [Freedreno] [PATCH] drm/msm/dp: Initialize dp->aux->drm_dev before registration In-Reply-To: <20210714152910.55093-1-sean@poorly.run> References: <20210714152910.55093-1-sean@poorly.run> Message-ID: <6aaaf808dbde4d71170c06437800ed1b@codeaurora.org> X-Sender: abhinavk@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sean Paul , freedreno@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 2021-07-14 08:28, Sean Paul wrote: > From: Sean Paul > > Avoids the following WARN: > [ 3.009556] ------------[ cut here ]------------ > [ 3.014306] WARNING: CPU: 7 PID: 109 at > drivers/gpu/drm/drm_dp_helper.c:1796 drm_dp_aux_register+0xa4/0xac > [ 3.024209] Modules linked in: > [ 3.027351] CPU: 7 PID: 109 Comm: kworker/7:8 Not tainted 5.10.47 > #69 > [ 3.033958] Hardware name: Google Lazor (rev1 - 2) (DT) > [ 3.039323] Workqueue: events deferred_probe_work_func > [ 3.044596] pstate: 60c00009 (nZCv daif +PAN +UAO -TCO BTYPE=--) > [ 3.050761] pc : drm_dp_aux_register+0xa4/0xac > [ 3.055329] lr : dp_aux_register+0x40/0x88 > [ 3.059538] sp : ffffffc010ad3920 > [ 3.062948] x29: ffffffc010ad3920 x28: ffffffa64196ac70 > [ 3.067239] mmc1: Command Queue Engine enabled > [ 3.068406] x27: ffffffa64196ac68 x26: 0000000000000001 > [ 3.068407] x25: 0000000000000002 x24: 0000000000000060 > [ 3.068409] x23: ffffffa642ab3400 x22: ffffffe126c10e5b > [ 3.068410] x21: ffffffa641dc3188 x20: ffffffa641963c10 > [ 3.068412] x19: ffffffa642aba910 x18: 00000000ffff0a00 > [ 3.068414] x17: 000000476f8e002a x16: 00000000000000b8 > [ 3.073008] mmc1: new HS400 Enhanced strobe MMC card at address 0001 > [ 3.078448] x15: ffffffffffffffff x14: ffffffffffffffff > [ 3.078450] x13: 0000000000000030 x12: 0000000000000030 > [ 3.078452] x11: 0101010101010101 x10: ffffffe12647a914 > [ 3.078453] x9 : ffffffe12647a8cc x8 : 0000000000000000 > [ 3.084452] mmcblk1: mmc1:0001 DA4032 29.1 GiB > [ 3.089372] > [ 3.089372] x7 : 6c6064717372fefe x6 : ffffffa642b11494 > [ 3.089374] x5 : 0000000000000000 x4 : 6d006c657869ffff > [ 3.089375] x3 : 000000006c657869 x2 : 000000000000000c > [ 3.089376] x1 : ffffffe126c3ae3c x0 : ffffffa642aba910 > [ 3.089381] Call trace: > [ 3.094931] mmcblk1boot0: mmc1:0001 DA4032 partition 1 4.00 MiB > [ 3.100291] drm_dp_aux_register+0xa4/0xac > [ 3.100292] dp_aux_register+0x40/0x88 > [ 3.100294] dp_display_bind+0x64/0xcc > [ 3.100295] component_bind_all+0xdc/0x210 > [ 3.100298] msm_drm_bind+0x1e8/0x5d4 > [ 3.100301] try_to_bring_up_master+0x168/0x1b0 > [ 3.105861] mmcblk1boot1: mmc1:0001 DA4032 partition 2 4.00 MiB > [ 3.112282] __component_add+0xa0/0x158 > [ 3.112283] component_add+0x1c/0x28 > [ 3.112284] dp_display_probe+0x33c/0x380 > [ 3.112286] platform_drv_probe+0x9c/0xbc > [ 3.112287] really_probe+0x140/0x35c > [ 3.112289] driver_probe_device+0x84/0xc0 > [ 3.112292] __device_attach_driver+0x94/0xb0 > [ 3.117967] mmcblk1rpmb: mmc1:0001 DA4032 partition 3 16.0 MiB, > chardev (239:0) > [ 3.123201] bus_for_each_drv+0x8c/0xd8 > [ 3.123202] __device_attach+0xc4/0x150 > [ 3.123204] device_initial_probe+0x1c/0x28 > [ 3.123205] bus_probe_device+0x3c/0x9c > [ 3.123206] deferred_probe_work_func+0x90/0xcc > [ 3.123211] process_one_work+0x218/0x3ec > [ 3.131976] mmcblk1: p1 p2 p3 p4 p5 p6 p7 p8 p9 p10 p11 p12 > [ 3.134123] worker_thread+0x288/0x3e8 > [ 3.134124] kthread+0x148/0x1b0 > [ 3.134127] ret_from_fork+0x10/0x30 > [ 3.134128] ---[ end trace cfb9fce3f70f824d ]--- > > Signed-off-by: Sean Paul It looks like https://github.com/torvalds/linux/commit/6cba3fe433415b2549c909ce72601902c8254a83 is not yet present in the lazor codebase, once it gets backported we will hit the same issue, Hence Reviewed-by: Abhinav Kumar > --- > drivers/gpu/drm/msm/dp/dp_display.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/msm/dp/dp_display.c > b/drivers/gpu/drm/msm/dp/dp_display.c > index 051c1be1de7e..987f9e330138 100644 > --- a/drivers/gpu/drm/msm/dp/dp_display.c > +++ b/drivers/gpu/drm/msm/dp/dp_display.c > @@ -219,6 +219,7 @@ static int dp_display_bind(struct device *dev, > struct device *master, > goto end; > } > > + dp->aux->drm_dev = drm; > rc = dp_aux_register(dp->aux); > if (rc) { > DRM_ERROR("DRM DP AUX register failed\n");