From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 397BFC43387 for ; Mon, 24 Dec 2018 07:47:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 119DF20578 for ; Mon, 24 Dec 2018 07:47:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726820AbeLXHrM (ORCPT ); Mon, 24 Dec 2018 02:47:12 -0500 Received: from gateway33.websitewelcome.com ([192.185.146.21]:17131 "EHLO gateway33.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725984AbeLXHrL (ORCPT ); Mon, 24 Dec 2018 02:47:11 -0500 Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway33.websitewelcome.com (Postfix) with ESMTP id 1C27A5C130 for ; Mon, 24 Dec 2018 01:47:10 -0600 (CST) Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with SMTP id bKxCgL68t2PzObKxCg45Eq; Mon, 24 Dec 2018 01:47:10 -0600 X-Authority-Reason: nr=8 Received: from [189.250.106.44] (port=37996 helo=[192.168.1.76]) by gator4166.hostgator.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.91) (envelope-from ) id 1gbKwZ-000wzP-Gu; Mon, 24 Dec 2018 01:47:09 -0600 Subject: Re: [PATCH] mlxsw: spectrum_acl_bloom_filter: use struct_size() in kzalloc() To: Ido Schimmel Cc: Jiri Pirko , Ido Schimmel , "David S. Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20181224052741.GA22098@embeddedor.com> <20181224073838.GA11051@splinter> From: "Gustavo A. R. Silva" Message-ID: <6ab7cfc8-7fc0-523a-70f6-a6701ad691b3@embeddedor.com> Date: Mon, 24 Dec 2018 01:46:28 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20181224073838.GA11051@splinter> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 189.250.106.44 X-Source-L: No X-Exim-ID: 1gbKwZ-000wzP-Gu X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: ([192.168.1.76]) [189.250.106.44]:37996 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 6 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/24/18 1:38 AM, Ido Schimmel wrote: > On Sun, Dec 23, 2018 at 11:27:41PM -0600, Gustavo A. R. Silva wrote: >> One of the more common cases of allocation size calculations is finding >> the size of a structure that has a zero-sized array at the end, along >> with memory for some number of elements for that array. For example: >> >> struct foo { >> int stuff; >> void *entry[]; >> }; >> >> instance = kzalloc(sizeof(struct foo) + sizeof(void *) * count, GFP_KERNEL); >> >> Instead of leaving these open-coded and prone to type mistakes, we can >> now use the new struct_size() helper: >> >> instance = kzalloc(struct_size(instance, entry, count), GFP_KERNEL); >> >> This issue was detected with the help of Coccinelle. >> >> Signed-off-by: Gustavo A. R. Silva > > Reviewed-by: Ido Schimmel > > But net-next is closed (http://vger.kernel.org/~davem/net-next.html) and > this isn't a bug fix. Can you please re-submit when net-next opens > again? Alternatively, I can apply the patch to my mlxsw queue and submit > in your stead. Let me know what you prefer. > Oh yeah. I forgot net close net-next during the merge window. I'll re-submit it in two weeks then. I'll add your Reviewed-by. Happy holiday. Thanks -- Gustavo