From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH v3] drivers: advertise kmod dependencies in pmdinfo Date: Thu, 22 Dec 2016 12:07:44 +0000 Message-ID: <6abf05af-a834-d9b6-ea67-9e2d250539fe@intel.com> References: <1479808257-8725-1-git-send-email-olivier.matz@6wind.com> <1481809599-27896-1-git-send-email-olivier.matz@6wind.com> <20161216082332.GB10340@6wind.com> <2489002.JyIsi2jNCp@xps13> <96cb80d2-d0ff-b233-3e0a-226f0ec6109a@solarflare.com> <20161221113702.GA23197@hmsreliant.think-freely.org> <5c8a65d6-79a8-fbbe-29d6-bee5c08be17b@solarflare.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: Thomas Monjalon , Olivier Matz , Adrien Mazarguil , dev@dpdk.org, vido@cesnet.cz, fiona.trahe@intel.com, stephen@networkplumber.org To: Andrew Rybchenko , Neil Horman Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id F04D710D31 for ; Thu, 22 Dec 2016 13:07:47 +0100 (CET) In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 12/22/2016 11:35 AM, Andrew Rybchenko wrote: > On 12/22/2016 02:04 PM, Ferruh Yigit wrote: >> On 12/21/2016 11:40 AM, Andrew Rybchenko wrote: >>> On 12/21/2016 02:37 PM, Neil Horman wrote: >>>> On Wed, Dec 21, 2016 at 12:21:14PM +0300, Andrew Rybchenko wrote: >>>>> On 12/20/2016 08:26 PM, Thomas Monjalon wrote: >>>>>>>> Add a new macro RTE_PMD_REGISTER_KMOD_DEP() that allows a driver to >>>>>>>> declare the list of kernel modules required to run properly. >>>>>>>> >>>>>>>> Today, most PCI drivers require uio/vfio. >>>>>>>> >>>>>>>> Signed-off-by: Olivier Matz >>>>>>>> Acked-by: Fiona Trahe >>>>>>> Acked-by: Adrien Mazarguil >>>>>> Applied in main tree, thanks >>>>> Is there any plan on how it will be done/solved for a new drivers in >>>>> dpdk-next-net? >>>>> Should I care about it for sfc? >>>>> >>>> Given that all pmdinfo information is opt-in (that is to say not obligatory), >>>> you can now wait until net-next does its next rebase, and as you continue your >>>> development of the sfc driver, you can add the use of this macro in at your >>>> leisure. As more people do that, we will arrive at 100% coverage >>> I see. Will do. Thanks. >>> >> Hi Andrew, >> >> Patch rebased to next-net, would you mind doing the mentioned patch for it? > > Hi Ferruh, > > done. I was in doubts which changeset to specify in fixes, but finally > chosen the latest from mine and Olivier's. Please, correct me, if it is > wrong. I think no fixes line required here, this patch is not fixing a defect, but adding a new support for a pmdinfo tool. I can remove fixes line while applying. Thanks, ferruh > > Andrew. >