Re: [PATCH 1/3] dbus-test: Fix QA host-contamination errors

From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Khem Raj <raj.khem@gmail.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 1/3] dbus-test: Fix QA host-contamination errors
Date: Sun, 01 Mar 2020 08:20:33 +0000	[thread overview]
Message-ID: <6ac648b5b9d02cb857e9d784d7bf95e071567ca1.camel@linuxfoundation.org> (raw)
In-Reply-To: <CAMKF1sqVqVDgUac2+G6VX4GmvD7+ecF9HzO731s=OsrWESk+dg@mail.gmail.com>

On Sun, 2020-03-01 at 00:17 -0800, Khem Raj wrote:
> 
> 
> On Sun, Mar 1, 2020 at 12:14 AM Richard Purdie <
> richard.purdie@linuxfoundation.org> wrote:
> > On Sun, 2020-03-01 at 00:12 -0800, Khem Raj wrote:
> > > 
> > > 
> > > On Sat, Feb 29, 2020 at 11:57 PM Richard Purdie <
> > > richard.purdie@linuxfoundation.org> wrote:
> > > > On Sat, 2020-02-29 at 17:42 -0800, Khem Raj wrote:
> > > > > Errors like below are fixed
> > > > > 
> > > > > bus/connection.h is owned by uid 1000, which is the same as t
> > > > > he user running bitbake. This may be due to host
> > contamination
> > > > > 
> > > > > Signed-off-by: Khem Raj <raj.khem@gmail.com>
> > > > > ---
> > > > >  meta/recipes-core/dbus/dbus-test_1.12.16.bb | 4 ++--
> > > > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > > > 
> > > > Why aren't we seeing this everywhere? The autobuilders don't
> > show
> > > > it
> > > > and no other reports. What is unique to your setup to reproduce
> > > > this?
> > > 
> > > These are QA warnings by default and in my distro I turned it
> > into
> > > error so they were being reported before too 
> > 
> > The autobuilder would show any warnings or errors and we're not
> > seeing
> > either.
> > 
> > > Secondly this is a Debian10 minimum container running in docker
> > where
> > > the user id is 1000 for the build user other than that there is
> > > nothing special 
> > 
> > We run debian10 builders on the autobuilder.
> > 
> > I just don't understand why weren't not seeing this everywhere. We
> > really need to understand why this is :/.
> 
> From what you see from fixes what it’s reporting are legit errors 
> Why it’s not showing up everywhere I am not sure
> I don’t see it on Ubuntu 18.04 boxes without docker as well 

I understand the need for the fixes, I'm just very concerned we have
what amounts to undetected non-determinism in the build :(

I'm more concerned about fixing that (and ensuring we can detect/fix
all cases) than I am about the individual errors.

Cheers,

Richard