From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37054C7618A for ; Mon, 20 Mar 2023 05:38:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229548AbjCTFiD (ORCPT ); Mon, 20 Mar 2023 01:38:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34206 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229449AbjCTFiC (ORCPT ); Mon, 20 Mar 2023 01:38:02 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 9E27E6EBA; Sun, 19 Mar 2023 22:38:00 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 848C9FEC; Sun, 19 Mar 2023 22:38:43 -0700 (PDT) Received: from [10.162.41.7] (a077893.blr.arm.com [10.162.41.7]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 61EE93F67D; Sun, 19 Mar 2023 22:37:54 -0700 (PDT) Message-ID: <6ac7d093-b11c-b37f-8058-72c8d41fba73@arm.com> Date: Mon, 20 Mar 2023 11:07:51 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 6/7] of/platform: Skip coresight etm4x devices from AMBA bus Content-Language: en-US To: Suzuki K Poulose , Rob Herring Cc: linux-arm-kernel@lists.infradead.org, coresight@lists.linaro.org, scclevenger@os.amperecomputing.com, Frank Rowand , Russell King , Greg Kroah-Hartman , "Rafael J. Wysocki" , Len Brown , Sudeep Holla , Lorenzo Pieralisi , Mathieu Poirier , Mike Leach , Leo Yan , devicetree@vger.kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230317030501.1811905-1-anshuman.khandual@arm.com> <20230317030501.1811905-7-anshuman.khandual@arm.com> From: Anshuman Khandual In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On 3/17/23 21:33, Suzuki K Poulose wrote: >>>   drivers/of/platform.c | 10 +++++++++- >>>   1 file changed, 9 insertions(+), 1 deletion(-) >>> >>> diff --git a/drivers/of/platform.c b/drivers/of/platform.c >>> index b2bd2e783445..59ff1a38ccaa 100644 >>> --- a/drivers/of/platform.c >>> +++ b/drivers/of/platform.c >>> @@ -325,6 +325,13 @@ static const struct of_dev_auxdata *of_dev_lookup(const struct of_dev_auxdata *l >>>          return NULL; >>>   } >>> >>> +static const struct of_device_id of_ignore_amba_table[] = { >>> +#ifdef CONFIG_CORESIGHT_SOURCE_ETM4X >>> +       { .compatible = "arm,coresight-etm4x" }, >>> +#endif >>> +       {}    /* NULL terminated */ >>> +}; >>> + >>>   /** >>>    * of_platform_bus_create() - Create a device for a node and its children. >>>    * @bus: device node of the bus to instantiate >>> @@ -373,7 +380,8 @@ static int of_platform_bus_create(struct device_node *bus, >>>                  platform_data = auxdata->platform_data; >>>          } >>> >>> -       if (of_device_is_compatible(bus, "arm,primecell")) { >>> +       if (of_device_is_compatible(bus, "arm,primecell") && >>> +           unlikely(!of_match_node(of_ignore_amba_table, bus))) { >> >> of_match_node is going to take orders of magnitude longer than any >> difference unlikely() would make. Drop it. > > Agreed. Sure, will drop the unlikely() here. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 99192C7618A for ; Mon, 20 Mar 2023 05:39:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=sfPOM4ys1nN3oOYVfjRv4FV+3+M0rzC9WaamfZrzQrg=; b=nWOVi5ZV6Vwo2P yn26TJYlsxZDhQldYU+rOrFf/xD51h/7t78q/75sSjZo1Qxy/IpVhd5QMP4aWL18YbkpJlywEwJAA RnEW8L3v4R5heERIL6k/stxoWFQnXNqs7h7uMN3azuwp6nhxbguhysyyIxWb9hNbIBefbkvBO9oc8 9MLCNWhHKAOZaE0E5TZAjdh77hOlGoI64MmQemVBo5v8Z0nMRX2CXKlf9xBT7sew6k3w+JpSDejwx S7WRV6YV58b3cr6m86aNVhf66C4TpBO1bl10CAwoJ0RA4XZjalrg8Y8Gnji/vuoJEc7ePaQP/RrDF wwd3lRQjL8w72xVAUR2A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pe8Dh-008BV9-0G; Mon, 20 Mar 2023 05:38:09 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pe8Dd-008BUM-3D for linux-arm-kernel@lists.infradead.org; Mon, 20 Mar 2023 05:38:07 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 848C9FEC; Sun, 19 Mar 2023 22:38:43 -0700 (PDT) Received: from [10.162.41.7] (a077893.blr.arm.com [10.162.41.7]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 61EE93F67D; Sun, 19 Mar 2023 22:37:54 -0700 (PDT) Message-ID: <6ac7d093-b11c-b37f-8058-72c8d41fba73@arm.com> Date: Mon, 20 Mar 2023 11:07:51 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 6/7] of/platform: Skip coresight etm4x devices from AMBA bus Content-Language: en-US To: Suzuki K Poulose , Rob Herring Cc: linux-arm-kernel@lists.infradead.org, coresight@lists.linaro.org, scclevenger@os.amperecomputing.com, Frank Rowand , Russell King , Greg Kroah-Hartman , "Rafael J. Wysocki" , Len Brown , Sudeep Holla , Lorenzo Pieralisi , Mathieu Poirier , Mike Leach , Leo Yan , devicetree@vger.kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230317030501.1811905-1-anshuman.khandual@arm.com> <20230317030501.1811905-7-anshuman.khandual@arm.com> From: Anshuman Khandual In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230319_223806_087524_C17BD274 X-CRM114-Status: GOOD ( 11.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org CgpPbiAzLzE3LzIzIDIxOjMzLCBTdXp1a2kgSyBQb3Vsb3NlIHdyb3RlOgo+Pj4gwqAgZHJpdmVy cy9vZi9wbGF0Zm9ybS5jIHwgMTAgKysrKysrKysrLQo+Pj4gwqAgMSBmaWxlIGNoYW5nZWQsIDkg aW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQo+Pj4KPj4+IGRpZmYgLS1naXQgYS9kcml2ZXJz L29mL3BsYXRmb3JtLmMgYi9kcml2ZXJzL29mL3BsYXRmb3JtLmMKPj4+IGluZGV4IGIyYmQyZTc4 MzQ0NS4uNTlmZjFhMzhjY2FhIDEwMDY0NAo+Pj4gLS0tIGEvZHJpdmVycy9vZi9wbGF0Zm9ybS5j Cj4+PiArKysgYi9kcml2ZXJzL29mL3BsYXRmb3JtLmMKPj4+IEBAIC0zMjUsNiArMzI1LDEzIEBA IHN0YXRpYyBjb25zdCBzdHJ1Y3Qgb2ZfZGV2X2F1eGRhdGEgKm9mX2Rldl9sb29rdXAoY29uc3Qg c3RydWN0IG9mX2Rldl9hdXhkYXRhICpsCj4+PiDCoMKgwqDCoMKgwqDCoMKgIHJldHVybiBOVUxM Owo+Pj4gwqAgfQo+Pj4KPj4+ICtzdGF0aWMgY29uc3Qgc3RydWN0IG9mX2RldmljZV9pZCBvZl9p Z25vcmVfYW1iYV90YWJsZVtdID0gewo+Pj4gKyNpZmRlZiBDT05GSUdfQ09SRVNJR0hUX1NPVVJD RV9FVE00WAo+Pj4gK8KgwqDCoMKgwqDCoCB7IC5jb21wYXRpYmxlID0gImFybSxjb3Jlc2lnaHQt ZXRtNHgiIH0sCj4+PiArI2VuZGlmCj4+PiArwqDCoMKgwqDCoMKgIHt9wqDCoMKgIC8qIE5VTEwg dGVybWluYXRlZCAqLwo+Pj4gK307Cj4+PiArCj4+PiDCoCAvKioKPj4+IMKgwqAgKiBvZl9wbGF0 Zm9ybV9idXNfY3JlYXRlKCkgLSBDcmVhdGUgYSBkZXZpY2UgZm9yIGEgbm9kZSBhbmQgaXRzIGNo aWxkcmVuLgo+Pj4gwqDCoCAqIEBidXM6IGRldmljZSBub2RlIG9mIHRoZSBidXMgdG8gaW5zdGFu dGlhdGUKPj4+IEBAIC0zNzMsNyArMzgwLDggQEAgc3RhdGljIGludCBvZl9wbGF0Zm9ybV9idXNf Y3JlYXRlKHN0cnVjdCBkZXZpY2Vfbm9kZSAqYnVzLAo+Pj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqAgcGxhdGZvcm1fZGF0YSA9IGF1eGRhdGEtPnBsYXRmb3JtX2RhdGE7Cj4+PiDC oMKgwqDCoMKgwqDCoMKgIH0KPj4+Cj4+PiAtwqDCoMKgwqDCoMKgIGlmIChvZl9kZXZpY2VfaXNf Y29tcGF0aWJsZShidXMsICJhcm0scHJpbWVjZWxsIikpIHsKPj4+ICvCoMKgwqDCoMKgwqAgaWYg KG9mX2RldmljZV9pc19jb21wYXRpYmxlKGJ1cywgImFybSxwcmltZWNlbGwiKSAmJgo+Pj4gK8Kg wqDCoMKgwqDCoMKgwqDCoMKgIHVubGlrZWx5KCFvZl9tYXRjaF9ub2RlKG9mX2lnbm9yZV9hbWJh X3RhYmxlLCBidXMpKSkgewo+Pgo+PiBvZl9tYXRjaF9ub2RlIGlzIGdvaW5nIHRvIHRha2Ugb3Jk ZXJzIG9mIG1hZ25pdHVkZSBsb25nZXIgdGhhbiBhbnkKPj4gZGlmZmVyZW5jZSB1bmxpa2VseSgp IHdvdWxkIG1ha2UuIERyb3AgaXQuCj4gCj4gQWdyZWVkLgoKU3VyZSwgd2lsbCBkcm9wIHRoZSB1 bmxpa2VseSgpIGhlcmUuCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxp c3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0 aW5mby9saW51eC1hcm0ta2VybmVsCg==