From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by smtp.lore.kernel.org (Postfix) with ESMTP id 459BDC433F5 for ; Thu, 26 May 2022 06:01:29 +0000 (UTC) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8F75A42684; Thu, 26 May 2022 08:01:28 +0200 (CEST) Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by mails.dpdk.org (Postfix) with ESMTP id ADB4540DF7 for ; Thu, 26 May 2022 08:01:26 +0200 (CEST) Received: from kwepemi500012.china.huawei.com (unknown [172.30.72.53]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4L7y0b6HkbzQk8W; Thu, 26 May 2022 13:58:23 +0800 (CST) Received: from [10.67.103.128] (10.67.103.128) by kwepemi500012.china.huawei.com (7.221.188.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Thu, 26 May 2022 14:01:24 +0800 Subject: Re: [PATCH v2] app/procinfo: add devcie private info dump To: "Pattan, Reshma" , "dev@dpdk.org" CC: "Yigit, Ferruh" , "stephen@networkplumber.org" , "thomas@monjalon.net" , "maryam.tahhan@intel.com" References: <20220219015916.46347-1-humin29@huawei.com> <20220221022412.47258-1-humin29@huawei.com> From: "Min Hu (Connor)" Message-ID: <6ad421a6-75b6-e5f3-6a4b-52e7b5e65124@huawei.com> Date: Thu, 26 May 2022 14:01:24 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="gbk"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.103.128] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To kwepemi500012.china.huawei.com (7.221.188.12) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi, Pattan, V3 has been sent, thanks ÔÚ 2022/5/25 22:33, Pattan, Reshma дµÀ: > > > >> -----Original Message----- >> From: Min Hu (Connor) >> Subject: [PATCH v2] app/procinfo: add devcie private info dump > > Typo: device* > >> +static void >> +show_port_private_info(void) >> +{ >> + int i; >> + >> + snprintf(bdr_str, MAX_STRING_LEN, " show - Port PMD Private "); > > Better to have header message to be "Dump - Ports private information" > > Looks ok to me. > > Acked-by: Reshma Pattan > > . >