From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Ed Czeck <ed.czeck@atomicrules.com>, dev@dpdk.org
Cc: john.miller@atomicrules.com, shepard.siegel@atomicrules.com,
stephen@networkplumber.org
Subject: Re: [PATCH v5 6/7] net/ark: Packet RX support initial version
Date: Tue, 28 Mar 2017 15:36:02 +0100 [thread overview]
Message-ID: <6ae0faec-be5e-9054-0cc0-fb5300bb2f75@intel.com> (raw)
In-Reply-To: <8a5f46f851c7be85e09e50d7c94b7709edaf881e.1490309515.git.ed.czeck@atomicrules.com>
On 3/23/2017 11:01 PM, Ed Czeck wrote:
> * Core RX packet moving functions
>
> Signed-off-by: Ed Czeck <ed.czeck@atomicrules.com>
<...>
> +/* TODO pick a better function name */
Is it possible to do now :) Thanks.
> +static int
> +eth_ark_rx_hw_setup(struct rte_eth_dev *dev,
> + struct ark_rx_queue *queue,
> + uint16_t rx_queue_id __rte_unused, uint16_t rx_queue_idx)
> +{
<...>
> +
> +/* Only used in debug */
> +static void
> +dump_mbuf_data(struct rte_mbuf *mbuf, uint16_t lo, uint16_t hi)
> +{
There is already a rte_pktmbuf_dump(), does it works for you?
<...>
> +/* Forward declarations */
> +struct rte_mbuf;
> +struct rte_mempool;
> +struct rte_eth_dev;
> +struct rte_eth_stats;
> +struct rte_eth_rxconf;
Same comment with Tx patch, these structs can be removed by including
proper dpdk headers.
next prev parent reply other threads:[~2017-03-28 14:36 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-23 1:03 [PATCH v4 1/7] net/ark: PMD for Atomic Rules Arkville driver stub Ed Czeck
2017-03-23 1:03 ` [PATCH v4 2/7] net/ark: HW API part 1 of 3 Ed Czeck
2017-03-23 11:38 ` Ferruh Yigit
2017-03-23 20:33 ` Ed Czeck
2017-03-29 1:05 ` [PATCH v6 2/7] net/ark: Provide API for hardware modules mpu, rqp, and pktdir Ed Czeck
2017-03-29 21:32 ` [PATCH v7 2/7] net/ark: provide API for hardware modules mpu rqp " Ed Czeck
2017-04-04 19:50 ` [PATCH v8 " Ed Czeck
2017-03-23 1:03 ` [PATCH v4 3/7] net/ark: HW API part 2 of 3 Ed Czeck
2017-03-29 1:05 ` [PATCH v6 3/7] net/ark: Provide API for hardware modules udm and ddm Ed Czeck
2017-03-29 21:33 ` [PATCH v7 3/7] net/ark: provide " Ed Czeck
2017-04-04 19:50 ` [PATCH v8 " Ed Czeck
2017-03-23 1:03 ` [PATCH v4 4/7] net/ark: HW API part 3 of 3 Ed Czeck
2017-03-29 1:06 ` [PATCH v6 4/7] net/ark: Provide API for hardware modules pktchkr and pktgen Ed Czeck
2017-03-29 21:34 ` [PATCH v7 4/7] net/ark: provide " Ed Czeck
2017-04-04 19:50 ` [PATCH v8 " Ed Czeck
2017-03-23 1:03 ` [PATCH v4 5/7] net/ark: Packet TX support initial version Ed Czeck
2017-03-23 12:14 ` Ferruh Yigit
2017-03-23 21:44 ` Ed Czeck
2017-03-29 1:06 ` [PATCH v6 " Ed Czeck
2017-03-29 21:34 ` [PATCH v7 5/7] net/ark: packet Tx " Ed Czeck
2017-04-04 19:51 ` [PATCH v8 " Ed Czeck
2017-03-23 1:03 ` [PATCH v4 6/7] net/ark: Packet RX " Ed Czeck
2017-03-23 12:14 ` Ferruh Yigit
2017-03-23 21:51 ` Ed Czeck
2017-03-29 1:06 ` [PATCH v6 " Ed Czeck
2017-03-29 21:35 ` [PATCH v7 6/7] net/ark: packet Rx " Ed Czeck
2017-04-04 19:51 ` [PATCH v8 " Ed Czeck
2017-03-23 1:03 ` [PATCH v4 7/7] net/ark: Arkville PMD component integration Ed Czeck
2017-03-23 12:13 ` Ferruh Yigit
2017-03-23 22:19 ` Ed Czeck
2017-03-28 12:34 ` Ferruh Yigit
2017-03-29 1:07 ` [PATCH v6 " Ed Czeck
2017-03-29 9:54 ` Ferruh Yigit
2017-03-29 21:35 ` [PATCH v7 7/7] net/ark: arkville " Ed Czeck
2017-04-04 19:51 ` [PATCH v8 " Ed Czeck
2017-03-23 11:36 ` [PATCH v4 1/7] net/ark: PMD for Atomic Rules Arkville driver stub Ferruh Yigit
2017-03-23 13:08 ` Ferruh Yigit
2017-03-23 19:46 ` Ed Czeck
2017-03-28 12:58 ` Ferruh Yigit
2017-03-28 21:11 ` Ed Czeck
2017-03-29 9:42 ` Ferruh Yigit
2017-03-23 22:59 ` [PATCH v5 " Ed Czeck
2017-03-23 23:00 ` [PATCH v5 2/7] net/ark: provide api to hardware module mpu, rqp, and pktdir Ed Czeck
2017-03-28 14:35 ` Ferruh Yigit
2017-03-28 20:14 ` Ed Czeck
2017-03-23 23:00 ` [PATCH v5 3/7] net/ark: provide API hardware module udm and ddm Ed Czeck
2017-03-23 23:00 ` [PATCH v5 4/7] net/ark: prrovide api for hardware module pktchkr and pktgen Ed Czeck
2017-03-23 23:00 ` [PATCH v5 5/7] net/ark: Packet TX support initial version Ed Czeck
2017-03-23 23:01 ` [PATCH v5 6/7] net/ark: Packet RX " Ed Czeck
2017-03-28 14:36 ` Ferruh Yigit [this message]
2017-03-28 21:59 ` Ed Czeck
2017-03-23 23:01 ` [PATCH v5 7/7] net/ark: Arkville PMD component integration Ed Czeck
2017-03-28 14:38 ` Ferruh Yigit
2017-03-28 15:00 ` Adrien Mazarguil
2017-03-28 22:42 ` Ed Czeck
2017-03-28 14:34 ` [PATCH v5 1/7] net/ark: PMD for Atomic Rules Arkville driver stub Ferruh Yigit
2017-03-28 22:38 ` Ed Czeck
2017-03-28 14:41 ` Ferruh Yigit
2017-03-29 1:04 ` [PATCH v6 " Ed Czeck
2017-03-29 21:32 ` [PATCH v7 1/7] net/ark: stub PMD for Atomic Rules Arkville Ed Czeck
2017-03-31 14:51 ` Ferruh Yigit
2017-03-31 15:09 ` Shepard Siegel
2017-04-04 20:58 ` Ed Czeck
2017-04-04 19:50 ` [PATCH v8 " Ed Czeck
2017-04-07 10:54 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ae0faec-be5e-9054-0cc0-fb5300bb2f75@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=ed.czeck@atomicrules.com \
--cc=john.miller@atomicrules.com \
--cc=shepard.siegel@atomicrules.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.