From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A27BC2D0A3 for ; Thu, 12 Nov 2020 09:52:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C78F722210 for ; Thu, 12 Nov 2020 09:52:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727799AbgKLJwF (ORCPT ); Thu, 12 Nov 2020 04:52:05 -0500 Received: from foss.arm.com ([217.140.110.172]:45634 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725979AbgKLJwF (ORCPT ); Thu, 12 Nov 2020 04:52:05 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 54D9E139F; Thu, 12 Nov 2020 01:52:04 -0800 (PST) Received: from [10.37.12.33] (unknown [10.37.12.33]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 47B643F73C; Thu, 12 Nov 2020 01:52:01 -0800 (PST) Subject: Re: [PATCH v9 32/44] arm64: mte: Switch GCR_EL1 in kernel entry and exit To: Catalin Marinas Cc: Andrey Konovalov , Will Deacon , Dmitry Vyukov , Andrey Ryabinin , Alexander Potapenko , Marco Elver , Evgenii Stepanov , Branislav Rankov , Kevin Brodsky , Andrew Morton , kasan-dev@googlegroups.com, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <25401c15dc19c7b672771f5b49a208d6e77bfeb5.1605046192.git.andreyknvl@google.com> <20201112093908.GE29613@gaia> <20201112094553.GG29613@gaia> From: Vincenzo Frascino Message-ID: <6aec6a77-f9b0-cf73-6bf3-4f8df8f8cd13@arm.com> Date: Thu, 12 Nov 2020 09:55:05 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201112094553.GG29613@gaia> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/12/20 9:45 AM, Catalin Marinas wrote: > On Thu, Nov 12, 2020 at 09:45:45AM +0000, Vincenzo Frascino wrote: >> On 11/12/20 9:39 AM, Catalin Marinas wrote: >>> On Tue, Nov 10, 2020 at 11:10:29PM +0100, Andrey Konovalov wrote: >>>> diff --git a/arch/arm64/kernel/mte.c b/arch/arm64/kernel/mte.c >>>> index 664c968dc43c..dbda6598c19d 100644 >>>> --- a/arch/arm64/kernel/mte.c >>>> +++ b/arch/arm64/kernel/mte.c >>>> @@ -129,6 +131,26 @@ void *mte_set_mem_tag_range(void *addr, size_t size, u8 tag) >>>> return ptr; >>>> } >>>> >>>> +void mte_init_tags(u64 max_tag) >>>> +{ >>>> + static bool gcr_kernel_excl_initialized = false; >>>> + >>>> + if (!gcr_kernel_excl_initialized) { >>>> + /* >>>> + * The format of the tags in KASAN is 0xFF and in MTE is 0xF. >>>> + * This conversion extracts an MTE tag from a KASAN tag. >>>> + */ >>>> + u64 incl = GENMASK(FIELD_GET(MTE_TAG_MASK >> MTE_TAG_SHIFT, >>>> + max_tag), 0); >>>> + >>>> + gcr_kernel_excl = ~incl & SYS_GCR_EL1_EXCL_MASK; >>>> + gcr_kernel_excl_initialized = true; >>>> + } >>>> + >>>> + /* Enable the kernel exclude mask for random tags generation. */ >>>> + write_sysreg_s(SYS_GCR_EL1_RRND | gcr_kernel_excl, SYS_GCR_EL1); >>>> +} >>> >>> I don't think this function belongs to this patch. There is an earlier >>> patch that talks about mte_init_tags() but no trace of it until this >>> patch. >> >> Could you please point out to which patch are you referring to? > > I replied to it already (or you can search ;)). But this patch is about > switching GCR_EL1 on exception entry/exit rather than setting up the > initial kernel GCR_EL1 value. > Temporally after I asked ;) (I give you the benefit of delay of the mail server ;) ). I think that during the development the logic changed a bit, but I agree that the comments are outdated. I am fine to move the code. -- Regards, Vincenzo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B4ABC2D0A3 for ; Thu, 12 Nov 2020 09:53:11 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 162022220B for ; Thu, 12 Nov 2020 09:53:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="CnX0jUS6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 162022220B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=vOUUSdobXJYkR07VfoCZZVe9pfZYq4fLwqErDSwcw9o=; b=CnX0jUS6gG8SeXsC06OJ/DIpr fbJyJkzj90w8Qee2ZazYRa8ArkywZ57qxUTop3qnycqjGsXObFC1OWzA25KVxeZ5vtZYUeBeBsIKS 8+cjRYWQnJrGvvlAKXYR4ULsNa5fVaEuJbaVfFqkqZvsyM+d/c5l8TfipU/xrRA/8leKXRdwjVeai gCyWSXL61fOMiY66NAWDKw4Y7ZM+ML1c2QhwjpKZq+jv1L1gwD9tUoL2SZIfCFGo4zUsrRMSZiEtx R8HoNt/iGzV7Hau50xxMmbkO4CMnGubNUBeKpXb00+GQEQUHHlLoZQ0v4xs/VeeXifCzgRca9DuLF PogXlGCNg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kd9Gx-0007B1-MM; Thu, 12 Nov 2020 09:52:07 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kd9Gv-0007AG-QA for linux-arm-kernel@lists.infradead.org; Thu, 12 Nov 2020 09:52:06 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 54D9E139F; Thu, 12 Nov 2020 01:52:04 -0800 (PST) Received: from [10.37.12.33] (unknown [10.37.12.33]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 47B643F73C; Thu, 12 Nov 2020 01:52:01 -0800 (PST) Subject: Re: [PATCH v9 32/44] arm64: mte: Switch GCR_EL1 in kernel entry and exit To: Catalin Marinas References: <25401c15dc19c7b672771f5b49a208d6e77bfeb5.1605046192.git.andreyknvl@google.com> <20201112093908.GE29613@gaia> <20201112094553.GG29613@gaia> From: Vincenzo Frascino Message-ID: <6aec6a77-f9b0-cf73-6bf3-4f8df8f8cd13@arm.com> Date: Thu, 12 Nov 2020 09:55:05 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201112094553.GG29613@gaia> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201112_045205_920612_5BF149DB X-CRM114-Status: GOOD ( 19.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, Marco Elver , Andrey Konovalov , Kevin Brodsky , Will Deacon , Branislav Rankov , kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Alexander Potapenko , Evgenii Stepanov , Andrey Ryabinin , Andrew Morton , Dmitry Vyukov Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 11/12/20 9:45 AM, Catalin Marinas wrote: > On Thu, Nov 12, 2020 at 09:45:45AM +0000, Vincenzo Frascino wrote: >> On 11/12/20 9:39 AM, Catalin Marinas wrote: >>> On Tue, Nov 10, 2020 at 11:10:29PM +0100, Andrey Konovalov wrote: >>>> diff --git a/arch/arm64/kernel/mte.c b/arch/arm64/kernel/mte.c >>>> index 664c968dc43c..dbda6598c19d 100644 >>>> --- a/arch/arm64/kernel/mte.c >>>> +++ b/arch/arm64/kernel/mte.c >>>> @@ -129,6 +131,26 @@ void *mte_set_mem_tag_range(void *addr, size_t size, u8 tag) >>>> return ptr; >>>> } >>>> >>>> +void mte_init_tags(u64 max_tag) >>>> +{ >>>> + static bool gcr_kernel_excl_initialized = false; >>>> + >>>> + if (!gcr_kernel_excl_initialized) { >>>> + /* >>>> + * The format of the tags in KASAN is 0xFF and in MTE is 0xF. >>>> + * This conversion extracts an MTE tag from a KASAN tag. >>>> + */ >>>> + u64 incl = GENMASK(FIELD_GET(MTE_TAG_MASK >> MTE_TAG_SHIFT, >>>> + max_tag), 0); >>>> + >>>> + gcr_kernel_excl = ~incl & SYS_GCR_EL1_EXCL_MASK; >>>> + gcr_kernel_excl_initialized = true; >>>> + } >>>> + >>>> + /* Enable the kernel exclude mask for random tags generation. */ >>>> + write_sysreg_s(SYS_GCR_EL1_RRND | gcr_kernel_excl, SYS_GCR_EL1); >>>> +} >>> >>> I don't think this function belongs to this patch. There is an earlier >>> patch that talks about mte_init_tags() but no trace of it until this >>> patch. >> >> Could you please point out to which patch are you referring to? > > I replied to it already (or you can search ;)). But this patch is about > switching GCR_EL1 on exception entry/exit rather than setting up the > initial kernel GCR_EL1 value. > Temporally after I asked ;) (I give you the benefit of delay of the mail server ;) ). I think that during the development the logic changed a bit, but I agree that the comments are outdated. I am fine to move the code. -- Regards, Vincenzo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel