Re: [cocci] [PATCH v3] coccinelle: Extend address test from ifaddr to every test expression

[Markus Elfring <Markus.Elfring@web.de>]

> The test of an expression's address does not necessarily represent the
> whole condition, it may only be a part of it. Also, an expression's
> address is likely to be non-zero in every test expression, not only in
> if statements.
>
> This change aims at detecting an address test in more complex conditions
> for every test expression.
>
> Signed-off-by: Jérémy Lefaure <jeremy.lefaure@netatmo.com>
> ---
> v2 -> v3: Apply Julia's suggestion to have a more generic solution + adapt commit message and file
>           name to this new solution.
> v1 -> v2: Moved disjunction on the condition itself instead of being on the
>           if statements.
>
>  scripts/coccinelle/misc/{ifaddr.cocci => test_addr.cocci} | 4 +---


It can be determined that the proposed approach for the detection of
questionable source code places is incomplete (also because of the current
development status for the Coccinelle software).
Thus I suggest to reconsider the usage of the word “every” for the patch message
once more.
Will further adjustments become helpful for desired source code analyses
and corresponding transformations?

Regards,
Markus