From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Durrant Subject: Re: [PATCH v2 net-next 2/7] xen-netback: retire guest rx side prefix GSO feature Date: Tue, 4 Oct 2016 13:35:41 +0000 Message-ID: <6af51a0a84cf41d5a31168b3e8626fcd__44038.7072660544$1475588622$gmane$org@AMSPEX02CL03.citrite.net> References: <1475573358-32414-1-git-send-email-paul.durrant@citrix.com> <1475573358-32414-3-git-send-email-paul.durrant@citrix.com> <20161004125205.GE30836@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1brPzb-0008Jw-90 for xen-devel@lists.xenproject.org; Tue, 04 Oct 2016 13:42:47 +0000 In-Reply-To: <20161004125205.GE30836@localhost.localdomain> Content-Language: en-US List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Konrad Rzeszutek Wilk , "annie.li@oracle.com" , "joao.m.martins@oracle.com" Cc: "netdev@vger.kernel.org" , Wei Liu , "xen-devel@lists.xenproject.org" List-Id: xen-devel@lists.xenproject.org PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQo+IEZyb206IEtvbnJhZCBSemVzenV0ZWsgV2ls ayBbbWFpbHRvOmtvbnJhZC53aWxrQG9yYWNsZS5jb21dCj4gU2VudDogMDQgT2N0b2JlciAyMDE2 IDEzOjUyCj4gVG86IFBhdWwgRHVycmFudCA8UGF1bC5EdXJyYW50QGNpdHJpeC5jb20+OyBhbm5p ZS5saUBvcmFjbGUuY29tOwo+IGpvYW8ubS5tYXJ0aW5zQG9yYWNsZS5jb20KPiBDYzogbmV0ZGV2 QHZnZXIua2VybmVsLm9yZzsgeGVuLWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnOyBXZWkgTGl1 Cj4gPHdlaS5saXUyQGNpdHJpeC5jb20+Cj4gU3ViamVjdDogUmU6IFtYZW4tZGV2ZWxdIFtQQVRD SCB2MiBuZXQtbmV4dCAyLzddIHhlbi1uZXRiYWNrOiByZXRpcmUgZ3Vlc3QKPiByeCBzaWRlIHBy ZWZpeCBHU08gZmVhdHVyZQo+IAo+IE9uIFR1ZSwgT2N0IDA0LCAyMDE2IGF0IDEwOjI5OjEzQU0g KzAxMDAsIFBhdWwgRHVycmFudCB3cm90ZToKPiA+IEFzIGZhciBhcyBJIGFtIGF3YXJlIG9ubHkg dmVyeSBvbGQgV2luZG93cyBuZXR3b3JrIGZyb250ZW5kcyBtYWtlIHVzZQo+ID4gb2YgdGhpcyBz dHlsZSBvZiBwYXNzaW5nIEdTTyBwYWNrZXRzIGZyb20gYmFja2VuZCB0byBmcm9udGVuZC4gVGhl c2UKPiA+IGZyb250ZW5kcyBjYW4gZWFzaWx5IGJlIHJlcGxhY2VkIGJ5IHRoZSBmcmVlbHkgYXZh aWxhYmxlIFhlbiBQcm9qZWN0Cj4gPiBXaW5kb3dzIFBWIG5ldHdvcmsgZnJvbnRlbmQsIHdoaWNo IHVzZXMgdGhlICdkZWZhdWx0JyBtZWNoYW5pc20gZm9yCj4gPiBwYXNzaW5nIEdTTyBwYWNrZXRz LCB3aGljaCBpcyBhbHNvIHVzZWQgYnkgYWxsIExpbnV4IGZyb250ZW5kcy4KPiAKPiBJdCBpcyBu b3QgdGhhdCBzaW1wbGUuIFNvbWUgY29tcGFuaWVzIGhhdmUgZXh0cmEganVpY2UgaW4gdGhlaXIg V2luZG93cwo+IGZyb250ZW5kcyBzbyBjYW4ndCBlYXNpbHkgc3dhcCBvdmVyIHRvIHRoZSBYZW4g UHJvamVjdCBvbmUuCgpPaywgdGhlbiB0aG9zZSBmcm9udGVuZHMgd2lsbCBjb250aW51ZSB0byB3 b3JrLCBidXQgdGhleSB3b24ndCBnZXQgR1NPIHBhY2tldHMgYW55IG1vcmUuIFByZWZpeCBHU08g aGFzIG5ldmVyIGJlZW4gc3BlY2lmaWVkIGluIHRoZSBjYW5vbmljYWwgbmV0aWYgaGVhZGVyIGFu ZCBzbyBoYXMgYmVlbiBpbiBhIGxpbWJvIHN0YXRlIGZvcmV2ZXIgc28gc3VjaCBmcm9udGVuZHMg aGF2ZSBhbHdheXMgYmVlbiBvbiBib3Jyb3dlZCB0aW1lIGFuZCBvbmx5IGp1c3QgaGFwcGVuZWQg dG8gd29yayBhZ2FpbnN0IGEgbGludXggYmFja2VuZC4gSWYgc29tZW9uZSB3YW50cyB0byBhY3R1 YWxseSBzcGVjaWZ5IHByZWZpeCBHU08gcHJvcGVybHkgdGhlbiBpdCBjb3VsZCBiZSBhZGRlZCBi YWNrIGluLCBidXQgaXQgc2hvdWxkIG5vdCBiZSBuZWNlc3Nhcnkgbm93IHRoYXQgdGhlIFJYIHNp ZGUgcmVxPC0+cnNwIGlkZW50aXR5IHJlbGF0aW9uIGlzIGRvY3VtZW50ZWQgKGh0dHA6Ly94ZW5i aXRzLnhlbi5vcmcvZ2l0d2ViLz9wPXhlbi5naXQ7YT1ibG9iO2Y9eGVuL2luY2x1ZGUvcHVibGlj L2lvL25ldGlmLmg7aGI9SEVBRCNsNzI5KS4KCj4gCj4gRWl0aGVyIHdheSBDQy1pbmcgQW5uaWUK PiAKPiBBbHNvIHdvdWxkIGl0IG1ha2Ugc2Vuc2UgdG8gQ0MgdGhlIEZyZWVCU0QgYW5kIE5ldEJT RCBtYWludGFpbmVycyBvZiB0aGVpcgo+IFBWIGRyaXZlcnMganVzdCB0byBtYWtlIHN1cmU/IChP ciBoYXMgdGhhdCBiZWVuIGNvbmZpcm1lZCkKPiAKCkkgY291bGQgZG8gdGhhdCwgYnV0IEknZCBo b3BlIHRoYXQgdGhleSB3b3VsZCBiZSBzdWJzY3JpYmVkIHRvIHhlbi1kZXZlbCBhbmQgd2lsbCBj aGltZSBpbiBpZiB0aGVyZSdzIGxpa2VseSB0byBiZSBhIHByb2JsZW0uCgo+ID4KPiA+IE5PVEU6 IFJlbW92YWwgb2YgdGhpcyBmZWF0dXJlIHdpbGwgbm90IGNhdXNlIGJyZWFrYWdlIGluIG9sZCBX aW5kb3dzCj4gPiAgICAgICBmcm9udGVuZHMuIFRoZXkgc2ltcGx5IHdpbGwgbm8gbG9uZ2VyIHJl Y2VpdmUgR1NPIHBhY2tldHMgLSB0aGUKPiA+ICAgICAgIHBhY2tldHMgaW5zdGVhZCBiZWluZyBm cmFnbWVudGVkIGluIHRoZSBiYWNrZW5kLgo+IAo+IERpZCB5b3UgYWxzbyB0ZXN0IHRoaXMgd2l0 aCBTdVNFL05vdmVsbCBXaW5kb3dzIFBWIGRyaXZlcnM/Cj4gCgpObywgSSBkb24ndCBoYXZlIGNv cGllcyBvZiB0aGVzZS4gSW50ZXJuYWwgWGVuU2VydmVyIHRlc3RpbmcgaGFzIG5vdCBzaG93biB1 cCBhbnkgaXNzdWVzIHdpdGggJ2xlZ2FjeScgUFYgZHJpdmVycyB0aG91Z2ggKHdoaWNoIGRvIHN0 aWxsIGhhdmUgdGhlIHByZWZpeCBHU08gY29kZSBpbikuCgogIFBhdWwKCj4gVGhhbmtzLgo+ID4K PiA+IFNpZ25lZC1vZmYtYnk6IFBhdWwgRHVycmFudCA8cGF1bC5kdXJyYW50QGNpdHJpeC5jb20+ Cj4gPiAtLS0KPiA+IENjOiBXZWkgTGl1IDx3ZWkubGl1MkBjaXRyaXguY29tPgo+ID4gLS0tCj4g PiAgZHJpdmVycy9uZXQveGVuLW5ldGJhY2svY29tbW9uLmggICAgfCAgMSAtCj4gPiAgZHJpdmVy cy9uZXQveGVuLW5ldGJhY2svaW50ZXJmYWNlLmMgfCAgNCArKy0tCj4gPiAgZHJpdmVycy9uZXQv eGVuLW5ldGJhY2svcnguYyAgICAgICAgfCAyNiAtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQo+ ID4gIGRyaXZlcnMvbmV0L3hlbi1uZXRiYWNrL3hlbmJ1cy5jICAgIHwgMjEgLS0tLS0tLS0tLS0t LS0tLS0tLS0tCj4gPiAgNCBmaWxlcyBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKyksIDUwIGRlbGV0 aW9ucygtKQo+ID4KPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL25ldC94ZW4tbmV0YmFjay9jb21t b24uaAo+ID4gYi9kcml2ZXJzL25ldC94ZW4tbmV0YmFjay9jb21tb24uaAo+ID4gaW5kZXggYjM4 ZmIyYy4uMGJhNTkxMCAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvbmV0L3hlbi1uZXRiYWNrL2Nv bW1vbi5oCj4gPiArKysgYi9kcml2ZXJzL25ldC94ZW4tbmV0YmFjay9jb21tb24uaAo+ID4gQEAg LTI2MCw3ICsyNjAsNiBAQCBzdHJ1Y3QgeGVudmlmIHsKPiA+Cj4gPiAgCS8qIEZyb250ZW5kIGZl YXR1cmUgaW5mb3JtYXRpb24uICovCj4gPiAgCWludCBnc29fbWFzazsKPiA+IC0JaW50IGdzb19w cmVmaXhfbWFzazsKPiA+Cj4gPiAgCXU4IGNhbl9zZzoxOwo+ID4gIAl1OCBpcF9jc3VtOjE7Cj4g PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9uZXQveGVuLW5ldGJhY2svaW50ZXJmYWNlLmMKPiA+IGIv ZHJpdmVycy9uZXQveGVuLW5ldGJhY2svaW50ZXJmYWNlLmMKPiA+IGluZGV4IGZiNTBjNmQuLjIx MWQ1NDIgMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL25ldC94ZW4tbmV0YmFjay9pbnRlcmZhY2Uu Ywo+ID4gKysrIGIvZHJpdmVycy9uZXQveGVuLW5ldGJhY2svaW50ZXJmYWNlLmMKPiA+IEBAIC0z MTksOSArMzE5LDkgQEAgc3RhdGljIG5ldGRldl9mZWF0dXJlc190Cj4gPiB4ZW52aWZfZml4X2Zl YXR1cmVzKHN0cnVjdCBuZXRfZGV2aWNlICpkZXYsCj4gPgo+ID4gIAlpZiAoIXZpZi0+Y2FuX3Nn KQo+ID4gIAkJZmVhdHVyZXMgJj0gfk5FVElGX0ZfU0c7Cj4gPiAtCWlmICh+KHZpZi0+Z3NvX21h c2sgfCB2aWYtPmdzb19wcmVmaXhfbWFzaykgJiBHU09fQklUKFRDUFY0KSkKPiA+ICsJaWYgKH4o dmlmLT5nc29fbWFzaykgJiBHU09fQklUKFRDUFY0KSkKPiA+ICAJCWZlYXR1cmVzICY9IH5ORVRJ Rl9GX1RTTzsKPiA+IC0JaWYgKH4odmlmLT5nc29fbWFzayB8IHZpZi0+Z3NvX3ByZWZpeF9tYXNr KSAmIEdTT19CSVQoVENQVjYpKQo+ID4gKwlpZiAofih2aWYtPmdzb19tYXNrKSAmIEdTT19CSVQo VENQVjYpKQo+ID4gIAkJZmVhdHVyZXMgJj0gfk5FVElGX0ZfVFNPNjsKPiA+ICAJaWYgKCF2aWYt PmlwX2NzdW0pCj4gPiAgCQlmZWF0dXJlcyAmPSB+TkVUSUZfRl9JUF9DU1VNOwo+ID4gZGlmZiAt LWdpdCBhL2RyaXZlcnMvbmV0L3hlbi1uZXRiYWNrL3J4LmMKPiA+IGIvZHJpdmVycy9uZXQveGVu LW5ldGJhY2svcnguYyBpbmRleCAwMzgzNmFhLi42YmQ3ZDZlIDEwMDY0NAo+ID4gLS0tIGEvZHJp dmVycy9uZXQveGVuLW5ldGJhY2svcnguYwo+ID4gKysrIGIvZHJpdmVycy9uZXQveGVuLW5ldGJh Y2svcnguYwo+ID4gQEAgLTM0NywxNiArMzQ3LDYgQEAgc3RhdGljIGludCB4ZW52aWZfZ29wX3Nr YihzdHJ1Y3Qgc2tfYnVmZiAqc2tiLAo+ID4gIAkJCWdzb190eXBlID0gWEVOX05FVElGX0dTT19U WVBFX1RDUFY2Owo+ID4gIAl9Cj4gPgo+ID4gLQkvKiBTZXQgdXAgYSBHU08gcHJlZml4IGRlc2Ny aXB0b3IsIGlmIG5lY2Vzc2FyeSAqLwo+ID4gLQlpZiAoKDEgPDwgZ3NvX3R5cGUpICYgdmlmLT5n c29fcHJlZml4X21hc2spIHsKPiA+IC0JCVJJTkdfQ09QWV9SRVFVRVNUKCZxdWV1ZS0+cngsIHF1 ZXVlLT5yeC5yZXFfY29ucysrLAo+ICZyZXEpOwo+ID4gLQkJbWV0YSA9IG5wby0+bWV0YSArIG5w by0+bWV0YV9wcm9kKys7Cj4gPiAtCQltZXRhLT5nc29fdHlwZSA9IGdzb190eXBlOwo+ID4gLQkJ bWV0YS0+Z3NvX3NpemUgPSBza2Jfc2hpbmZvKHNrYiktPmdzb19zaXplOwo+ID4gLQkJbWV0YS0+ c2l6ZSA9IDA7Cj4gPiAtCQltZXRhLT5pZCA9IHJlcS5pZDsKPiA+IC0JfQo+ID4gLQo+ID4gIAlS SU5HX0NPUFlfUkVRVUVTVCgmcXVldWUtPnJ4LCBxdWV1ZS0+cngucmVxX2NvbnMrKywgJnJlcSk7 Cj4gPiAgCW1ldGEgPSBucG8tPm1ldGEgKyBucG8tPm1ldGFfcHJvZCsrOwo+ID4KPiA+IEBAIC01 MTEsMjIgKzUwMSw2IEBAIHN0YXRpYyB2b2lkIHhlbnZpZl9yeF9hY3Rpb24oc3RydWN0IHhlbnZp Zl9xdWV1ZQo+ICpxdWV1ZSkKPiA+ICAJd2hpbGUgKChza2IgPSBfX3NrYl9kZXF1ZXVlKCZyeHEp KSAhPSBOVUxMKSB7Cj4gPiAgCQlzdHJ1Y3QgeGVuX25ldGlmX2V4dHJhX2luZm8gKmV4dHJhID0g TlVMTDsKPiA+Cj4gPiAtCQlpZiAoKDEgPDwgcXVldWUtPm1ldGFbbnBvLm1ldGFfY29uc10uZ3Nv X3R5cGUpICYKPiA+IC0JCSAgICB2aWYtPmdzb19wcmVmaXhfbWFzaykgewo+ID4gLQkJCXJlc3Ag PSBSSU5HX0dFVF9SRVNQT05TRSgmcXVldWUtPnJ4LAo+ID4gLQkJCQkJCSBxdWV1ZS0+cngucnNw X3Byb2RfcHZ0KyspOwo+ID4gLQo+ID4gLQkJCXJlc3AtPmZsYWdzID0gWEVOX05FVFJYRl9nc29f cHJlZml4IHwKPiA+IC0JCQkJICAgICAgWEVOX05FVFJYRl9tb3JlX2RhdGE7Cj4gPiAtCj4gPiAt CQkJcmVzcC0+b2Zmc2V0ID0gcXVldWUtCj4gPm1ldGFbbnBvLm1ldGFfY29uc10uZ3NvX3NpemU7 Cj4gPiAtCQkJcmVzcC0+aWQgPSBxdWV1ZS0+bWV0YVtucG8ubWV0YV9jb25zXS5pZDsKPiA+IC0J CQlyZXNwLT5zdGF0dXMgPSBYRU5WSUZfUlhfQ0Ioc2tiKS0KPiA+bWV0YV9zbG90c191c2VkOwo+ ID4gLQo+ID4gLQkJCW5wby5tZXRhX2NvbnMrKzsKPiA+IC0JCQlYRU5WSUZfUlhfQ0Ioc2tiKS0+ bWV0YV9zbG90c191c2VkLS07Cj4gPiAtCQl9Cj4gPiAtCj4gPiAgCQlxdWV1ZS0+c3RhdHMudHhf Ynl0ZXMgKz0gc2tiLT5sZW47Cj4gPiAgCQlxdWV1ZS0+c3RhdHMudHhfcGFja2V0cysrOwo+ID4K PiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL25ldC94ZW4tbmV0YmFjay94ZW5idXMuYwo+ID4gYi9k cml2ZXJzL25ldC94ZW4tbmV0YmFjay94ZW5idXMuYwo+ID4gaW5kZXggZGFmNGM3OC4uNzA1NjQw NCAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvbmV0L3hlbi1uZXRiYWNrL3hlbmJ1cy5jCj4gPiAr KysgYi9kcml2ZXJzL25ldC94ZW4tbmV0YmFjay94ZW5idXMuYwo+ID4gQEAgLTExMzUsNyArMTEz NSw2IEBAIHN0YXRpYyBpbnQgcmVhZF94ZW5idXNfdmlmX2ZsYWdzKHN0cnVjdAo+IGJhY2tlbmRf aW5mbyAqYmUpCj4gPiAgCXZpZi0+Y2FuX3NnID0gISF2YWw7Cj4gPgo+ID4gIAl2aWYtPmdzb19t YXNrID0gMDsKPiA+IC0JdmlmLT5nc29fcHJlZml4X21hc2sgPSAwOwo+ID4KPiA+ICAJaWYgKHhl bmJ1c19zY2FuZihYQlRfTklMLCBkZXYtPm90aGVyZW5kLCAiZmVhdHVyZS1nc28tdGNwdjQiLAo+ ID4gIAkJCSAiJWQiLCAmdmFsKSA8IDApCj4gPiBAQCAtMTE0MywzMiArMTE0MiwxMiBAQCBzdGF0 aWMgaW50IHJlYWRfeGVuYnVzX3ZpZl9mbGFncyhzdHJ1Y3QKPiBiYWNrZW5kX2luZm8gKmJlKQo+ ID4gIAlpZiAodmFsKQo+ID4gIAkJdmlmLT5nc29fbWFzayB8PSBHU09fQklUKFRDUFY0KTsKPiA+ Cj4gPiAtCWlmICh4ZW5idXNfc2NhbmYoWEJUX05JTCwgZGV2LT5vdGhlcmVuZCwgImZlYXR1cmUt Z3NvLXRjcHY0LQo+IHByZWZpeCIsCj4gPiAtCQkJICIlZCIsICZ2YWwpIDwgMCkKPiA+IC0JCXZh bCA9IDA7Cj4gPiAtCWlmICh2YWwpCj4gPiAtCQl2aWYtPmdzb19wcmVmaXhfbWFzayB8PSBHU09f QklUKFRDUFY0KTsKPiA+IC0KPiA+ICAJaWYgKHhlbmJ1c19zY2FuZihYQlRfTklMLCBkZXYtPm90 aGVyZW5kLCAiZmVhdHVyZS1nc28tdGNwdjYiLAo+ID4gIAkJCSAiJWQiLCAmdmFsKSA8IDApCj4g PiAgCQl2YWwgPSAwOwo+ID4gIAlpZiAodmFsKQo+ID4gIAkJdmlmLT5nc29fbWFzayB8PSBHU09f QklUKFRDUFY2KTsKPiA+Cj4gPiAtCWlmICh4ZW5idXNfc2NhbmYoWEJUX05JTCwgZGV2LT5vdGhl cmVuZCwgImZlYXR1cmUtZ3NvLXRjcHY2LQo+IHByZWZpeCIsCj4gPiAtCQkJICIlZCIsICZ2YWwp IDwgMCkKPiA+IC0JCXZhbCA9IDA7Cj4gPiAtCWlmICh2YWwpCj4gPiAtCQl2aWYtPmdzb19wcmVm aXhfbWFzayB8PSBHU09fQklUKFRDUFY2KTsKPiA+IC0KPiA+IC0JaWYgKHZpZi0+Z3NvX21hc2sg JiB2aWYtPmdzb19wcmVmaXhfbWFzaykgewo+ID4gLQkJeGVuYnVzX2Rldl9mYXRhbChkZXYsIGVy ciwKPiA+IC0JCQkJICIlczogZ3NvIGFuZCBnc28gcHJlZml4IGZsYWdzIGFyZSBub3QgIgo+ID4g LQkJCQkgIm11dHVhbGx5IGV4Y2x1c2l2ZSIsCj4gPiAtCQkJCSBkZXYtPm90aGVyZW5kKTsKPiA+ IC0JCXJldHVybiAtRU9QTk9UU1VQUDsKPiA+IC0JfQo+ID4gLQo+ID4gIAlpZiAoeGVuYnVzX3Nj YW5mKFhCVF9OSUwsIGRldi0+b3RoZXJlbmQsICJmZWF0dXJlLW5vLWNzdW0tCj4gb2ZmbG9hZCIs Cj4gPiAgCQkJICIlZCIsICZ2YWwpIDwgMCkKPiA+ICAJCXZhbCA9IDA7Cj4gPiAtLQo+ID4gMi4x LjQKPiA+Cj4gPgo+ID4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KPiA+IFhlbi1kZXZlbCBtYWlsaW5nIGxpc3QKPiA+IFhlbi1kZXZlbEBsaXN0cy54ZW4u b3JnCj4gPiBodHRwczovL2xpc3RzLnhlbi5vcmcveGVuLWRldmVsCgpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhl bi1kZXZlbEBsaXN0cy54ZW4ub3JnCmh0dHBzOi8vbGlzdHMueGVuLm9yZy94ZW4tZGV2ZWwK