From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D16EFC433FE for ; Wed, 27 Oct 2021 14:08:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A8F7E60F38 for ; Wed, 27 Oct 2021 14:08:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242416AbhJ0OKm (ORCPT ); Wed, 27 Oct 2021 10:10:42 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:34108 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242408AbhJ0OKl (ORCPT ); Wed, 27 Oct 2021 10:10:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635343696; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=r+HnDLX+drr+E9HuPxXIta+DEpzDrHQiUhqwmqxZrjs=; b=VmsGveAnbgE8Y5U1TUMAaOGr2XwqX8993kuqUHitSFrhAfCrH84OjSou3RVMYrthhltUXR QmAH4hzSue5akHaYkWiikfwKD3MFMoD0/9MckTzp1ztv1Ja1Ar2dBAMqfPVSGBO+8RXb7Z 4dEGd0wVzLnHM7ulVwLU9FOeKp6cuBM= Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-557-YSDkV11APZ-AB6bnLwNkVQ-1; Wed, 27 Oct 2021 10:08:15 -0400 X-MC-Unique: YSDkV11APZ-AB6bnLwNkVQ-1 Received: by mail-ed1-f70.google.com with SMTP id z1-20020a05640235c100b003dcf0fbfbd8so2431640edc.6 for ; Wed, 27 Oct 2021 07:08:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=r+HnDLX+drr+E9HuPxXIta+DEpzDrHQiUhqwmqxZrjs=; b=Yp8RbmGtWPWzEou4B1tmWeZQcXXyov4cvlM+bxBlD0XtvksK1EkjubWWQwui50h7cM mQBgHXjUrfgp6guVI8ISpFC8MyaAGRhYpLkr8F5QQgscsGR7iRfK8DC9hzxPDUPSmrrg ALL0XWTH/Vw98TFB4lLCSNMtfIjK9MD+DU7I+WDRSqFgQKJI8YxCCtZBmtq2HjeUbD2D TUNzX4DJBlyrm8iib/hlC8AgyZzLmTMaCYjiiTTuFtFI8O7gEo5jBbUlEy3PwruTBMW4 3Amj+eViBNuqZ8h2gdg9wEcRLkeGO5xuedmD/jKAjEetj0Bt9xXm8AphsOi9/OuHTjcA sR3w== X-Gm-Message-State: AOAM532fyrIte6jbnBJ1vQMwRrLMl/EIMUHemob0jQEoGtpmoGiHr5AR Nnv7Eohz1KpgGlGrDIoVz/Clml0VSHBLEPnVLeY/6wWrkkiZfnlCwfNn31i+j1K/ZVjZWrG+S/T Re+u7vFGplVgkE41crm5VNg== X-Received: by 2002:a05:6402:13d4:: with SMTP id a20mr44364812edx.309.1635343690722; Wed, 27 Oct 2021 07:08:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwybMPvf0VnxlouBqE5MDq1acp/YpHPytQi7J6RsARiGbzFNfjenE+X1Acx1MYrkZOIu/llew== X-Received: by 2002:a05:6402:13d4:: with SMTP id a20mr44364786edx.309.1635343690409; Wed, 27 Oct 2021 07:08:10 -0700 (PDT) Received: from ?IPV6:2001:1c00:c1e:bf00:1054:9d19:e0f0:8214? (2001-1c00-0c1e-bf00-1054-9d19-e0f0-8214.cable.dynamic.v6.ziggo.nl. [2001:1c00:c1e:bf00:1054:9d19:e0f0:8214]) by smtp.gmail.com with ESMTPSA id hv9sm5324ejc.51.2021.10.27.07.08.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 Oct 2021 07:08:10 -0700 (PDT) Message-ID: <6af92c49-ecec-a54f-e2f7-d3ef3527427f@redhat.com> Date: Wed, 27 Oct 2021 16:08:09 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH v4 1/3] platform/x86: hp-wmi: rename platform_profile_* function symbols Content-Language: en-US To: Mario Limonciello , Mark Gross , "Rafael J . Wysocki" Cc: "open list:X86 PLATFORM DRIVERS" , markpearson@lenovo.com, linux-acpi@vger.kernel.org References: <20211026190835.10697-1-mario.limonciello@amd.com> <20211026190835.10697-2-mario.limonciello@amd.com> From: Hans de Goede In-Reply-To: <20211026190835.10697-2-mario.limonciello@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org Hi, On 10/26/21 21:08, Mario Limonciello wrote: > An upcoming change to platform profiles will export `platform_profile_get` > as a symbol that can be used by other drivers. Avoid the collision. > > Signed-off-by: Mario Limonciello Thank you for your patch, I've applied this patch to my review-hans branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans Note it will show up in my review-hans branch once I've pushed my local branch there, which might take a while. Once I've run some tests on this branch the patches there will be added to the platform-drivers-x86/for-next branch and eventually will be included in the pdx86 pull-request to Linus for the next merge-window. Regards, Hans > --- > drivers/platform/x86/hp-wmi.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/platform/x86/hp-wmi.c b/drivers/platform/x86/hp-wmi.c > index 8e31ffadf894..48a46466f086 100644 > --- a/drivers/platform/x86/hp-wmi.c > +++ b/drivers/platform/x86/hp-wmi.c > @@ -1061,8 +1061,8 @@ static int thermal_profile_set(int thermal_profile) > sizeof(thermal_profile), 0); > } > > -static int platform_profile_get(struct platform_profile_handler *pprof, > - enum platform_profile_option *profile) > +static int hp_wmi_platform_profile_get(struct platform_profile_handler *pprof, > + enum platform_profile_option *profile) > { > int tp; > > @@ -1087,8 +1087,8 @@ static int platform_profile_get(struct platform_profile_handler *pprof, > return 0; > } > > -static int platform_profile_set(struct platform_profile_handler *pprof, > - enum platform_profile_option profile) > +static int hp_wmi_platform_profile_set(struct platform_profile_handler *pprof, > + enum platform_profile_option profile) > { > int err, tp; > > @@ -1147,8 +1147,8 @@ static int thermal_profile_setup(void) > if (err) > return err; > > - platform_profile_handler.profile_get = platform_profile_get; > - platform_profile_handler.profile_set = platform_profile_set; > + platform_profile_handler.profile_get = hp_wmi_platform_profile_get; > + platform_profile_handler.profile_set = hp_wmi_platform_profile_set; > } > > set_bit(PLATFORM_PROFILE_COOL, platform_profile_handler.choices); >