From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28680C7EE29 for ; Mon, 22 May 2023 22:38:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234830AbjEVWiz (ORCPT ); Mon, 22 May 2023 18:38:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45548 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234788AbjEVWiy (ORCPT ); Mon, 22 May 2023 18:38:54 -0400 Received: from relay07.th.seeweb.it (relay07.th.seeweb.it [IPv6:2001:4b7a:2000:18::168]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 61F13110; Mon, 22 May 2023 15:38:52 -0700 (PDT) Received: from SoMainline.org (94-211-6-86.cable.dynamic.v4.ziggo.nl [94.211.6.86]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by m-r2.th.seeweb.it (Postfix) with ESMTPSA id 1EF773EB5B; Tue, 23 May 2023 00:38:50 +0200 (CEST) Date: Tue, 23 May 2023 00:38:48 +0200 From: Marijn Suijten To: Konrad Dybcio Cc: Dmitry Baryshkov , Neil Armstrong , Sam Ravnborg , David Airlie , Daniel Vetter , Caleb Connolly , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andy Gross , Bjorn Andersson , ~postmarketos/upstreaming@lists.sr.ht, AngeloGioacchino Del Regno , Martin Botka , Jami Kettunen , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, Abhinav Kumar , Kuogee Hsieh , Jessica Zhang Subject: Re: [PATCH RFC 06/10] drm/panel/samsung-sofef01: Add panel driver for Sony Xperia 5 / 10 II Message-ID: <6axjpyhseqhjrh7u6a6j2lhhefjqxuz5klvtqcyex6wgcinjpf@l73bzdydkv6s> References: <20230521-drm-panels-sony-v1-0-541c341d6bee@somainline.org> <20230521-drm-panels-sony-v1-6-541c341d6bee@somainline.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 2023-05-22 18:30:08, Konrad Dybcio wrote: > On 22.05.2023 03:19, Dmitry Baryshkov wrote: > > On 22/05/2023 00:23, Marijn Suijten wrote: > >> This SOFEF01-M Display-IC driver supports two modes with different > >> compatibles to differentiate between slightly different physical sizes > >> (panels) found on the Xperia 5 (6.1") and 10 II (6.0"). > >> > >> It is currently also used to hardcode significantly higher fake porches > >> for the Xperia 5, which are unused in transfers due to this being a > >> command-mode panel but do have an effect on the clock rates set by > >> dsi_host.c.  Without higher clock rates this panel fails to achieve > >> 60fps and has significant tearing artifacts, while the same calculated > >> clock rate works perfectly fine on the Xperia 10 II. > >> +/* Sony Xperia 5 (kumano bahamut) */ > >> +static const struct drm_display_mode samsung_sofef01_m_bahamut_mode = { > >> +    /* > >> +     * WARNING: These massive porches are wrong/useless for CMDmode > >> +     * (and not defined in downstream DTS) but necessary to bump dsi > >> +     * clocks higher, so that we can achieve proper 60fps without tearing. > >> +     */ > >> +    .clock = (1080 + 156 + 8 + 8) * (2520 + 2393 + 8 + 8) * 60 / 1000, > >> +    .hdisplay = 1080, > >> +    .hsync_start = 1080 + 156, > >> +    .hsync_end = 1080 + 156 + 8, > >> +    .htotal = 1080 + 156 + 8 + 8, > >> +    .vdisplay = 2520, > >> +    .vsync_start = 2520 + 2393, > >> +    .vsync_end = 2520 + 2393 + 8, > >> +    .vtotal = 2520 + 2393 + 8 + 8, > >> +    .width_mm = 61, > >> +    .height_mm = 142, > >> +}; > >> + > >> +/* Sony Xperia 10 II (seine pdx201) */ > >> +static const struct drm_display_mode samsung_sofef01_m_pdx201_mode = { > >> +    .clock = (1080 + 8 + 8 + 8) * (2520 + 8 + 8 + 8) * 60 / 1000, > >> +    .hdisplay = 1080, > >> +    .hsync_start = 1080 + 8, > >> +    .hsync_end = 1080 + 8 + 8, > >> +    .htotal = 1080 + 8 + 8 + 8, > >> +    .vdisplay = 2520, > >> +    .vsync_start = 2520 + 8, > >> +    .vsync_end = 2520 + 8 + 8, > >> +    .vtotal = 2520 + 8 + 8 + 8, > >> +    .width_mm = 60, > >> +    .height_mm = 139, > >> +}; > >> + > >> +static const struct of_device_id samsung_sofef01_m_of_match[] = { > >> +    { .compatible = "samsung,sofef01-m-bahamut", .data = &samsung_sofef01_m_bahamut_mode }, > >> +    { .compatible = "samsung,sofef01-m-pdx201", .data = &samsung_sofef01_m_pdx201_mode }, > > > > Are there really two panels? Can we use one mode for both usecases? > The porches differ by a significant margin but that may or may not > matter for cmd mode.. If we come to unify them, one can add width-mm > (or something like that) in the device tree if that turns out to be > the only difference. See patch description: they matter in that I can abuse them to force a higher pclk on the DSI, otherwise the Xperia 5 refuses to vsync at 60fps (and has artifacts) while the Xperia 10 II runs flawless (but I should check the clock tree to confirm that the value is the same). Downstream has: qcom,mdss-dsi-panel-clockrate = <1132293600>; But that is for the bitclk, which should theoretically be multiplied by lanes=4 and divided by bpp=24 for the pclk, and divided by 8 for the byte clock (without being multiplied by lanes...?). I do think I have the panel names now, which we could use to differentiate these actually-different panels on the same Display-IC instead. - Marijn From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 33B71C77B73 for ; Mon, 22 May 2023 22:38:55 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2C7B610E02C; Mon, 22 May 2023 22:38:54 +0000 (UTC) Received: from m-r2.th.seeweb.it (m-r2.th.seeweb.it [5.144.164.171]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2B10F10E02C for ; Mon, 22 May 2023 22:38:52 +0000 (UTC) Received: from SoMainline.org (94-211-6-86.cable.dynamic.v4.ziggo.nl [94.211.6.86]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by m-r2.th.seeweb.it (Postfix) with ESMTPSA id 1EF773EB5B; Tue, 23 May 2023 00:38:50 +0200 (CEST) Date: Tue, 23 May 2023 00:38:48 +0200 From: Marijn Suijten To: Konrad Dybcio Subject: Re: [PATCH RFC 06/10] drm/panel/samsung-sofef01: Add panel driver for Sony Xperia 5 / 10 II Message-ID: <6axjpyhseqhjrh7u6a6j2lhhefjqxuz5klvtqcyex6wgcinjpf@l73bzdydkv6s> References: <20230521-drm-panels-sony-v1-0-541c341d6bee@somainline.org> <20230521-drm-panels-sony-v1-6-541c341d6bee@somainline.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org, Caleb Connolly , Krzysztof Kozlowski , AngeloGioacchino Del Regno , Sam Ravnborg , Kuogee Hsieh , Andy Gross , Jessica Zhang , devicetree@vger.kernel.org, Conor Dooley , linux-arm-msm@vger.kernel.org, Abhinav Kumar , Rob Herring , Martin Botka , ~postmarketos/upstreaming@lists.sr.ht, Neil Armstrong , Jami Kettunen , Bjorn Andersson , linux-kernel@vger.kernel.org, Dmitry Baryshkov Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 2023-05-22 18:30:08, Konrad Dybcio wrote: > On 22.05.2023 03:19, Dmitry Baryshkov wrote: > > On 22/05/2023 00:23, Marijn Suijten wrote: > >> This SOFEF01-M Display-IC driver supports two modes with different > >> compatibles to differentiate between slightly different physical sizes > >> (panels) found on the Xperia 5 (6.1") and 10 II (6.0"). > >> > >> It is currently also used to hardcode significantly higher fake porches > >> for the Xperia 5, which are unused in transfers due to this being a > >> command-mode panel but do have an effect on the clock rates set by > >> dsi_host.c.  Without higher clock rates this panel fails to achieve > >> 60fps and has significant tearing artifacts, while the same calculated > >> clock rate works perfectly fine on the Xperia 10 II. > >> +/* Sony Xperia 5 (kumano bahamut) */ > >> +static const struct drm_display_mode samsung_sofef01_m_bahamut_mode = { > >> +    /* > >> +     * WARNING: These massive porches are wrong/useless for CMDmode > >> +     * (and not defined in downstream DTS) but necessary to bump dsi > >> +     * clocks higher, so that we can achieve proper 60fps without tearing. > >> +     */ > >> +    .clock = (1080 + 156 + 8 + 8) * (2520 + 2393 + 8 + 8) * 60 / 1000, > >> +    .hdisplay = 1080, > >> +    .hsync_start = 1080 + 156, > >> +    .hsync_end = 1080 + 156 + 8, > >> +    .htotal = 1080 + 156 + 8 + 8, > >> +    .vdisplay = 2520, > >> +    .vsync_start = 2520 + 2393, > >> +    .vsync_end = 2520 + 2393 + 8, > >> +    .vtotal = 2520 + 2393 + 8 + 8, > >> +    .width_mm = 61, > >> +    .height_mm = 142, > >> +}; > >> + > >> +/* Sony Xperia 10 II (seine pdx201) */ > >> +static const struct drm_display_mode samsung_sofef01_m_pdx201_mode = { > >> +    .clock = (1080 + 8 + 8 + 8) * (2520 + 8 + 8 + 8) * 60 / 1000, > >> +    .hdisplay = 1080, > >> +    .hsync_start = 1080 + 8, > >> +    .hsync_end = 1080 + 8 + 8, > >> +    .htotal = 1080 + 8 + 8 + 8, > >> +    .vdisplay = 2520, > >> +    .vsync_start = 2520 + 8, > >> +    .vsync_end = 2520 + 8 + 8, > >> +    .vtotal = 2520 + 8 + 8 + 8, > >> +    .width_mm = 60, > >> +    .height_mm = 139, > >> +}; > >> + > >> +static const struct of_device_id samsung_sofef01_m_of_match[] = { > >> +    { .compatible = "samsung,sofef01-m-bahamut", .data = &samsung_sofef01_m_bahamut_mode }, > >> +    { .compatible = "samsung,sofef01-m-pdx201", .data = &samsung_sofef01_m_pdx201_mode }, > > > > Are there really two panels? Can we use one mode for both usecases? > The porches differ by a significant margin but that may or may not > matter for cmd mode.. If we come to unify them, one can add width-mm > (or something like that) in the device tree if that turns out to be > the only difference. See patch description: they matter in that I can abuse them to force a higher pclk on the DSI, otherwise the Xperia 5 refuses to vsync at 60fps (and has artifacts) while the Xperia 10 II runs flawless (but I should check the clock tree to confirm that the value is the same). Downstream has: qcom,mdss-dsi-panel-clockrate = <1132293600>; But that is for the bitclk, which should theoretically be multiplied by lanes=4 and divided by bpp=24 for the pclk, and divided by 8 for the byte clock (without being multiplied by lanes...?). I do think I have the panel names now, which we could use to differentiate these actually-different panels on the same Display-IC instead. - Marijn