From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5B2CC433FE for ; Wed, 6 Oct 2021 09:35:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 974CE61075 for ; Wed, 6 Oct 2021 09:35:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237893AbhJFJhT (ORCPT ); Wed, 6 Oct 2021 05:37:19 -0400 Received: from foss.arm.com ([217.140.110.172]:40520 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229824AbhJFJhR (ORCPT ); Wed, 6 Oct 2021 05:37:17 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D42CA1FB; Wed, 6 Oct 2021 02:35:25 -0700 (PDT) Received: from [10.1.34.161] (e127744.cambridge.arm.com [10.1.34.161]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7378D3F766; Wed, 6 Oct 2021 02:35:23 -0700 (PDT) Subject: Re: [PATCH 4/5] perf arm-spe: Implement find_snapshot callback To: Leo Yan Cc: linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, John Garry , Will Deacon , Mathieu Poirier , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Mike Leach , linux-arm-kernel@lists.infradead.org, coresight@lists.linaro.org References: <20210916154635.1525-1-german.gomez@arm.com> <20210916154635.1525-4-german.gomez@arm.com> <20210923135016.GG400258@leoy-ThinkPad-X240s> <20210923144048.GB603008@leoy-ThinkPad-X240s> <1c6a3a73-27dc-6673-7fe7-34bc7fcb0a68@arm.com> <20211004122724.GC174271@leoy-ThinkPad-X240s> From: German Gomez Message-ID: <6b092f13-832f-5d1d-a504-aea96c81bf17@arm.com> Date: Wed, 6 Oct 2021 10:35:20 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20211004122724.GC174271@leoy-ThinkPad-X240s> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Leo, Many thanks for your comments. On 04/10/2021 13:27, Leo Yan wrote: > Hi German, > > On Thu, Sep 30, 2021 at 01:26:15PM +0100, German Gomez wrote: > > [...] > > So simply say, I think the head pointer monotonically increasing is > the right thing to do in Arm SPE driver. I will talk to James about how we can proceed on this. >> (note that the patch will skip the wrap-around detection if this is the >> case, >> in order to handle both cases in the userspace perf tool). > Almost agree, I read multiple times but have no idea what's the > "both cases" in the last sentence. Apologies for the later part was not clear. What I meant to say was that in the original patch for cs-etm, it seemed to handle both cases where AUX head might be monotonically and non-monotonically increasing, so we applied the same for the Arm SPE patch. > > Please let me know if anything is not clear. > > Thanks, > Leo > > [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/tools/perf/util/auxtrace.c#n1804 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D033C433F5 for ; Wed, 6 Oct 2021 09:37:42 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EEF62610E6 for ; Wed, 6 Oct 2021 09:37:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org EEF62610E6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=AF6x7XUVUgCO2y/Q/DiY1FbwVNbhTytvVW8iSD4kZS4=; b=ZOq+nmU3WiZLRdYVIGKUJrfL5b GK7eqO7cWYHoDwl9aIN4jYyD/2dLTT469STn1zM1sTFqkWqX30JtwVeEiwDgrkGg51M8AOjBNBpeR tDJqK7s1xcvFUVCWr+uR8w9+LIzvR4bmrraC8kuTLERfFlIc7DwMqgDFDiMqT//lf9x6AQOhTsmd1 kQXMYzq32NMTig7r2+HANbFA3WIWyo94qaAAdxO/wniv/8Bjxk2moAvjNPr9NUgzg74pdgwH8j0dc DC1XXyyE7e+3WyF1mPD4Rh+nGIUYo331FePnv+lGARZp1IU6YEEP8/K769lZK5IjIgop9ZX5UmAjZ HDCIxCJA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mY3Kp-00DdUZ-L0; Wed, 06 Oct 2021 09:35:35 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mY3Kl-00DdTy-DE for linux-arm-kernel@lists.infradead.org; Wed, 06 Oct 2021 09:35:32 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D42CA1FB; Wed, 6 Oct 2021 02:35:25 -0700 (PDT) Received: from [10.1.34.161] (e127744.cambridge.arm.com [10.1.34.161]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7378D3F766; Wed, 6 Oct 2021 02:35:23 -0700 (PDT) Subject: Re: [PATCH 4/5] perf arm-spe: Implement find_snapshot callback To: Leo Yan Cc: linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, John Garry , Will Deacon , Mathieu Poirier , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Mike Leach , linux-arm-kernel@lists.infradead.org, coresight@lists.linaro.org References: <20210916154635.1525-1-german.gomez@arm.com> <20210916154635.1525-4-german.gomez@arm.com> <20210923135016.GG400258@leoy-ThinkPad-X240s> <20210923144048.GB603008@leoy-ThinkPad-X240s> <1c6a3a73-27dc-6673-7fe7-34bc7fcb0a68@arm.com> <20211004122724.GC174271@leoy-ThinkPad-X240s> From: German Gomez Message-ID: <6b092f13-832f-5d1d-a504-aea96c81bf17@arm.com> Date: Wed, 6 Oct 2021 10:35:20 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20211004122724.GC174271@leoy-ThinkPad-X240s> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211006_023531_534170_9F56AAC0 X-CRM114-Status: GOOD ( 18.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Leo, Many thanks for your comments. On 04/10/2021 13:27, Leo Yan wrote: > Hi German, > > On Thu, Sep 30, 2021 at 01:26:15PM +0100, German Gomez wrote: > > [...] > > So simply say, I think the head pointer monotonically increasing is > the right thing to do in Arm SPE driver. I will talk to James about how we can proceed on this. >> (note that the patch will skip the wrap-around detection if this is the >> case, >> in order to handle both cases in the userspace perf tool). > Almost agree, I read multiple times but have no idea what's the > "both cases" in the last sentence. Apologies for the later part was not clear. What I meant to say was that in the original patch for cs-etm, it seemed to handle both cases where AUX head might be monotonically and non-monotonically increasing, so we applied the same for the Arm SPE patch. > > Please let me know if anything is not clear. > > Thanks, > Leo > > [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/tools/perf/util/auxtrace.c#n1804 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel