All of lore.kernel.org
 help / color / mirror / Atom feed
From: James Prestwood <prestwoj@gmail.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: netdev@vger.kernel.org
Subject: Re: [RFC 1/1] net: move IFF_LIVE_ADDR_CHANGE to public flag
Date: Thu, 04 Aug 2022 12:29:11 -0700	[thread overview]
Message-ID: <6b0d571ea5fbc5942d798d5201b2cef253688949.camel@gmail.com> (raw)
In-Reply-To: <20220804105917.79aaf6e9@hermes.local>

Hi,

On Thu, 2022-08-04 at 10:59 -0700, Stephen Hemminger wrote:
> On Thu,  4 Aug 2022 10:43:07 -0700
> James Prestwood <prestwoj@gmail.com> wrote:
> 
> > + * @IFF_LIVE_ADDR_CHANGE: device supports hardware address
> > + *     change when it's running. Volatile
> 
> Since this is a property of the device driver, why is it volatile?

Its not intended to be changed since its a device capability.


> When you make it part of uapi, you also want to restrict userspace
> from changing the value via sysfs?
> 

Yeah, this is what I intended to do. Similar to the other volatile
options. Basically following this comment:

"...few flags can be toggled and some other flags are always preserved
from the original net_device flags even if you try to set them via
sysfs. Flags which are always preserved are kept under the flag
grouping @IFF_VOLATILE. Flags which are volatile are annotated below as
such."

Thanks,
James


  reply	other threads:[~2022-08-04 19:29 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-04 17:43 [RFC 0/1] Move IFF_LIVE_ADDR_CHANGE to public flag James Prestwood
2022-08-04 17:43 ` [RFC 1/1] net: move " James Prestwood
2022-08-04 17:59   ` Stephen Hemminger
2022-08-04 19:29     ` James Prestwood [this message]
2022-08-04 18:43   ` Jakub Kicinski
2022-08-04 19:23     ` James Prestwood
2022-08-04 19:49       ` James Prestwood
2022-08-09 19:04         ` Johannes Berg
2022-08-10 16:26           ` James Prestwood
2022-08-10 17:17             ` Johannes Berg
2022-08-10 17:36               ` Jakub Kicinski
2022-08-10 19:35               ` James Prestwood
2022-08-04 20:49 ` [RFC 0/1] Move " Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6b0d571ea5fbc5942d798d5201b2cef253688949.camel@gmail.com \
    --to=prestwoj@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.