From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8189EC6FA82 for ; Thu, 22 Sep 2022 12:51:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231423AbiIVMvI (ORCPT ); Thu, 22 Sep 2022 08:51:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55156 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231127AbiIVMvF (ORCPT ); Thu, 22 Sep 2022 08:51:05 -0400 Received: from mail-lj1-x235.google.com (mail-lj1-x235.google.com [IPv6:2a00:1450:4864:20::235]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2402EE11E8 for ; Thu, 22 Sep 2022 05:51:04 -0700 (PDT) Received: by mail-lj1-x235.google.com with SMTP id g20so9642443ljg.7 for ; Thu, 22 Sep 2022 05:51:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=Sea27jK2pOb0ADt+U+OOXz14ad+JYjdidyw5ceH+6tY=; b=bEQc5o4c96kL003lNdFFNF/PheTKYPzGOx1XlLuWx4uUt3ZZ8u82nZSviwPUHfH2xv bUDvPw5aOQbeDKQmaq1CoRgZsOnIg2YGfJh8cvDV5F9+JLKSUyn50zDSIBxJOcnrj4PR A/jflBtwfF7dKCfnIUVH8sg+arNoqIgkz9k9j9ZFaFWktQEtF1ZrBOG6ExeV2+xa5sCd gIaN+jPceaw/AtbWvWGSXMYZ/VYa/BVnHTn4+MNDa2/tr3mx3BIFfKkZZCFjQpef8XiE zuMwWdRrzBII8cLpO+PWCCMW0r7uAoqveKC5p2LZphYcvpAG3bcSeCk7PVaftA5tgi0M 8RZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=Sea27jK2pOb0ADt+U+OOXz14ad+JYjdidyw5ceH+6tY=; b=DCibDEzSaUXFpeQdyw70Msnzk2FVpW6+JQGnHefQPAN2yqTwhiGzwdrg95z2LS+oCt UzYmVIFn8aLc0Xi2uYPmUaqzbbsuYL4BNwNi0KywmxeUAWpEOZSFD18VZXumulQBbOvV R4+tpD01ZOikghnpophS9YLInoot3DUX1UBOxsM70rVySQ2S1I6wI5nQhOcj0VmiBkTo pyz4DUYHtMbpC4bCJH0fUKvCOZPU1omdcpd5CPfCp5oO4vpS3GDoAh9Hmqun/gvdJS75 oR+KXa9EPTqaxiEgUPydooVpnXEgyMOzBScOlePkDUDqWkdI0jeRe8DQqXX2E1EMtIr6 BKlQ== X-Gm-Message-State: ACrzQf1TB2B2/2hZ68Me+kjtfTw3GLxwLWIKRuqNToB357KLrbr25v0A apOV3JgO8WifcsKtSxfK+R10+w== X-Google-Smtp-Source: AMsMyM7SDptjdpkW7tuuttAy0kYzK4MBmIe60uRZtol4i0HW5ltX1B+Cjzu/BNFNwE3TBkr+rbuBQA== X-Received: by 2002:a2e:1458:0:b0:26c:3b83:e039 with SMTP id 24-20020a2e1458000000b0026c3b83e039mr1098450lju.484.1663851062438; Thu, 22 Sep 2022 05:51:02 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id v12-20020ac258ec000000b0049496608d58sm925362lfo.155.2022.09.22.05.51.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 Sep 2022 05:51:01 -0700 (PDT) Message-ID: <6b24be8f-94d7-6973-6f35-18cb15fc8cd4@linaro.org> Date: Thu, 22 Sep 2022 14:51:00 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v1 01/17] dt-bindings: clk: mediatek: Add MT8195 DPI clocks Content-Language: en-US To: Guillaume Ranquet , Matthias Brugger , Vinod Koul , Stephen Boyd , David Airlie , Rob Herring , Philipp Zabel , Krzysztof Kozlowski , Daniel Vetter , Chunfeng Yun , CK Hu , Jitao shi , Chun-Kuang Hu , Michael Turquette , Kishon Vijay Abraham I , Bo-Chen Chen Cc: linux-mediatek@lists.infradead.org, dri-devel@lists.freedesktop.org, Pablo Sun , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Mattijs Korpershoek , linux-arm-kernel@lists.infradead.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org References: <20220919-v1-0-4844816c9808@baylibre.com> <20220919-v1-1-4844816c9808@baylibre.com> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 22/09/2022 14:45, Guillaume Ranquet wrote: > On Thu, 22 Sep 2022 09:11, Krzysztof Kozlowski > wrote: >> On 19/09/2022 18:55, Guillaume Ranquet wrote: >>> From: Pablo Sun >>> >>> Expand dt-bindings slot for VDOSYS1 of MT8195. >>> This clock is required by the DPI1 hardware >>> and is a downstream of the HDMI pixel clock. >>> >>> Signed-off-by: Pablo Sun >>> Signed-off-by: Guillaume Ranquet >>> Reviewed-by: Mattijs Korpershoek >>> >> >> Looks like broken patch. >> >> Best regards, >> Krzysztof >> > > Hi Bo-Chen and Krzysztof, > I've sent the patches using the rather new b4 prep/send commands. > > Though it produces valid patches, it's using `git show --format=email` > to produce the patches, which lacks a diffstat. > > My understanding is that the diffstat is considered to be comments and thus > are not necessary to produce a valid patch. > > I've reported the issue on the tools mailing list [1], I'm looking at providing > a fix. > > I'll be extra careful at the patch format for V2. Thanks for explanation! Probably your patches are perfectly fine and should apply, although I must admit diffstat is often useful. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 576CBC54EE9 for ; Thu, 22 Sep 2022 12:51:12 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B6EC810EB01; Thu, 22 Sep 2022 12:51:07 +0000 (UTC) Received: from mail-lj1-x234.google.com (mail-lj1-x234.google.com [IPv6:2a00:1450:4864:20::234]) by gabe.freedesktop.org (Postfix) with ESMTPS id 55F1010E35E for ; Thu, 22 Sep 2022 12:51:04 +0000 (UTC) Received: by mail-lj1-x234.google.com with SMTP id a14so10855754ljj.8 for ; Thu, 22 Sep 2022 05:51:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=Sea27jK2pOb0ADt+U+OOXz14ad+JYjdidyw5ceH+6tY=; b=bEQc5o4c96kL003lNdFFNF/PheTKYPzGOx1XlLuWx4uUt3ZZ8u82nZSviwPUHfH2xv bUDvPw5aOQbeDKQmaq1CoRgZsOnIg2YGfJh8cvDV5F9+JLKSUyn50zDSIBxJOcnrj4PR A/jflBtwfF7dKCfnIUVH8sg+arNoqIgkz9k9j9ZFaFWktQEtF1ZrBOG6ExeV2+xa5sCd gIaN+jPceaw/AtbWvWGSXMYZ/VYa/BVnHTn4+MNDa2/tr3mx3BIFfKkZZCFjQpef8XiE zuMwWdRrzBII8cLpO+PWCCMW0r7uAoqveKC5p2LZphYcvpAG3bcSeCk7PVaftA5tgi0M 8RZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=Sea27jK2pOb0ADt+U+OOXz14ad+JYjdidyw5ceH+6tY=; b=4MB6ZnatMbZ48CL6E8r0VkiUVwbcktFavXL3lBAih2O7LOeMM5u1aGyI4P0G05KNqK MB6OxcfKwMlAS1qV6gUS46En6vJCstIsqOlCwex1CRmai2Yn+Blg3uI+EA5dxAmRrjH/ vVBAndSDaXNlAlScL1yc6B0yeHJebE0eYI7h4VbXIO0NPmVFFeXvavFx7jQJJ0tcCedX 2t33azibguMUZHcoklensTmwn03gYDGiO0nn46ImWhhw+F81YUH0EZcxip3DDbQIn23j GCc789WsDSvFd9yZufMdz55cDY4FtIcq3U12WEkj7HTE1ZZXLwQJGIV5SkfgEltT+vkd 9ESg== X-Gm-Message-State: ACrzQf3Zh0WJtgy4efDmatkI2pAKeYi129Y+jMwWS33Qw4UviXTNmuZO 7Vm0Ftrgs5JYP1cXbp4sqDUovYKw8dWoig== X-Google-Smtp-Source: AMsMyM7SDptjdpkW7tuuttAy0kYzK4MBmIe60uRZtol4i0HW5ltX1B+Cjzu/BNFNwE3TBkr+rbuBQA== X-Received: by 2002:a2e:1458:0:b0:26c:3b83:e039 with SMTP id 24-20020a2e1458000000b0026c3b83e039mr1098450lju.484.1663851062438; Thu, 22 Sep 2022 05:51:02 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id v12-20020ac258ec000000b0049496608d58sm925362lfo.155.2022.09.22.05.51.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 Sep 2022 05:51:01 -0700 (PDT) Message-ID: <6b24be8f-94d7-6973-6f35-18cb15fc8cd4@linaro.org> Date: Thu, 22 Sep 2022 14:51:00 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v1 01/17] dt-bindings: clk: mediatek: Add MT8195 DPI clocks Content-Language: en-US To: Guillaume Ranquet , Matthias Brugger , Vinod Koul , Stephen Boyd , David Airlie , Rob Herring , Philipp Zabel , Krzysztof Kozlowski , Daniel Vetter , Chunfeng Yun , CK Hu , Jitao shi , Chun-Kuang Hu , Michael Turquette , Kishon Vijay Abraham I , Bo-Chen Chen References: <20220919-v1-0-4844816c9808@baylibre.com> <20220919-v1-1-4844816c9808@baylibre.com> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Mattijs Korpershoek , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-clk@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-phy@lists.infradead.org, Pablo Sun , linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 22/09/2022 14:45, Guillaume Ranquet wrote: > On Thu, 22 Sep 2022 09:11, Krzysztof Kozlowski > wrote: >> On 19/09/2022 18:55, Guillaume Ranquet wrote: >>> From: Pablo Sun >>> >>> Expand dt-bindings slot for VDOSYS1 of MT8195. >>> This clock is required by the DPI1 hardware >>> and is a downstream of the HDMI pixel clock. >>> >>> Signed-off-by: Pablo Sun >>> Signed-off-by: Guillaume Ranquet >>> Reviewed-by: Mattijs Korpershoek >>> >> >> Looks like broken patch. >> >> Best regards, >> Krzysztof >> > > Hi Bo-Chen and Krzysztof, > I've sent the patches using the rather new b4 prep/send commands. > > Though it produces valid patches, it's using `git show --format=email` > to produce the patches, which lacks a diffstat. > > My understanding is that the diffstat is considered to be comments and thus > are not necessary to produce a valid patch. > > I've reported the issue on the tools mailing list [1], I'm looking at providing > a fix. > > I'll be extra careful at the patch format for V2. Thanks for explanation! Probably your patches are perfectly fine and should apply, although I must admit diffstat is often useful. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 64C33C54EE9 for ; Thu, 22 Sep 2022 12:51:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DmHTEujruUlwreOEEmN6fYm9kXQPv6F3kbjxl/YAo20=; b=bc9lMizBCcqcde 2Z4rWVD91tTeHkrh3yzERL4njXTk0oqL5y0beccgIfINPiU9vqny3PhfXCNBdbgl4T5lSsaxH4PY9 BJApi10046P1Ljcj3sqwROKUYeK++YfMn36Jsdi3m1rYmuaFMGnBektEq/Aq36EJ8z2LtveIltttn J35Wmm/x2tNpVwyg3J6oDywD9WIXj1ticM/WQrZzX0n88mJZWms3Z4rRWJSjK2CkpEQpVHxplqicT csat4hcq/5BRX9aM4jxSbQDKkHTwJcmdyCB5qIEFvMBoGt5c9RaLYe6UMVl/3R45FORkZeY4d8wkW UYDBIV5dDeB+jd0sZciA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1obLfu-00FTkZ-Qi; Thu, 22 Sep 2022 12:51:30 +0000 Received: from mail-lj1-x233.google.com ([2a00:1450:4864:20::233]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1obLfY-00FTYq-04 for linux-phy@lists.infradead.org; Thu, 22 Sep 2022 12:51:09 +0000 Received: by mail-lj1-x233.google.com with SMTP id s10so10863002ljp.5 for ; Thu, 22 Sep 2022 05:51:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=Sea27jK2pOb0ADt+U+OOXz14ad+JYjdidyw5ceH+6tY=; b=bEQc5o4c96kL003lNdFFNF/PheTKYPzGOx1XlLuWx4uUt3ZZ8u82nZSviwPUHfH2xv bUDvPw5aOQbeDKQmaq1CoRgZsOnIg2YGfJh8cvDV5F9+JLKSUyn50zDSIBxJOcnrj4PR A/jflBtwfF7dKCfnIUVH8sg+arNoqIgkz9k9j9ZFaFWktQEtF1ZrBOG6ExeV2+xa5sCd gIaN+jPceaw/AtbWvWGSXMYZ/VYa/BVnHTn4+MNDa2/tr3mx3BIFfKkZZCFjQpef8XiE zuMwWdRrzBII8cLpO+PWCCMW0r7uAoqveKC5p2LZphYcvpAG3bcSeCk7PVaftA5tgi0M 8RZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=Sea27jK2pOb0ADt+U+OOXz14ad+JYjdidyw5ceH+6tY=; b=qpFmF76qaOxVUjocNHrpl0jeBfM5B6TuRNKEtM1D3SASbGuCT08lIli2JoC5rgNTSE vNlcr38yj17zp2V1tsTsrsQEmXzeIhAC7flH2LIGPS4Pi+ws2sEAYX/b5HRavgNPv8Fk tVGIOlPYZI3nozBqrKf5yd+l5rDZMPkmrTnZvnpjQc8IQBSOvy4PQLXAmKYRw0od4ALN L/O79GBeTPeylOcF6RaIy0NZ6P5G761XdmH1pE3RIaC4KCKky8HSz6nUmPTi40ovpU6Q 8Wo9jaTzsX7IhbpGp8S8//XhYI0TqQPUJMzv/sLH9zd9X0kEiSI5l25XZecjM7WhIjAK DBHg== X-Gm-Message-State: ACrzQf3ih5ZJ39XK/pSCshHfx3ovPVNc7Dv+PZ82qxGxpwf6CI6ffJBN 7xxK3m21oqj8m9q1v1wj1TUbkg== X-Google-Smtp-Source: AMsMyM7SDptjdpkW7tuuttAy0kYzK4MBmIe60uRZtol4i0HW5ltX1B+Cjzu/BNFNwE3TBkr+rbuBQA== X-Received: by 2002:a2e:1458:0:b0:26c:3b83:e039 with SMTP id 24-20020a2e1458000000b0026c3b83e039mr1098450lju.484.1663851062438; Thu, 22 Sep 2022 05:51:02 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id v12-20020ac258ec000000b0049496608d58sm925362lfo.155.2022.09.22.05.51.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 Sep 2022 05:51:01 -0700 (PDT) Message-ID: <6b24be8f-94d7-6973-6f35-18cb15fc8cd4@linaro.org> Date: Thu, 22 Sep 2022 14:51:00 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v1 01/17] dt-bindings: clk: mediatek: Add MT8195 DPI clocks Content-Language: en-US To: Guillaume Ranquet , Matthias Brugger , Vinod Koul , Stephen Boyd , David Airlie , Rob Herring , Philipp Zabel , Krzysztof Kozlowski , Daniel Vetter , Chunfeng Yun , CK Hu , Jitao shi , Chun-Kuang Hu , Michael Turquette , Kishon Vijay Abraham I , Bo-Chen Chen Cc: linux-mediatek@lists.infradead.org, dri-devel@lists.freedesktop.org, Pablo Sun , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Mattijs Korpershoek , linux-arm-kernel@lists.infradead.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org References: <20220919-v1-0-4844816c9808@baylibre.com> <20220919-v1-1-4844816c9808@baylibre.com> From: Krzysztof Kozlowski In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220922_055108_049425_4A1C35D8 X-CRM114-Status: GOOD ( 14.72 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org On 22/09/2022 14:45, Guillaume Ranquet wrote: > On Thu, 22 Sep 2022 09:11, Krzysztof Kozlowski > wrote: >> On 19/09/2022 18:55, Guillaume Ranquet wrote: >>> From: Pablo Sun >>> >>> Expand dt-bindings slot for VDOSYS1 of MT8195. >>> This clock is required by the DPI1 hardware >>> and is a downstream of the HDMI pixel clock. >>> >>> Signed-off-by: Pablo Sun >>> Signed-off-by: Guillaume Ranquet >>> Reviewed-by: Mattijs Korpershoek >>> >> >> Looks like broken patch. >> >> Best regards, >> Krzysztof >> > > Hi Bo-Chen and Krzysztof, > I've sent the patches using the rather new b4 prep/send commands. > > Though it produces valid patches, it's using `git show --format=email` > to produce the patches, which lacks a diffstat. > > My understanding is that the diffstat is considered to be comments and thus > are not necessary to produce a valid patch. > > I've reported the issue on the tools mailing list [1], I'm looking at providing > a fix. > > I'll be extra careful at the patch format for V2. Thanks for explanation! Probably your patches are perfectly fine and should apply, although I must admit diffstat is often useful. Best regards, Krzysztof -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7115FC54EE9 for ; Thu, 22 Sep 2022 12:52:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=B354Whh/+yp6upnOj5dAvjp2anxMNELycVqJncSLgz8=; b=UBrSqsKhnnxqZH y3bmyscGMAf+iM2K/6dfl5LMdg6swz6KUopBPkTR7wpx6pnZXAvDhyZW7MbFjX+SpFJC3kuK1UQYS Dfs1PH855Royy5agV5dZt7DLBxc79x4HZKfsHX/PZprAjk1Xzw9G3kV8dqdY5zGe5EGBBI6MMiDnP EKs50qGztosdSzSzAqemTJzI4MoqVh6ICG9anrBisS8bw2v4zV8nyuSgK2167PfauRRKE0MoJVYqR FuNd/1izioSj7unKzmjHMXzQrmwF5gUfkJvQC0WFos81IV0iksSJS5zvOIq3L32TjpNaXpRgf6Ew2 g0lSuuD30dlFoZjijJCQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1obLfa-00FTbu-9N; Thu, 22 Sep 2022 12:51:10 +0000 Received: from mail-lj1-x231.google.com ([2a00:1450:4864:20::231]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1obLfX-00FTYp-1B for linux-arm-kernel@lists.infradead.org; Thu, 22 Sep 2022 12:51:08 +0000 Received: by mail-lj1-x231.google.com with SMTP id j24so10353484lja.4 for ; Thu, 22 Sep 2022 05:51:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=Sea27jK2pOb0ADt+U+OOXz14ad+JYjdidyw5ceH+6tY=; b=bEQc5o4c96kL003lNdFFNF/PheTKYPzGOx1XlLuWx4uUt3ZZ8u82nZSviwPUHfH2xv bUDvPw5aOQbeDKQmaq1CoRgZsOnIg2YGfJh8cvDV5F9+JLKSUyn50zDSIBxJOcnrj4PR A/jflBtwfF7dKCfnIUVH8sg+arNoqIgkz9k9j9ZFaFWktQEtF1ZrBOG6ExeV2+xa5sCd gIaN+jPceaw/AtbWvWGSXMYZ/VYa/BVnHTn4+MNDa2/tr3mx3BIFfKkZZCFjQpef8XiE zuMwWdRrzBII8cLpO+PWCCMW0r7uAoqveKC5p2LZphYcvpAG3bcSeCk7PVaftA5tgi0M 8RZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=Sea27jK2pOb0ADt+U+OOXz14ad+JYjdidyw5ceH+6tY=; b=tmNVGyxzntOaxAGDp/yhngJsX0l8LYkJVaKB31g+NdCqrO625Zl6vLmGdSVRcuhq8d de2oai7t9fAUKchFN1muAgs9Kz3+1w/bPl4esYGG+jiWD60/t0vtCqTNKS5ReyiCcawW CviJmO2uxBcsC9Nne+oDQl/FzFyitdzGrsdQO/cpXNNEnh2tRxHs2B3DgBmniUNe5Hps PfuegQRx9tonAOTnNeWR4sY+JixgIMLZKJ5y2zJSLTuHNQfX8f3WXv+RGAFxalb5MX8M mc2WZmIY4w0938tKoOqEolKbqFkddGpqk1Oc9652jwMeHF9At8kgiSDEt/aHxZhctEG1 AojA== X-Gm-Message-State: ACrzQf3AdKiaKxvJIMoIRsUEM5BC5cRm3rMPYy8ZAjJ50M3fBsxWVWZs pMBcSLCf5Vu9VEg2fBt97Ag+dQ== X-Google-Smtp-Source: AMsMyM7SDptjdpkW7tuuttAy0kYzK4MBmIe60uRZtol4i0HW5ltX1B+Cjzu/BNFNwE3TBkr+rbuBQA== X-Received: by 2002:a2e:1458:0:b0:26c:3b83:e039 with SMTP id 24-20020a2e1458000000b0026c3b83e039mr1098450lju.484.1663851062438; Thu, 22 Sep 2022 05:51:02 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id v12-20020ac258ec000000b0049496608d58sm925362lfo.155.2022.09.22.05.51.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 Sep 2022 05:51:01 -0700 (PDT) Message-ID: <6b24be8f-94d7-6973-6f35-18cb15fc8cd4@linaro.org> Date: Thu, 22 Sep 2022 14:51:00 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v1 01/17] dt-bindings: clk: mediatek: Add MT8195 DPI clocks Content-Language: en-US To: Guillaume Ranquet , Matthias Brugger , Vinod Koul , Stephen Boyd , David Airlie , Rob Herring , Philipp Zabel , Krzysztof Kozlowski , Daniel Vetter , Chunfeng Yun , CK Hu , Jitao shi , Chun-Kuang Hu , Michael Turquette , Kishon Vijay Abraham I , Bo-Chen Chen Cc: linux-mediatek@lists.infradead.org, dri-devel@lists.freedesktop.org, Pablo Sun , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Mattijs Korpershoek , linux-arm-kernel@lists.infradead.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org References: <20220919-v1-0-4844816c9808@baylibre.com> <20220919-v1-1-4844816c9808@baylibre.com> From: Krzysztof Kozlowski In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220922_055107_113759_822B9ECB X-CRM114-Status: GOOD ( 16.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 22/09/2022 14:45, Guillaume Ranquet wrote: > On Thu, 22 Sep 2022 09:11, Krzysztof Kozlowski > wrote: >> On 19/09/2022 18:55, Guillaume Ranquet wrote: >>> From: Pablo Sun >>> >>> Expand dt-bindings slot for VDOSYS1 of MT8195. >>> This clock is required by the DPI1 hardware >>> and is a downstream of the HDMI pixel clock. >>> >>> Signed-off-by: Pablo Sun >>> Signed-off-by: Guillaume Ranquet >>> Reviewed-by: Mattijs Korpershoek >>> >> >> Looks like broken patch. >> >> Best regards, >> Krzysztof >> > > Hi Bo-Chen and Krzysztof, > I've sent the patches using the rather new b4 prep/send commands. > > Though it produces valid patches, it's using `git show --format=email` > to produce the patches, which lacks a diffstat. > > My understanding is that the diffstat is considered to be comments and thus > are not necessary to produce a valid patch. > > I've reported the issue on the tools mailing list [1], I'm looking at providing > a fix. > > I'll be extra careful at the patch format for V2. Thanks for explanation! Probably your patches are perfectly fine and should apply, although I must admit diffstat is often useful. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel