All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jamal Hadi Salim <jhs@mojatatu.com>
To: Hadar Hen Zion <hadarh@dev.mellanox.co.il>
Cc: Hadar Hen Zion <hadarh@mellanox.com>,
	"David S. Miller" <davem@davemloft.net>,
	netdev <netdev@vger.kernel.org>, Jiri Pirko <jiri@mellanox.com>,
	Jiri Benc <jbenc@redhat.com>,
	Shmulik Ladkani <shmulik.ladkani@gmail.com>,
	Tom Herbert <tom@herbertland.com>,
	Eric Dumazet <edumazet@google.com>,
	Cong Wang <xiyou.wangcong@gmail.com>,
	Amir Vadai <amirva@mellanox.com>,
	Or Gerlitz <ogerlitz@mellanox.com>, Amir Vadai <amir@vadai.me>
Subject: Re: [PATCH net-next V5 4/4] net/sched: Introduce act_tunnel_key
Date: Tue, 6 Sep 2016 08:44:55 -0400	[thread overview]
Message-ID: <6b4fc960-ee0a-c85a-13eb-fe33c36bef4a@mojatatu.com> (raw)
In-Reply-To: <CAJL1qvEP7NOMr1xGr1LkUDi9K96P+ZzU2m5D1q=uZMC-AyrKSw@mail.gmail.com>

On 16-09-06 07:03 AM, Hadar Hen Zion wrote:
> On Tue, Sep 6, 2016 at 1:49 PM, Jamal Hadi Salim <jhs@mojatatu.com> wrote:

>> Please verify by running a test and send a packet or two
>> and verify that stats are incremented (I know it may sound silly to
>> ask but it is important).
>
> Already tested that tc filter stats are working and incremented as expected :-)

I did see issue with per-cpu counters when i updated to rcu.
But the test was on a VM. So i changed skbmod to use global stats.
Maybe the kernel i was testing had issues.
Eric may have some insights.

cheers,
jamal

  reply	other threads:[~2016-09-06 12:45 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-04 10:55 [PATCH net-next V5 0/4] net/sched: ip tunnel metadata set/release/classify by using TC Hadar Hen Zion
2016-09-04 10:55 ` [PATCH net-next V5 1/4] net/ip_tunnels: Introduce tunnel_id_to_key32() and key32_to_tunnel_id() Hadar Hen Zion
2016-09-04 10:55 ` [PATCH net-next V5 2/4] net/dst: Utility functions to build dst_metadata without supplying an skb Hadar Hen Zion
2016-09-04 11:14   ` Sergei Shtylyov
2016-09-04 12:27     ` Hadar Hen Zion
2016-09-04 10:55 ` [PATCH net-next V5 3/4] net/sched: cls_flower: Classify packet in ip tunnels Hadar Hen Zion
2016-09-04 10:55 ` [PATCH net-next V5 4/4] net/sched: Introduce act_tunnel_key Hadar Hen Zion
2016-09-04 11:21   ` Shmulik Ladkani
2016-09-04 12:50   ` kbuild test robot
2016-09-04 18:19   ` Rosen, Rami
2016-09-05  6:45     ` Hadar Hen Zion
2016-09-06 10:49   ` Jamal Hadi Salim
2016-09-06 11:03     ` Hadar Hen Zion
2016-09-06 12:44       ` Jamal Hadi Salim [this message]
2016-09-06 14:11   ` Eric Dumazet
2016-09-06 14:25     ` Hadar Hen Zion

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6b4fc960-ee0a-c85a-13eb-fe33c36bef4a@mojatatu.com \
    --to=jhs@mojatatu.com \
    --cc=amir@vadai.me \
    --cc=amirva@mellanox.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=hadarh@dev.mellanox.co.il \
    --cc=hadarh@mellanox.com \
    --cc=jbenc@redhat.com \
    --cc=jiri@mellanox.com \
    --cc=netdev@vger.kernel.org \
    --cc=ogerlitz@mellanox.com \
    --cc=shmulik.ladkani@gmail.com \
    --cc=tom@herbertland.com \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.