From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BAD84C433EB for ; Tue, 21 Jul 2020 13:11:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9971D20717 for ; Tue, 21 Jul 2020 13:11:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="blBcqiTj" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728455AbgGUNLn (ORCPT ); Tue, 21 Jul 2020 09:11:43 -0400 Received: from lelv0142.ext.ti.com ([198.47.23.249]:49222 "EHLO lelv0142.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726687AbgGUNLn (ORCPT ); Tue, 21 Jul 2020 09:11:43 -0400 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id 06LDBXMr098550; Tue, 21 Jul 2020 08:11:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1595337093; bh=NELhrCg4CbssggoxMkMnomy3Bv2q7drp9uho36FblX4=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=blBcqiTjOEfc0HHVJevjQ0kvujaObADmAnVnWU4R5XroSjuvCag9Edwi6aGg1QQ74 LxnfM+pX2qrlZp8x2Y+/5u2Ohz/76e/9axUhc4eTENIv2j5NHUPoDmN2JURqrXZhkk SDwfk4AZw1G30ZaYwo0HslTZdsZxhOe+15Qgcin8= Received: from DLEE115.ent.ti.com (dlee115.ent.ti.com [157.170.170.26]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTP id 06LDBX34126462; Tue, 21 Jul 2020 08:11:33 -0500 Received: from DLEE104.ent.ti.com (157.170.170.34) by DLEE115.ent.ti.com (157.170.170.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Tue, 21 Jul 2020 08:11:33 -0500 Received: from fllv0039.itg.ti.com (10.64.41.19) by DLEE104.ent.ti.com (157.170.170.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Tue, 21 Jul 2020 08:11:33 -0500 Received: from [158.218.117.90] (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 06LDBTQw063801; Tue, 21 Jul 2020 08:11:32 -0500 Subject: Re: [PATCH] clocksource/drivers/timer-ti-dm: Fix suspend and resume for am3 and am4 To: Daniel Lezcano , Tony Lindgren , Thomas Gleixner CC: , , References: <20200713162601.6829-1-tony@atomide.com> <1ac1ac81-1335-8ba2-590c-8f57c2df1910@linaro.org> From: Carlos Hernandez Message-ID: <6b5fc12c-4da3-fc67-b9dd-bfca2ae870f2@ti.com> Date: Tue, 21 Jul 2020 09:11:29 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <1ac1ac81-1335-8ba2-590c-8f57c2df1910@linaro.org> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/17/20 6:29 AM, Daniel Lezcano wrote: > On 13/07/2020 18:26, Tony Lindgren wrote: >> Carlos Hernandez reported that we now have a suspend and >> resume regresssion on am3 and am4 compared to the earlier kernels. While >> suspend and resume works with v5.8-rc3, we now get errors with rtcwake: >> >> pm33xx pm33xx: PM: Could not transition all powerdomains to target state >> ... >> rtcwake: write error >> >> This is because we now fail to idle the system timer clocks that the >> idle code checks and the error gets propagated to the rtcwake. >> >> Turns out there are several issues that need to be fixed: >> >> 1. Ignore no-idle and no-reset configured timers for the ti-sysc >> interconnect target driver as otherwise it will keep the system timer >> clocks enabled >> >> 2. Toggle the system timer functional clock for suspend for am3 and am4 >> (but not for clocksource on am3) >> >> 3. Only reconfigure type1 timers in dmtimer_systimer_disable() >> >> 4. Use of_machine_is_compatible() instead of of_device_is_compatible() >> for checking the SoC type >> >> Fixes: 52762fbd1c47 ("clocksource/drivers/timer-ti-dm: Add clockevent and clocksource support") >> Reported-by: Carlos Hernandez >> Signed-off-by: Tony Lindgren >> --- Tested-by: Carlos Hernandez > Carlos, were you able to test this patch ? > -- Carlos From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DB6CC433E0 for ; Tue, 21 Jul 2020 13:13:10 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6A01020717 for ; Tue, 21 Jul 2020 13:13:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="BA5Ea8HP"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ti.com header.i=@ti.com header.b="blBcqiTj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6A01020717 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=UkmLpLN7Xvv+cvk0vzruDrydwPDntDWReFKTSmG120s=; b=BA5Ea8HPEgHO1oEeQ5vwFLMHC kdZH6aR4QOHM5hz6MneqvljDXK4MK4mWoOvVCt7baWh0+s4OqWvaExPrGXTK/SQ9HhuaQwkz4HcAV dxcvO7OQM32yQ8pdWZLxbndDelqpoz22Bx2pLM0Z46LtySdmOrhrYWMrbUFM55gF2Uh5SAYi/Cw+0 mix/85SgHYbJx+27VnhNEZgAiPiAewT1OH81Jlyooj/Rl0CnrTHhD/qURdHiD/M5k4hwdsHCJ5A3Y CdocNo8WdqAXewCTHd+WDuih6vGhAfglkASC1sh4o+cwYscIsPkhrb+sPSF09ddYCFNM30s/liu/Z dlSLS3KTQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jxs3b-0001KX-Ac; Tue, 21 Jul 2020 13:11:43 +0000 Received: from lelv0142.ext.ti.com ([198.47.23.249]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jxs3Z-0001JF-0r for linux-arm-kernel@lists.infradead.org; Tue, 21 Jul 2020 13:11:42 +0000 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id 06LDBXMr098550; Tue, 21 Jul 2020 08:11:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1595337093; bh=NELhrCg4CbssggoxMkMnomy3Bv2q7drp9uho36FblX4=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=blBcqiTjOEfc0HHVJevjQ0kvujaObADmAnVnWU4R5XroSjuvCag9Edwi6aGg1QQ74 LxnfM+pX2qrlZp8x2Y+/5u2Ohz/76e/9axUhc4eTENIv2j5NHUPoDmN2JURqrXZhkk SDwfk4AZw1G30ZaYwo0HslTZdsZxhOe+15Qgcin8= Received: from DLEE115.ent.ti.com (dlee115.ent.ti.com [157.170.170.26]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTP id 06LDBX34126462; Tue, 21 Jul 2020 08:11:33 -0500 Received: from DLEE104.ent.ti.com (157.170.170.34) by DLEE115.ent.ti.com (157.170.170.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Tue, 21 Jul 2020 08:11:33 -0500 Received: from fllv0039.itg.ti.com (10.64.41.19) by DLEE104.ent.ti.com (157.170.170.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Tue, 21 Jul 2020 08:11:33 -0500 Received: from [158.218.117.90] (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 06LDBTQw063801; Tue, 21 Jul 2020 08:11:32 -0500 Subject: Re: [PATCH] clocksource/drivers/timer-ti-dm: Fix suspend and resume for am3 and am4 To: Daniel Lezcano , Tony Lindgren , Thomas Gleixner References: <20200713162601.6829-1-tony@atomide.com> <1ac1ac81-1335-8ba2-590c-8f57c2df1910@linaro.org> From: Carlos Hernandez Message-ID: <6b5fc12c-4da3-fc67-b9dd-bfca2ae870f2@ti.com> Date: Tue, 21 Jul 2020 09:11:29 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <1ac1ac81-1335-8ba2-590c-8f57c2df1910@linaro.org> Content-Language: en-US X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200721_091141_153080_36D67C17 X-CRM114-Status: GOOD ( 15.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 7/17/20 6:29 AM, Daniel Lezcano wrote: > On 13/07/2020 18:26, Tony Lindgren wrote: >> Carlos Hernandez reported that we now have a suspend and >> resume regresssion on am3 and am4 compared to the earlier kernels. While >> suspend and resume works with v5.8-rc3, we now get errors with rtcwake: >> >> pm33xx pm33xx: PM: Could not transition all powerdomains to target state >> ... >> rtcwake: write error >> >> This is because we now fail to idle the system timer clocks that the >> idle code checks and the error gets propagated to the rtcwake. >> >> Turns out there are several issues that need to be fixed: >> >> 1. Ignore no-idle and no-reset configured timers for the ti-sysc >> interconnect target driver as otherwise it will keep the system timer >> clocks enabled >> >> 2. Toggle the system timer functional clock for suspend for am3 and am4 >> (but not for clocksource on am3) >> >> 3. Only reconfigure type1 timers in dmtimer_systimer_disable() >> >> 4. Use of_machine_is_compatible() instead of of_device_is_compatible() >> for checking the SoC type >> >> Fixes: 52762fbd1c47 ("clocksource/drivers/timer-ti-dm: Add clockevent and clocksource support") >> Reported-by: Carlos Hernandez >> Signed-off-by: Tony Lindgren >> --- Tested-by: Carlos Hernandez > Carlos, were you able to test this patch ? > -- Carlos _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel