From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B143C2B9F8 for ; Tue, 25 May 2021 15:22:03 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 536AB61159 for ; Tue, 25 May 2021 15:22:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 536AB61159 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.132253.246750 (Exim 4.92) (envelope-from ) id 1llYsR-0003pR-Q1; Tue, 25 May 2021 15:21:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 132253.246750; Tue, 25 May 2021 15:21:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1llYsR-0003pK-N4; Tue, 25 May 2021 15:21:51 +0000 Received: by outflank-mailman (input) for mailman id 132253; Tue, 25 May 2021 15:21:50 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1llYsQ-0003pD-J4 for xen-devel@lists.xenproject.org; Tue, 25 May 2021 15:21:50 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 1d1098a8-eeae-4015-a265-304030f3b4f9; Tue, 25 May 2021 15:21:49 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 53302AB71; Tue, 25 May 2021 15:21:48 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1d1098a8-eeae-4015-a265-304030f3b4f9 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1621956108; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OTo01Y6FZrlX65+6h/BXe1jMCyZ7OtMZf5FvKE92ORQ=; b=JW6ecItZpWcZWhvboF0cMGUrEBkhnp++Z3BQXrBihfkeXnfA24Hw7eSfXDab/T3D3ZKpoT +2yjydvAHPRDfMnbc8XNiBRmU9ESiL9QwnaYYF+RT3dPwb6yIvF0/vbcy6jMaUXpZ59QbM S/4pveBu3Ed5f0UOIPwNI03bX38blCA= Subject: Re: [PATCH 3/3] firmware/shim: UNSUPPORTED=n To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Dario Faggioli , George Dunlap Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu , Ian Jackson , Stefano Stabellini References: <19695ffc-34d8-b682-b092-668f872d4e57@suse.com> From: Jan Beulich Message-ID: <6b74b1de-5ec4-09dc-ba1e-821025402d36@suse.com> Date: Tue, 25 May 2021 17:21:43 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.10.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 25.05.2021 16:39, Roger Pau Monné wrote: > On Fri, Apr 30, 2021 at 04:45:03PM +0200, Jan Beulich wrote: >> We shouldn't default to include any unsupported code in the shim. Mark >> the setting as off, replacing the ARGO specification. This points out >> anomalies with the scheduler configuration: Unsupported schedulers >> better don't default to Y in release builds (like is already the case >> for ARINC653). Without these adjustments, the shim would suddenly build >> with RTDS as its default scheduler. >> >> Signed-off-by: Jan Beulich > > Acked-by: Roger Pau Monné Thanks. >> ---- >> I'm certainly open to consider alterations on the sched/Kconfig >> adjustments, but _something_ needs to be done there. In particular I'm >> puzzled to find the NULL scheduler marked unsupported. Clearly with >> the shim defaulting to it, it must be supported at least there. > > Indeed, I think we should mark NULL as supported for the shim usage > (which is very specific anyway, because it manages a single domain). George, Dario, what is your position towards null's support status? >> --- a/xen/common/sched/Kconfig >> +++ b/xen/common/sched/Kconfig >> @@ -16,7 +16,7 @@ config SCHED_CREDIT2 >> >> config SCHED_RTDS >> bool "RTDS scheduler support (UNSUPPORTED)" if UNSUPPORTED >> - default y >> + default DEBUG > > I would also be fine with leaving the default as 'n' for unsupported > features. So would I be; I merely didn't want to make too big of step by going straight from y to n. George, Dario - you're the maintainers of this code (and I'd need your ack anyway), do you have any preference? >> @@ -31,7 +31,7 @@ config SCHED_ARINC653 >> >> config SCHED_NULL >> bool "Null scheduler support (UNSUPPORTED)" if UNSUPPORTED >> - default y >> + default PV_SHIM || DEBUG > > Do we need the pvshim_defconfig to set CONFIG_SCHED_NULL=y after this? I don't think so, the default will be y for it. Explicit settings are needed only when we want a non-default value. Jan