From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by smtp.lore.kernel.org (Postfix) with ESMTP id 424C0C433EF for ; Fri, 8 Jul 2022 10:31:12 +0000 (UTC) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4BD9C406B4; Fri, 8 Jul 2022 12:31:11 +0200 (CEST) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2051.outbound.protection.outlook.com [40.107.94.51]) by mails.dpdk.org (Postfix) with ESMTP id 3D3F84021E for ; Fri, 8 Jul 2022 12:31:09 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KJtE31ht1YW8jgS286ZpXPEUIkhleykRjSGbO6YmD7/uzEigmziUWRhJkuCOt58U4MVMcX24ld76z2SG5sgtQvE7cDVK3TtfsR2NFYrCNbzS/F7QlaD+P4orgKYoWGmYnfEFXO8e0EK4bjvEGqc+PypzdqxycV0gSuMkzw+TQNBLKMKMQq/KKE+8IJ08VzN+eTXzKUnYCqmBqoOHrmwQyNq6iIPYaLNnkE3qwJkL2LB3qOxDRIKX79ps2+mULIZDh7/UXOHVQK8O8OCoWpuEjUF+REeoQJoOPbeISo6IEHWIwUX3A06X26+QEWoGFpviYC/ttvQk31MVTPgbKY4Qag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mwEMhC9zgnfH6OtrZIz1rFCybkU1kmG4b0Xm93+f7mw=; b=e8b8tkZDDoda4iMFNOrOoqGabkdqlJrOzXtanQ4ebCd2oTi2NMqHgQQarqbziiOhrtfrv6SZu6azZ/lhMjlYZSGb22XGi9OZClcJ8AoedP+EBVuc1tNLDHMhyZVmK2AIoX6GlfWCHzufBizqn0B3K3fIsaGcyb3MXf4ljh53pu3NBgJyfSrjL4QG0whI0tlJRCuAcEa9QciAMxCaNNv5Bw6fNLCVCvzQDw0+fcDK/bZA8vm8U3aS5Ag4rcwbUCbt49DB0O5tVfGIogKtTuzJ2tyNlP+p6FqNrt5Ofuz7amduSPNrwnlaikI2Q33sxI1/MPJ6Ct4EgLQS12dWRaELoA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.80.198) smtp.rcpttodomain=intel.com smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mwEMhC9zgnfH6OtrZIz1rFCybkU1kmG4b0Xm93+f7mw=; b=IEd4EWPPGQlHfxmMKX4nrTsaCyfTuvIdIqhdZcUOJP0+0+I1kQaZu+yy8j/xJi6gZpq7Aicm9xIUr61gxJRJ5gc3NSNNoBRokA/9/+gwYrIHZVaclx/Y1HENh6avcNtXVC+tFtmLPnWztvh87lm5bdc0lATdvuFXuLw1SQkDSZY= Received: from DM6PR06CA0073.namprd06.prod.outlook.com (2603:10b6:5:336::6) by DM8PR02MB8229.namprd02.prod.outlook.com (2603:10b6:8:e::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.16; Fri, 8 Jul 2022 10:31:06 +0000 Received: from DM3NAM02FT061.eop-nam02.prod.protection.outlook.com (2603:10b6:5:336:cafe::8e) by DM6PR06CA0073.outlook.office365.com (2603:10b6:5:336::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.17 via Frontend Transport; Fri, 8 Jul 2022 10:31:06 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.80.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.80.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.80.198; helo=xir-pvapexch01.xlnx.xilinx.com; pr=C Received: from xir-pvapexch01.xlnx.xilinx.com (149.199.80.198) by DM3NAM02FT061.mail.protection.outlook.com (10.13.4.230) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5417.15 via Frontend Transport; Fri, 8 Jul 2022 10:31:06 +0000 Received: from xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) by xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Fri, 8 Jul 2022 11:31:04 +0100 Received: from smtp.xilinx.com (172.21.105.198) by xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Fri, 8 Jul 2022 11:31:04 +0100 Envelope-to: weiyuanx.li@intel.com, lihuisong@huawei.com, andrew.rybchenko@oktetlabs.ru, dev@dpdk.org, thomas@monjalon.net, huangdaode@huawei.com, liudongdong3@huawei.com Received: from [10.71.116.113] (port=50296) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1o9lGK-0000k7-Gn; Fri, 08 Jul 2022 11:31:04 +0100 Message-ID: <6b80741c-0093-b15d-6318-d5adefb19806@xilinx.com> Date: Fri, 8 Jul 2022 11:31:03 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH V2] app/testpmd: fix display types failure when query RSS rule Content-Language: en-US To: "Li, WeiyuanX" , Huisong Li , "andrew.rybchenko@oktetlabs.ru" , "dev@dpdk.org" CC: "thomas@monjalon.net" , "huangdaode@huawei.com" , "liudongdong3@huawei.com" References: <20220707105044.10567-1-lihuisong@huawei.com> <20220708014159.13499-1-lihuisong@huawei.com> From: Ferruh Yigit In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4f7476ee-2e01-4f34-6651-08da60ccf748 X-MS-TrafficTypeDiagnostic: DM8PR02MB8229:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YOI+lJ6zeT6UUkXrkaR5KxmD4l1mAuqn2BzN90aKBf0YnbSwlDdW19FuItnE++RyuCFzBcr2omi170hOzmKvsLnksyt1isfGdcltZSBvi9nMM7Ua/fkF4CP+JjpqstsjmrJF4INJT+7Hi2YQ7Myr+xM8cygmQYbK+jfd/KStReckXFkE9bZ8GeoKT4ESANX4y9As50FxB7VAf1hJn01fIIK2Gszh9mu371AuO64eE+ni4zzTEmyw2vGwN6EzUS75tf2T9yVqdciLCusa6fk/nE/fF84Bq+s/CX83tnYIrGzrUjD51azruWGgm7poAr6cIkfjsWBtxRfhDNO33UneKm0yMhtMO82fFhJL6DMbocnOfdicAWzY4HJrO3/LVeXcktJkTbalgwxcDcqyCW6mb/h67w4rU5BsdrnuCOQi58SUCXcKIqV/MPbg+L35+S4HKBKoUwS6IqZv1SVGdOtIXj8psj/nPxTZ2RxpYyTzrbP8zem4e5Yi6ZxuDMmvF2wjEnZubfhpjgTdLkdPUHnQB8DaRJd2pDHzzU9BDaXMQTTEIxpxW58/xSAYE0Z4s58in0NKm1uaxlnNHbm1zWN0L/81etGUcHvGhm+JFJE/P0up46z9inF2I9mGh4G1qgf8joWNPaY34nJ8MMAnlpUhWXVrp7yUOyGaVWNkfG4fjkMPx0fD0r/oxL3Ls20TmfNbjFWeZxIzgEPGZJvHFJIUQoBeeL6BobLCNA13tMciK4ClhwLmNsT4A7b9lz2lAeCmRemCxtlIPYdbT1n7xWK98BfP/2RpwDYFwvyg77ceScCb8CXE8ZZwE+2CMi/SakbA9TmXSmXCEZx0jFgSgQRQsLDXDZyiztHvKAWPP/Uht18RfeCG6iAeolBIyhqgXw6MOCNUhReQ3yLtC7GtHdjfUw== X-Forefront-Antispam-Report: CIP:149.199.80.198; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:xir-pvapexch01.xlnx.xilinx.com; PTR:unknown-80-198.xilinx.com; CAT:NONE; SFS:(13230016)(4636009)(136003)(396003)(376002)(346002)(39860400002)(40470700004)(46966006)(36840700001)(40480700001)(426003)(54906003)(7636003)(8676002)(83380400001)(336012)(186003)(36756003)(4326008)(70206006)(316002)(110136005)(31686004)(47076005)(36860700001)(82740400003)(356005)(70586007)(44832011)(26005)(8936002)(9786002)(2616005)(2906002)(40460700003)(41300700001)(478600001)(31696002)(5660300002)(82310400005)(53546011)(50156003)(21314003)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jul 2022 10:31:06.2471 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4f7476ee-2e01-4f34-6651-08da60ccf748 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.80.198]; Helo=[xir-pvapexch01.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: DM3NAM02FT061.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR02MB8229 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 7/8/2022 6:32 AM, Li, WeiyuanX wrote: >> -----Original Message----- >> From: Huisong Li >> Sent: Friday, July 8, 2022 9:42 AM >> To: ferruh.yigit@xilinx.com; andrew.rybchenko@oktetlabs.ru; >> dev@dpdk.org >> Cc: thomas@monjalon.net; Li, WeiyuanX ; >> huangdaode@huawei.com; liudongdong3@huawei.com; >> lihuisong@huawei.com >> Subject: [PATCH V2] app/testpmd: fix display types failure when query RSS >> rule >> >> Now testpmd fails to display types when query RSS rule. The failure is >> because the '\n' character is missing at the end of the function >> 'rss_config_display()'. Actually, all places calling 'xxx_types_display()' >> need to '\n'. So this patch moves '\n' to the inside of these function. >> Bugzilla ID: 1048 >> Fixes: 534988c490f1 ("app/testpmd: unify RSS types display") >> Fixes: 44a37f3cffe0 ("app/testpmd: compact RSS types output") >> >> --- >> v2: >> - move '\n' to the inside of 'xxx_types_display()'. >> >> Signed-off-by: Huisong Li > > Tested-by: Weiyuan Li Reviewed-by: Ferruh Yigit Applied to dpdk-next-net/main, thanks.