From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75436C10F13 for ; Mon, 8 Apr 2019 10:44:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3FBE420883 for ; Mon, 8 Apr 2019 10:44:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726706AbfDHKoh (ORCPT ); Mon, 8 Apr 2019 06:44:37 -0400 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:46198 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726606AbfDHKoh (ORCPT ); Mon, 8 Apr 2019 06:44:37 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 86D2C15AD; Mon, 8 Apr 2019 03:44:36 -0700 (PDT) Received: from [10.37.12.66] (unknown [10.37.12.66]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 742903F718; Mon, 8 Apr 2019 03:44:34 -0700 (PDT) Subject: Re: [PATCH v4 2/4] coresight: replicator: Add new device id for static replicator To: leo.yan@linaro.org, mathieu.poirier@linaro.org, robh+dt@kernel.org, mark.rutland@arm.com, alexander.shishkin@linux.intel.com, shiwanglai@hisilicon.com, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20190406112145.15184-1-leo.yan@linaro.org> <20190406112145.15184-3-leo.yan@linaro.org> From: Suzuki K Poulose Message-ID: <6b862aa8-1b50-61bf-6894-978ecd1a964b@arm.com> Date: Mon, 8 Apr 2019 11:46:52 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20190406112145.15184-3-leo.yan@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/06/2019 12:21 PM, Leo Yan wrote: > This patch adds a device id for the new static replicator compatible > string; it changes the driver name from "coresight-replicator" to > "coresight-static-replicator" as well. > > Signed-off-by: Leo Yan > --- > drivers/hwtracing/coresight/coresight-replicator.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/hwtracing/coresight/coresight-replicator.c b/drivers/hwtracing/coresight/coresight-replicator.c > index 4e0da85efd2d..e6a03642bbdb 100644 > --- a/drivers/hwtracing/coresight/coresight-replicator.c > +++ b/drivers/hwtracing/coresight/coresight-replicator.c > @@ -285,13 +285,14 @@ static const struct dev_pm_ops replicator_dev_pm_ops = { > > static const struct of_device_id static_replicator_match[] = { > {.compatible = "arm,coresight-replicator"}, > + {.compatible = "arm,coresight-static-replicator"}, > {} As mentioned in the previous patch, please could you add a warning if you encounter the old binding, mentioning that it is OBSOLETE. pr_warn_once() is sufficient. Otherwise, looks good. Suzuki From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05AB8C10F13 for ; Mon, 8 Apr 2019 10:44:47 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C9AF620883 for ; Mon, 8 Apr 2019 10:44:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="VVOYPOmx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C9AF620883 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Cc:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=kllwwL3LfSJFWyeTyVtU7RNhKshx4Xh/bLJs/r6DIuo=; b=VVOYPOmxKiytbY/uA5Ger9k7l gNrkqD9Meuywc2nEbgvIhrEuBGROCF1bSV3HgJ5kuMtB2GKRACQ8xhNlCA7MjNbq3GCu2bDe/cjIT vdB1E33HA2Q6nE23IksArB/CCJxWx8SuWX1rIcSq1VJwaPXUAPfOdKN1Ph+sLQdloexTMMwmdackD kKmBbyEf6VYFDvgGgaDqqoWj0efMuIRMV9dnRS1nFRUaoygrtdFxcQK5MP+2K8A8b8jIu1YaXXFCC Gd0Pei6wqwPzZ6UpHV9jt/+x3WkjMUmBdF1BaI5+csgdgFyfa+G02nRjRafjevGhjBDPVbrmeyhcD JHKzspaiQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hDRla-0006sY-P0; Mon, 08 Apr 2019 10:44:42 +0000 Received: from foss.arm.com ([217.140.101.70]) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hDRlU-0006n3-T8 for linux-arm-kernel@lists.infradead.org; Mon, 08 Apr 2019 10:44:39 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 86D2C15AD; Mon, 8 Apr 2019 03:44:36 -0700 (PDT) Received: from [10.37.12.66] (unknown [10.37.12.66]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 742903F718; Mon, 8 Apr 2019 03:44:34 -0700 (PDT) Subject: Re: [PATCH v4 2/4] coresight: replicator: Add new device id for static replicator To: leo.yan@linaro.org, mathieu.poirier@linaro.org, robh+dt@kernel.org, mark.rutland@arm.com, alexander.shishkin@linux.intel.com, shiwanglai@hisilicon.com, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20190406112145.15184-1-leo.yan@linaro.org> <20190406112145.15184-3-leo.yan@linaro.org> From: Suzuki K Poulose Message-ID: <6b862aa8-1b50-61bf-6894-978ecd1a964b@arm.com> Date: Mon, 8 Apr 2019 11:46:52 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20190406112145.15184-3-leo.yan@linaro.org> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190408_034436_994712_694B6FE0 X-CRM114-Status: GOOD ( 19.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 04/06/2019 12:21 PM, Leo Yan wrote: > This patch adds a device id for the new static replicator compatible > string; it changes the driver name from "coresight-replicator" to > "coresight-static-replicator" as well. > > Signed-off-by: Leo Yan > --- > drivers/hwtracing/coresight/coresight-replicator.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/hwtracing/coresight/coresight-replicator.c b/drivers/hwtracing/coresight/coresight-replicator.c > index 4e0da85efd2d..e6a03642bbdb 100644 > --- a/drivers/hwtracing/coresight/coresight-replicator.c > +++ b/drivers/hwtracing/coresight/coresight-replicator.c > @@ -285,13 +285,14 @@ static const struct dev_pm_ops replicator_dev_pm_ops = { > > static const struct of_device_id static_replicator_match[] = { > {.compatible = "arm,coresight-replicator"}, > + {.compatible = "arm,coresight-static-replicator"}, > {} As mentioned in the previous patch, please could you add a warning if you encounter the old binding, mentioning that it is OBSOLETE. pr_warn_once() is sufficient. Otherwise, looks good. Suzuki _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel