From: Sreedhar Kodali <srkodali-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
To: "Hefty, Sean" <sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
pradeeps-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org,
sithirug-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org,
linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: RE: [PATCH v3 3/4] rsockets: distribute completion queue vectors
Date: Thu, 11 Sep 2014 18:01:44 +0530 [thread overview]
Message-ID: <6b90e2e7f33f9bfe760dede56ef3aacf@imap.linux.ibm.com> (raw)
In-Reply-To: <324d0cae53cff595c6949fc93884869f-FJGp5E75HVmZamtmwQBW5tBPR1lH4CV8@public.gmane.org>
On 2014-09-09 18:02, Sreedhar Kodali wrote:
> On 2014-09-08 21:24, Hefty, Sean wrote:
>>> @@ -548,6 +550,37 @@ void rs_configure(void)
>>> (void) fscanf(f, "%hu", &restart_onintr);
>>> fclose(f);
>>> }
>>> +
>>> + if ((f = fopen(RS_CONF_DIR "/comp_vector", "r"))) {
>>> + char vbuf[256];
>>> + char *vptr;
>>> + vptr = fgets(vbuf, sizeof(vbuf), f);
>>> + fclose(f);
>>> + if (vptr) {
>>> + char *tok, *save, *tmp, *str, *tok2;
>>> + int lvect, uvect, vect;
>>> +
>>> + for (str = vptr; ; str = NULL) {
>>> + tok = strtok_r(str, ",", &save);
>>> + if (tok == NULL) {
>>> + break;
>>> + }
>>> + if (!(tmp = strpbrk(tok, "-"))) {
>>> + lvect = uvect = atoi(tok);
>>> + } else {
>>> + tok2 = tmp + 1;
>>> + *tmp = '\0';
>>> + lvect = atoi(tok);
>>> + uvect = atoi(tok2);
>>> + }
>>> + lvect = (lvect < 0) ? 0 : ((lvect > 63) ? 63 :
>>> lvect);
>>> + uvect = (uvect < 0) ? 0 : ((uvect > 63) ? 63 :
>>> uvect);
>>> + for (vect = lvect; vect <= uvect; vect++) {
>>> + comp_vector_mask |= ((uint64_t)1 << vect);
>>> + }
>>> + }
>>> + }
>>> + }
>>
>> Please isolate this functionality into its own function.
>>
>> - Sean
>
> Hi Sean,
>
> I will make this into a separate function in the revised patch that is
> being worked out.
>
> Thank You.
>
> - Sreedhar
>
Hi Sean,
Sent the revised patch v4 with your suggestions incorporated. Kindly
have a look at them.
Thank You.
- Sreedhar
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-rdma"
>> in
>> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma"
> in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2014-09-11 12:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-08 12:48 [PATCH v3 3/4] rsockets: distribute completion queue vectors Sreedhar Kodali
[not found] ` <33dc77c8c6006b5ac067e6c6f485df60-FJGp5E75HVmZamtmwQBW5tBPR1lH4CV8@public.gmane.org>
2014-09-08 15:54 ` Hefty, Sean
[not found] ` <1828884A29C6694DAF28B7E6B8A8237399DCCC85-P5GAC/sN6hkd3b2yrw5b5LfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-09-09 12:32 ` Sreedhar Kodali
[not found] ` <324d0cae53cff595c6949fc93884869f-FJGp5E75HVmZamtmwQBW5tBPR1lH4CV8@public.gmane.org>
2014-09-11 12:31 ` Sreedhar Kodali [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6b90e2e7f33f9bfe760dede56ef3aacf@imap.linux.ibm.com \
--to=srkodali-23vcf4htsmix0ybbhkvfkdbpr1lh4cv8@public.gmane.org \
--cc=linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=pradeeps-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org \
--cc=sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=sithirug-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.