From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40188) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ejAya-0000XQ-EM for qemu-devel@nongnu.org; Tue, 06 Feb 2018 16:40:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ejAyX-0001mv-8q for qemu-devel@nongnu.org; Tue, 06 Feb 2018 16:40:28 -0500 Received: from chuckie.co.uk ([82.165.15.123]:43721 helo=s16892447.onlinehome-server.info) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ejAyW-0001cn-N7 for qemu-devel@nongnu.org; Tue, 06 Feb 2018 16:40:25 -0500 References: <20180203103727.26457-1-mark.cave-ayland@ilande.co.uk> <20180203103727.26457-2-mark.cave-ayland@ilande.co.uk> <1f833824-3bb4-3ac7-71c4-4d2db47b82f5@redhat.com> From: Mark Cave-Ayland Message-ID: <6ba27e8a-6970-2113-0fb5-8b9620fa3133@ilande.co.uk> Date: Tue, 6 Feb 2018 21:40:00 +0000 MIME-Version: 1.0 In-Reply-To: <1f833824-3bb4-3ac7-71c4-4d2db47b82f5@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 01/10] cuda: do not use old_mmio accesses List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laurent Vivier , qemu-devel@nongnu.org On 05/02/18 14:17, Laurent Vivier wrote: > On 03/02/2018 11:37, Mark Cave-Ayland wrote: >> Signed-off-by: Mark Cave-Ayland >> --- >> hw/misc/macio/cuda.c | 40 ++++++++-------------------------------- >> 1 file changed, 8 insertions(+), 32 deletions(-) >> >> diff --git a/hw/misc/macio/cuda.c b/hw/misc/macio/cuda.c >> index 008d8bd4d5..23b7e0f5b0 100644 >> --- a/hw/misc/macio/cuda.c >> +++ b/hw/misc/macio/cuda.c >> @@ -275,7 +275,7 @@ static void cuda_delay_set_sr_int(CUDAState *s) >> timer_mod(s->sr_delay_timer, expire); >> } >> >> -static uint32_t cuda_readb(void *opaque, hwaddr addr) >> +static uint64_t cuda_read(void *opaque, hwaddr addr, unsigned size) >> { >> CUDAState *s = opaque; >> uint32_t val; >> @@ -350,7 +350,7 @@ static uint32_t cuda_readb(void *opaque, hwaddr addr) >> return val; >> } >> >> -static void cuda_writeb(void *opaque, hwaddr addr, uint32_t val) >> +static void cuda_write(void *opaque, hwaddr addr, uint64_t val, unsigned size) >> { >> CUDAState *s = opaque; >> >> @@ -780,38 +780,14 @@ static void cuda_receive_packet_from_host(CUDAState *s, >> } >> } >> >> -static void cuda_writew (void *opaque, hwaddr addr, uint32_t value) >> -{ >> -} >> - >> -static void cuda_writel (void *opaque, hwaddr addr, uint32_t value) >> -{ >> -} >> - >> -static uint32_t cuda_readw (void *opaque, hwaddr addr) >> -{ >> - return 0; >> -} >> - >> -static uint32_t cuda_readl (void *opaque, hwaddr addr) >> -{ >> - return 0; >> -} >> - >> static const MemoryRegionOps cuda_ops = { >> - .old_mmio = { >> - .write = { >> - cuda_writeb, >> - cuda_writew, >> - cuda_writel, >> - }, >> - .read = { >> - cuda_readb, >> - cuda_readw, >> - cuda_readl, >> - }, >> - }, >> + .read = cuda_read, >> + .write = cuda_write, >> .endianness = DEVICE_NATIVE_ENDIAN, > > As CUDA Macintoshes are all big-endian, I think you should use > DEVICE_BIG_ENDIAN here, except if you are aware of a little-endian > machine using it in little-endian mode. Yes that's true, I will give it a test to make sure that everything still works as expected. Any thoughts on the rest of the patchset? I haven't finished porting Ben's PMU patches over to use it, however things are looking fairly good with progress so far. ATB, Mark.