From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934517AbeAIR0b (ORCPT + 1 other); Tue, 9 Jan 2018 12:26:31 -0500 Received: from mail-eopbgr00136.outbound.protection.outlook.com ([40.107.0.136]:5966 "EHLO EUR02-AM5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754053AbeAIR02 (ORCPT ); Tue, 9 Jan 2018 12:26:28 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=aryabinin@virtuozzo.com; Subject: Re: [PATCH v3 2/2] mm/memcg: Consolidate mem_cgroup_resize_[memsw]_limit() functions. To: Shakeel Butt Cc: Andrew Morton , Johannes Weiner , Vladimir Davydov , Cgroups , Linux MM , LKML , Michal Hocko References: <20171220135329.GS4831@dhcp22.suse.cz> <20180109165815.8329-1-aryabinin@virtuozzo.com> <20180109165815.8329-2-aryabinin@virtuozzo.com> From: Andrey Ryabinin Message-ID: <6ba40354-10d8-7955-7932-9dcd05ed5977@virtuozzo.com> Date: Tue, 9 Jan 2018 20:26:33 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [195.214.232.6] X-ClientProxiedBy: HE1PR05CA0264.eurprd05.prod.outlook.com (2603:10a6:3:fc::16) To AM4PR08MB2819.eurprd08.prod.outlook.com (2603:10a6:205:d::25) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0db1fcfb-69fc-4d17-9f42-08d557861c1a X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(4534020)(4602075)(7168020)(4627115)(201703031133081)(201702281549075)(5600026)(4604075)(2017052603307)(7153060)(7193020);SRVR:AM4PR08MB2819; X-Microsoft-Exchange-Diagnostics: 1;AM4PR08MB2819;3:RN3xhxhY6FM7wn8GGDg8W7T+32ap9lLssGSk3/aDYwcPPZpKK0oQeNlX04acQcQImKUxqVTXFVFl8B3QQWy/Y6qsLbcwcAUs1wQYq49N2L5pIRI9YBs69CD9wr3TiFcygObBwY8A3RhfRIgd7mrmBNg+d3L6G4BLQsm92HJRKVYBXbQ6QNw7TQB/3SYDy/GHLU6MnPaqun0IvBb1+Qjs5EnTpBtQP1TsYFQD3cnn7PZS64mC7bM4tLBokW2b6SEn;25:9Yqo+Vfn6GSHgxWw5I8KNg3G7CBa4VO5eop1J1EhZW0ZFCTZMqr9FDftJhYsknf82hik2/59guBaZEXbBfdCfXaSApdDq5QN8AfqJXz61EW+sbTnW6lAT28FQAUFUTImzzRqxjvDCgqQPNxeiCvuGjBtlgxmD+Vd4CskVKU55ODg2WUgBElwSY1G0bQ50zRPESQocu59molZQxacQZPi8+F0PWdZTihm06AfIlSlAYEmS5YSoisMPuFsmuah9PiWkBAZNPGar0IFp76UEQk+IuzdSvBiEgAxfl/5qjZl6ReVP06BreNZZfAqM+tX1YT5nZ8u7vQlhgU8Svnqc7hp/g==;31:cbpJ6lMv//UMW1t0IFEvS21GBa4gcJ3HjirppE7JgMfAXeYlYGJmw+kh85TdQVs5uUUVVFFD6yzAw7aNl3cqWZnxJnFgzrBZHv6YAxR4oUjMhUxOeK3jvXKmbI7Tzd/0/nOXN42QN+PopnT/1jsYgXtS22oENlZYqsqX8sDEzsacFudgGeCLiEvhhxfjdd43KfICythSxl+DmT3PKZIQoWXPKs1HQSLGcbUkPAgGLUA= X-MS-TrafficTypeDiagnostic: AM4PR08MB2819: X-Microsoft-Exchange-Diagnostics: 1;AM4PR08MB2819;20:7qYFjl9rg1Mxk4rNXDaBhiOdgMU6GMmwME1dJpT5mjfHR2UbRArHz1Fh9c62BNFlQbvC2LHFrvGg4tqVNbMhxL5odF2blx5nMsBqErHDEnEj9Bd9RUHuM8706b+iyGA18i2E+aT3epmLdE0DHTIpBrRSXDeXELLZ72hwO0n/Y0LbtCLvWKY4MHbm2PGZOAvC/FL//aUu4OW4aTDxNPtsRm849ECih3c7E7Eh5GHpOT1Ylpmh41NrHl8IOs2IlMFM5kQMlLvIw1ZonyNDL07rr1UitXqbIxYEtOnpgjxKp9ev4sZrKPjicG1uurUbscZVRbqBaqjJmgTE+LMrJqmzhXD3PcffayzOiKIzZiZtouv9Za+dNAllPpLaQYR1bPVjtsIid0ZrrHgWyWznFof56vHErVzBcs+3qjM4AiQbcGc=;4:kDwHVpZXIZSuB8njwhR4MgZBidO98E9VQuoMoOq6AYpGh7puI4PsJD9KXGyLEcjWPopXedEbF+Ic7QaxYBxPpJOnCK4mEh6a8acBSe74m/s9y/vn8S9fSRaN2z2GlZjHfndcRg5FpvfH6CdkzOqGwjeldE4KN/+ZwO4mxGwDhklYdo8BBT6jCzh46aigpez76x2XAZL7NVeEObdag/gFoQlAwNG6IuhAfQGNU5hjcmtFV+WT75fDIJqD7I15iKZ6V/AVjtnz6ftG38CE9V01hw== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040470)(2401047)(8121501046)(5005006)(3231023)(944501075)(3002001)(10201501046)(93006095)(93001095)(6041268)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123558120)(20161123562045)(20161123564045)(6072148)(201708071742011);SRVR:AM4PR08MB2819;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:AM4PR08MB2819; X-Forefront-PRVS: 0547116B72 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(6049001)(346002)(366004)(39850400004)(376002)(39380400002)(396003)(199004)(189003)(24454002)(68736007)(54906003)(230700001)(7736002)(478600001)(52146003)(81156014)(55236004)(16576012)(86362001)(8676002)(53546011)(31696002)(25786009)(52116002)(83506002)(2486003)(229853002)(6486002)(386003)(58126008)(53936002)(316002)(59450400001)(77096006)(50466002)(36756003)(76176011)(23676004)(105586002)(6246003)(31686004)(106356001)(39060400002)(97736004)(66066001)(65806001)(966005)(65826007)(2906002)(93886005)(4326008)(64126003)(81166006)(305945005)(47776003)(6116002)(5660300001)(6916009)(8936002)(6666003)(2950100002)(65956001)(6306002)(16526018)(3846002);DIR:OUT;SFP:1102;SCL:1;SRVR:AM4PR08MB2819;H:[172.16.25.12];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtBTTRQUjA4TUIyODE5OzIzOmZYRXlnY2JkTGJKVGNOZ05wYStuN0hSU296?= =?utf-8?B?bm03alE0QjRyemREZDMwb2JkSG5BRitFMCthZ2l0ZlZWWWkvT2pyb0JlaU9P?= =?utf-8?B?NkpUa3RRNldyNk1RUjRINW5pZVBTTyt0U1JoemRrOWsrVUpwZm5rcXYzWTZq?= =?utf-8?B?SmlZZ3RscWU0UytJQ2FvSDdibzR3Mk84R2JPQWxpaFJlL1lERGJuU3J3WFhH?= =?utf-8?B?dmpuMktkRHdna2ZKS28zK3h3cGhBa01XKzIvT2ZOL1JvdlJMMjFtNmc3Nys5?= =?utf-8?B?QTNQR1NhN3JCa05TZEozdVBYV0o1RU4vbEltUVpRbWprSnZJRFpEcFJialNY?= =?utf-8?B?Q0xkMm83RVhPaWpxUVF3ZVNLazlpaXB0RmtjMnJYUG5hcmZOQ2VTL09lTG1I?= =?utf-8?B?a1lpV2F6QUFKS1AyekN6Q2pBUzJEMjlKM0JWT3ZoKy8xK2lwL1ZCcVJISzRX?= =?utf-8?B?SGdJL3o2Z1EvZFhCNFZoTjdpdDdYSVdNaDdYdzZFaU9jSVBsT1YzT2I0UWFj?= =?utf-8?B?NFlGRSs4bk9EYjArT1hGQVZjL0ZSZ0VXVGljYnpEdnpSd0FPcnllQWlGVEtu?= =?utf-8?B?WldKY0tLbHdXZjNLbmRpUWRvTlZwQVRxM2dXZm54c25xNjFnRjc2Sk42cVc4?= =?utf-8?B?enVKU1ZieFIxdjJDRnMvWXlIOVZ4UW9idXpCd2dTc1pnNkwvbzBSNVJDbUhU?= =?utf-8?B?VG82Tlo5UC9DK202R2pGRDJGRXJUYW1UQ3BrY1RMQ2NFcC9xQ0ptOUtqNUVK?= =?utf-8?B?YjV2bzVYUURLc3RFTXJpR3NDbUdwRmoxbmtzTEFkU1RJUTZJUVVmOVFwZFMz?= =?utf-8?B?QXZ6Rk9aQnNSNHpJb2FMcWhmdGw1YXY2NjlmYXY0TXJ3amtXNHZRTytlckw3?= =?utf-8?B?QmtIMzVrcGhvMXNsRXRJakxwOTNxZ0psUlkzcmgzZDVSQXAvN2xHTmp2bUJB?= =?utf-8?B?ODN0ck9ScmdPbXRkMG93Q1BTNlIwSjBCNE9udXoxbnU3K3VCbGRmSHhNbm1v?= =?utf-8?B?N0ZXYlVraHdTbEhscE4zOXpLRG5XT0RLQUNsRUE1c0I2ZmRtS2pNbStGQnVo?= =?utf-8?B?ZFQweEFwdEFadE80VDl4UXFBSzFENFMwdjk0YkJhbHorR2ZvekcxRnpKMTB1?= =?utf-8?B?U29yL0lGR3NyR0c3Y2V1bXJSSHhmRFhPVHJTQS84ZjAwalBmSGRqREdSNUN6?= =?utf-8?B?cVZ6MG5BdnFLRUNQQ044UGliam5GN1JXUWtXWE82eTRhSWdUd24yR1pkLzMy?= =?utf-8?B?VGYxZGlJVUhRa2dzMCs0WUxWRVljMGJKdWdWbkJML0xIamlMTHhhK04wVkZ1?= =?utf-8?B?bTArSTArbW5idmRrQ0MrS21TcUZOSER2STlxKy9EMXZQdG1ta1RUZzB1WGJo?= =?utf-8?B?OEZvS1VFTjc1ZE4xRXdJOGpzWTMzZHd0SGhsLzZFMGc3RHZ0Um1JZFlkSEZu?= =?utf-8?B?VllzM0xLZFAwZEM2M1gycndRaHlDMHluZ3B0YnFZaVY2RW5DajY0dk43RkVh?= =?utf-8?B?TlErZXYvcEhNNlhpREhQbG96SnpWZW9HckMxdzRMdmFSRXkzTE84R2lqTkdT?= =?utf-8?B?TkJQVlBPQy9DSUEzekFNV3lsd3hYeVNFTUdHOGt5ZUQ1LzlpSGVjWHBYcUIz?= =?utf-8?B?TkVFQ3luRWxZVUhQdUNZbUkrZ2tzRTVoRXBydFJEMmp0MFVEWjdrWVJkNU1y?= =?utf-8?B?V3J0emJWN2hOZ3dQL0I0NnU4cjNUVFVzYXh1RCttdi9tS1dJeXdoNHNYeUV1?= =?utf-8?B?VVhoSTE0MmRlUUtUMmV5bUVjVlRrRk1ZeDhYeVEybWhzYXQwT3FsM1dFSFYx?= =?utf-8?B?aGlwM0JLQUJjRk1lRmpZSzM1VDZxcGNQcWlkd1FJWkNXTFhUME5VaEoxVEVU?= =?utf-8?B?R3hvN2xodkNqS0w1KzRXSWZyRkdNdzFlN01MeEEzWHBiKy8wWGNPVHN1aEox?= =?utf-8?B?MVJXTCtaMEpWcEtmZFJtMkJsaCtsWitjd0o2WVFsM2s4Y2pZeW5BQjMvQ2po?= =?utf-8?B?VnNmQUp4WXFqcGE5U0J2ZUF6TmNFWHRvZFJUaHFIMDJ4L2dlZ1FZT0djZ2hs?= =?utf-8?Q?xjTc=3D?= X-Microsoft-Exchange-Diagnostics: 1;AM4PR08MB2819;6:nBre9gqSRCBYDWerfpkXVcaAh1NH+EmZuwbwSu+l1iPV/keNWLc2GHsXNB0hOXSKh4AIbwz56/dZ0mHTpF5MjgrCk3tqajlJx3YSvMRTbqZNV7Wju8zhmJt7oYydoKYRDCbyNEaQCm2oTJ6AuUbTwRJ5ELCALh3vArN6dPuAHpanGQ8CJxI98MBQHYC8yncJSHZX7dqT5dUQsBPNPSdvywh16zIwDzCxpkKSfwO3j56TN8xY0EkkmE/Vnq5v+dPpybNtZqJgGQ06kTu6eXmZ0bhXPBfJr/rYOkjcreKANTF0CiXmSSiOKonAB/DI2ycFCN0Si6MVGiZq4wX6oo2EkFKka82azVmzlLDVCs+ibHE=;5:ghQWUKu80O3QaLOVD52NJ2UDKhVA0JR9VR9bAsGo4RwQy+ferU6EG7r6tTN6F0bJpOBIUc0yVOrFPuzZltizYNa/CKxHO/SNNAhnqU5U5zBDYycJbFWUCF5Ys/iL5yoURvH6BPGWvvG20reuPnaMBzBkivffi5aI8Gtpi6A9V7Y=;24:x3cahbLVtUI9vk3JxEMRigViBPaLDhxZD1FDpFDN2FmlDK5ly+qyMFsVOXpKhtMvuJNRXFv800DILIxTKaMtKKavA4IV/50hdUEH+pjy6Rw=;7:iCGli4jSCg48qaMcqPTy4g9p+RrAc/k5fahIPmKUOE7LnY94SqH2Hq1YxCgkIDI7uGYmhDlTW2wvcf5t1tDK+Mr92CvYpohsFS5dsKACPbiCCvu/wsbFJGTLozIx4hMfJWXj/mGeOKEAhzzD/yx2GHF5lp7pEQkOIZ3EoU9UHRXhEgH+GSq8DQLbRiVUwxPcnM7u/UxfnfD7FFlBAml1DnpxbN9MAJ9i/nh/QVVzXu7/UO64Mf3v3yiZP7tBLw5+ SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;AM4PR08MB2819;20:7D0lVDeDmPQRyyYr37R4ITtLf3PiFtlx1jbPttgG+BFiFGkkLD7FtNrGch6s7K3v4j7MJYnZIwOX+ql5e9hzwAjXQQRKkrbz2Lnl3XocH4A1hNYRdFfX7VsULNpLhEtFOnViUUdTdLL4PQzrMKa5hT91IEYF8Za91Pf7ddCsSBs= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jan 2018 17:26:24.5440 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0db1fcfb-69fc-4d17-9f42-08d557861c1a X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR08MB2819 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On 01/09/2018 08:10 PM, Shakeel Butt wrote: > On Tue, Jan 9, 2018 at 8:58 AM, Andrey Ryabinin wrote: >> mem_cgroup_resize_limit() and mem_cgroup_resize_memsw_limit() are almost >> identical functions. Instead of having two of them, we could pass an >> additional argument to mem_cgroup_resize_limit() and by using it, >> consolidate all the code in a single function. >> >> Signed-off-by: Andrey Ryabinin > > I think this is already proposed and Acked. > > https://patchwork.kernel.org/patch/10150719/ > Indeed. I'll rebase 1/2 patch on top, if it will be applied first. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f69.google.com (mail-pg0-f69.google.com [74.125.83.69]) by kanga.kvack.org (Postfix) with ESMTP id A5B846B0033 for ; Tue, 9 Jan 2018 12:26:29 -0500 (EST) Received: by mail-pg0-f69.google.com with SMTP id x24so4698157pge.13 for ; Tue, 09 Jan 2018 09:26:29 -0800 (PST) Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30100.outbound.protection.outlook.com. [40.107.3.100]) by mx.google.com with ESMTPS id k27si5461451pfh.225.2018.01.09.09.26.27 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 09 Jan 2018 09:26:28 -0800 (PST) Subject: Re: [PATCH v3 2/2] mm/memcg: Consolidate mem_cgroup_resize_[memsw]_limit() functions. References: <20171220135329.GS4831@dhcp22.suse.cz> <20180109165815.8329-1-aryabinin@virtuozzo.com> <20180109165815.8329-2-aryabinin@virtuozzo.com> From: Andrey Ryabinin Message-ID: <6ba40354-10d8-7955-7932-9dcd05ed5977@virtuozzo.com> Date: Tue, 9 Jan 2018 20:26:33 +0300 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Shakeel Butt Cc: Andrew Morton , Johannes Weiner , Vladimir Davydov , Cgroups , Linux MM , LKML , Michal Hocko On 01/09/2018 08:10 PM, Shakeel Butt wrote: > On Tue, Jan 9, 2018 at 8:58 AM, Andrey Ryabinin wrote: >> mem_cgroup_resize_limit() and mem_cgroup_resize_memsw_limit() are almost >> identical functions. Instead of having two of them, we could pass an >> additional argument to mem_cgroup_resize_limit() and by using it, >> consolidate all the code in a single function. >> >> Signed-off-by: Andrey Ryabinin > > I think this is already proposed and Acked. > > https://patchwork.kernel.org/patch/10150719/ > Indeed. I'll rebase 1/2 patch on top, if it will be applied first. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org